Skip to content

Commit 376bd49

Browse files
authored
fix: resolve passive warning (#281)
1 parent a4a01d7 commit 376bd49

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/List.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,9 +432,9 @@ export function RawList<T>(props: ListProps<T>, ref: React.Ref<ListRef>) {
432432
}
433433

434434
const componentEle = componentRef.current;
435-
componentEle.addEventListener('wheel', onRawWheel);
436-
componentEle.addEventListener('DOMMouseScroll', onFireFoxScroll as any);
437-
componentEle.addEventListener('MozMousePixelScroll', onMozMousePixelScroll);
435+
componentEle.addEventListener('wheel', onRawWheel, { passive: false });
436+
componentEle.addEventListener('DOMMouseScroll', onFireFoxScroll as any, { passive: true });
437+
componentEle.addEventListener('MozMousePixelScroll', onMozMousePixelScroll, { passive: false });
438438

439439
return () => {
440440
componentEle.removeEventListener('wheel', onRawWheel);

src/ScrollBar.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ const ScrollBar = React.forwardRef<ScrollBarRef, ScrollBarProps>((props, ref) =>
115115

116116
const scrollbarEle = scrollbarRef.current;
117117
const thumbEle = thumbRef.current;
118-
scrollbarEle.addEventListener('touchstart', onScrollbarTouchStart);
119-
thumbEle.addEventListener('touchstart', onThumbMouseDown);
118+
scrollbarEle.addEventListener('touchstart', onScrollbarTouchStart, { passive: false });
119+
thumbEle.addEventListener('touchstart', onThumbMouseDown, { passive: false });
120120

121121
return () => {
122122
scrollbarEle.removeEventListener('touchstart', onScrollbarTouchStart);
@@ -176,10 +176,10 @@ const ScrollBar = React.forwardRef<ScrollBarRef, ScrollBarProps>((props, ref) =>
176176
onStopMove();
177177
};
178178

179-
window.addEventListener('mousemove', onMouseMove);
180-
window.addEventListener('touchmove', onMouseMove);
181-
window.addEventListener('mouseup', onMouseUp);
182-
window.addEventListener('touchend', onMouseUp);
179+
window.addEventListener('mousemove', onMouseMove, { passive: true });
180+
window.addEventListener('touchmove', onMouseMove, { passive: true });
181+
window.addEventListener('mouseup', onMouseUp, { passive: true });
182+
window.addEventListener('touchend', onMouseUp, { passive: true });
183183

184184
return () => {
185185
window.removeEventListener('mousemove', onMouseMove);

src/hooks/useMobileTouchMove.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ export default function useMobileTouchMove(
6868
touchYRef.current = Math.ceil(e.touches[0].pageY);
6969

7070
elementRef.current = e.target as HTMLElement;
71-
elementRef.current.addEventListener('touchmove', onTouchMove);
72-
elementRef.current.addEventListener('touchend', onTouchEnd);
71+
elementRef.current.addEventListener('touchmove', onTouchMove, { passive: false });
72+
elementRef.current.addEventListener('touchend', onTouchEnd, { passive: true });
7373
}
7474
};
7575

@@ -82,7 +82,7 @@ export default function useMobileTouchMove(
8282

8383
useLayoutEffect(() => {
8484
if (inVirtual) {
85-
listRef.current.addEventListener('touchstart', onTouchStart);
85+
listRef.current.addEventListener('touchstart', onTouchStart, { passive: true });
8686
}
8787

8888
return () => {

0 commit comments

Comments
 (0)