Skip to content

Commit 37f3aa2

Browse files
authored
fix: πŸ› error in React 17 (#67)
1. replace useEffect with useLayoutEffect βœ… Closes: ant-design/ant-design#27006
1 parent 1ee9665 commit 37f3aa2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

β€Žexamples/animate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const MyItem: React.ForwardRefRenderFunction<any, MyItemProps> = (
5858
ref,
5959
) => {
6060
const motionRef = React.useRef(false);
61-
React.useEffect(() => {
61+
React.useLayoutEffect(() => {
6262
return () => {
6363
if (motionRef.current) {
6464
onAppear();

β€Žsrc/List.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ export function RawList<T>(props: ListProps<T>, ref: React.Ref<ListRef>) {
248248
return true;
249249
});
250250

251-
React.useEffect(() => {
251+
React.useLayoutEffect(() => {
252252
// Firefox only
253253
function onMozMousePixelScroll(e: Event) {
254254
if (inVirtual) {

β€Žsrc/hooks/useMobileTouchMove.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export default function useMobileTouchMove(
6666
}
6767
};
6868

69-
React.useEffect(() => {
69+
React.useLayoutEffect(() => {
7070
if (inVirtual) {
7171
listRef.current.addEventListener('touchstart', onTouchStart);
7272
}

0 commit comments

Comments
Β (0)