refactor: fix eslint errors (#1102)

* refactor: fix eslint errors

* refactor: update `eslint` and `typescript-eslint`

* ci: add lint to checks

Author: marcalexiei

.eslintrc.js

@@ -5,6 +5,7 @@ const ERROR = 2
 /* eslint-enable @typescript-eslint/no-unused-vars */
 
 module.exports = {
+  reportUnusedDisableDirectives: true,
   parser: "@typescript-eslint/parser",
   parserOptions: {
     ecmaVersion: 2020,
@@ -42,5 +43,7 @@ module.exports = {
     // jsx-ally
     "jsx-a11y/no-onchange": WARN,
     "import/no-anonymous-default-export": OFF,
+    // next
+    "@next/next/no-img-element": OFF,
   },
 }

.github/workflows/ci.yml

@@ -12,11 +12,16 @@ env:
   HUSKY: 0
 
 jobs:
-  ci:
-    name: CI
+  check:
+    name: Run ${{ matrix.script }} code check
     runs-on: ubuntu-latest
     timeout-minutes: 15
 
+    strategy:
+      fail-fast: true
+      matrix:
+        script: [format, lint]
+
     steps:
       - name: Checkout repo
         uses: actions/checkout@v4
@@ -34,6 +39,6 @@ jobs:
         shell: bash
         run: pnpm install --frozen-lockfile
 
-      - name: Format
+      - name: Run ${{ matrix.script }}
         run: |
-          pnpm run format
+          pnpm run ${{ matrix.script }}

package.json

@@ -34,11 +34,12 @@
   },
   "devDependencies": {
     "@next/bundle-analyzer": "^13.4.5",
+    "@types/react": "^18.3.11",
     "@types/react-helmet": "^6.1.6",
-    "@typescript-eslint/eslint-plugin": "^5.59.11",
-    "@typescript-eslint/parser": "^5.59.11",
+    "@typescript-eslint/eslint-plugin": "^8.18.0",
+    "@typescript-eslint/parser": "^8.18.0",
     "cross-env": "^7.0.3",
-    "eslint": "^8.42.0",
+    "eslint": "^8.57.1",
     "eslint-config-next": "^13.4.5",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
@@ -47,7 +48,7 @@
     "husky": "^8.0.3",
     "lint-staged": "^13.2.2",
     "prettier": "^3.4.2",
-    "typescript": "^5.1.3"
+    "typescript": "^5.6.3"
   },
   "keywords": [
     "react-hook-form",
@@ -60,7 +61,8 @@
     "dev": "next dev",
     "format": "prettier . --check",
     "format:fix": "prettier . --write",
-    "lint": "next lint --fix",
+    "lint": "next lint",
+    "lint:fix": "next lint --fix",
     "now-build": "pnpm run build",
     "start": "next start",
     "typecheck": "tsc --noEmit",