Skip to content

Conversation

@marcalexiei
Copy link
Contributor

Close #1096

I encountered the above linked issue when using the form builder in light mode.
To fix the issue I used var(--color-background) as background of the form-builder element
and var(--text-color) as border-color for the icons

This is the result:

image

@vercel
Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hook-form-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 3:21am

@marcalexiei marcalexiei marked this pull request as ready for review January 4, 2025 03:08
@marcalexiei marcalexiei force-pushed the form-builder-light-mode-bg-fix branch from 976f904 to 37dff93 Compare January 4, 2025 03:20
@marcalexiei marcalexiei changed the title fix(BuilderPage): use css variables for background and icon text fix(BuilderPage): use css variables for background and icon border color Jan 4, 2025
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@bluebill1049 bluebill1049 merged commit b5de4a5 into react-hook-form:master Jan 4, 2025
5 checks passed
@marcalexiei marcalexiei deleted the form-builder-light-mode-bg-fix branch January 4, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It seems like the colors of the form builder in light mode need some adjusting

2 participants