Skip to content

Commit 588753c

Browse files
feat: update doctor to reflect Java >= 17 (#2045)
* feat: update doctor to reflect Java >= 17 * test: update tests
1 parent 0cbed3d commit 588753c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/cli-doctor/src/tools/healthchecks/__tests__/jdk.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,17 @@ describe('jdk', () => {
3535
expect(diagnostics.needsToBeFixed).toBe(true);
3636
});
3737

38-
it('returns false if JDK version is in range (JDK [11-18] version number format)', async () => {
38+
it('returns false if JDK version is in range (JDK [17-20] version number format)', async () => {
3939
// @ts-ignore
4040
environmentInfo.Languages.Java = {
41-
version: '14.0.4',
41+
version: '17.0.8',
4242
};
4343

4444
const diagnostics = await jdk.getDiagnostics(environmentInfo);
4545
expect(diagnostics.needsToBeFixed).toBe(false);
4646
});
4747

48-
it('returns true if JDK version is not in range (JDK < 11 version number format)', async () => {
48+
it('returns true if JDK version is not in range (JDK < 17 version number format)', async () => {
4949
// @ts-ignore
5050
environmentInfo.Languages.Java = {
5151
version: '1.8.0_282',
@@ -55,10 +55,10 @@ describe('jdk', () => {
5555
expect(diagnostics.needsToBeFixed).toBe(true);
5656
});
5757

58-
it('returns true if JDK version is not in range (JDK > 18 version number format)', async () => {
58+
it('returns true if JDK version is not in range (JDK > 20 version number format)', async () => {
5959
// @ts-ignore
6060
environmentInfo.Languages.Java = {
61-
version: '19.0.1',
61+
version: '21.0.1',
6262
};
6363

6464
const diagnostics = await jdk.getDiagnostics(environmentInfo);

packages/cli-doctor/src/tools/versionRanges.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export default {
44
YARN: '>= 1.10.x',
55
NPM: '>= 4.x',
66
RUBY: '>= 2.6.10',
7-
JAVA: '>= 11 < 19',
7+
JAVA: '>= 17 <= 20',
88
// Android
99
ANDROID_SDK: '>= 33.x',
1010
ANDROID_NDK: '>= 23.x',

0 commit comments

Comments
 (0)