Skip to content

Commit 6f07e7e

Browse files
breaking: remove --configuration option (#2028)
1 parent fc9457e commit 6f07e7e

File tree

3 files changed

+3
-33
lines changed

3 files changed

+3
-33
lines changed

packages/cli-platform-ios/README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ Example: this will launch your project directly onto the iPhone 14 simulator:
4343
react-native run-ios --simulator "iPhone 14"
4444
```
4545

46-
#### `--configuration <string>`
47-
48-
[Deprecated] Explicitly set the scheme configuration to use default: 'Debug'.
49-
5046
#### `--mode <string>`
5147

5248
Explicitly set the scheme configuration to use. This option is case sensitive.
@@ -141,10 +137,6 @@ Example: this will launch your project directly onto the iPhone 14 simulator:
141137
react-native build-ios --simulator "iPhone 14"
142138
```
143139

144-
#### `--configuration <string>`
145-
146-
[Deprecated] Explicitly set the scheme configuration to use default: 'Debug'.
147-
148140
#### `--mode <string>`
149141

150142
Explicitly set the scheme configuration to use. This option is case sensitive.

packages/cli-platform-ios/src/commands/buildIOS/index.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {getConfigurationScheme} from '../../tools/getConfigurationScheme';
2424
import listIOSDevices from '../../tools/listIOSDevices';
2525

2626
export interface FlagsT extends BuildFlags {
27-
configuration?: string;
2827
simulator?: string;
2928
device?: string | true;
3029
udid?: string;
@@ -48,14 +47,6 @@ async function buildIOS(_: Array<string>, ctx: Config, args: FlagsT) {
4847

4948
process.chdir(sourceDir);
5049

51-
if (args.configuration) {
52-
logger.warn('--configuration has been deprecated. Use --mode instead.');
53-
logger.warn(
54-
'Parameters were automatically reassigned to --mode on this run.',
55-
);
56-
args.mode = args.configuration;
57-
}
58-
5950
const projectInfo = getProjectInfo();
6051

6152
if (args.mode) {
@@ -215,10 +206,6 @@ export const iosBuildOptions = [
215206
description:
216207
'Explicitly set the scheme configuration to use. This option is case sensitive.',
217208
},
218-
{
219-
name: '--configuration <string>',
220-
description: '[Deprecated] Explicitly set the scheme configuration to use',
221-
},
222209
{
223210
name: '--scheme <string>',
224211
description: 'Explicitly set Xcode scheme to use',

packages/cli-platform-ios/src/commands/runIOS/index.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import getSimulators from '../../tools/getSimulators';
2626

2727
export interface FlagsT extends BuildFlags {
2828
simulator?: string;
29-
configuration: string;
3029
scheme?: string;
3130
projectPath: string;
3231
device?: string | true;
@@ -70,14 +69,6 @@ async function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {
7069
}
7170
}
7271

73-
if (args.configuration) {
74-
logger.warn('--configuration has been deprecated. Use --mode instead.');
75-
logger.warn(
76-
'Parameters were automatically reassigned to --mode on this run.',
77-
);
78-
args.mode = args.configuration;
79-
}
80-
8172
const projectInfo = getProjectInfo();
8273

8374
if (args.mode) {
@@ -293,7 +284,7 @@ async function runOnSimulator(
293284

294285
appPath = await getBuildPath(
295286
xcodeProject,
296-
args.mode || args.configuration,
287+
args.mode,
297288
buildOutput,
298289
scheme,
299290
args.target,
@@ -375,7 +366,7 @@ async function runOnDevice(
375366

376367
const appPath = await getBuildPath(
377368
xcodeProject,
378-
args.mode || args.configuration,
369+
args.mode,
379370
buildOutput,
380371
scheme,
381372
args.target,
@@ -398,7 +389,7 @@ async function runOnDevice(
398389

399390
appPath = await getBuildPath(
400391
xcodeProject,
401-
args.mode || args.configuration,
392+
args.mode,
402393
buildOutput,
403394
scheme,
404395
args.target,

0 commit comments

Comments
 (0)