Skip to content

Commit 84e91a9

Browse files
liamjonesgrabbou
andauthored
feat(run-is): less noisy build failures with xcpretty (#1393)
* feat: less noisy run-ios build failures with xcpretty The run-ios command detects and uses xcpretty (https://github.com/xcpretty/xcpretty) if it's available. If it's not available it displays a loader/spinner animation until xcodebuild finishes. If a build failure happens then the buildOutput and errorOutput are included in the raised CLIError and printed out to the terminal. This makes sense when xcpretty isn't present as there has been no build output displayed up to now. However, if xcpretty is being used, this behaviour makes less sense: Firstly, xcpretty has been doing coloured output, nicely highlighting warnings and errors as they happened. The raised CLIError will repeat the output but without colours which means you have to scroll back up past a potential mountain of monochrome xcodebuild output to find the xcpretty output (or attempt to pick out the error from the monochrome output). Secondly, you will be prompted to "Run CLI with --verbose flag for more details." upon build failure anyway. If you use xcpretty then running the build again with the --verbose flag would force raw xcodebuild output (which would then including the buildOutput and errorOutput again). * Update index.ts Co-authored-by: Mike Grabowski <[email protected]>
1 parent e17d9b0 commit 84e91a9

File tree

1 file changed

+1
-1
lines changed
  • packages/platform-ios/src/commands/runIOS

1 file changed

+1
-1
lines changed

packages/platform-ios/src/commands/runIOS/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ function buildProject(
381381
logs further, consider building your app with Xcode.app, by opening
382382
${xcodeProject.name}.
383383
`,
384-
buildOutput + '\n' + errorOutput,
384+
xcodebuildOutputFormatter ? undefined : buildOutput + '\n' + errorOutput,
385385
),
386386
);
387387
return;

0 commit comments

Comments
 (0)