chore: migrate from chalk to picocolors
#2631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this only disables the colouring, not formatting functions (e.g. bold).
Rexogamer
requested review from
cipolleschi,
cortinico,
thymikee and
szymonrybczak
as code owners
Rexogamer
commented
Mar 20, 2025
packages/cli-config/src/__tests__/__snapshots__/index-test.ts.snap
Outdated
Show resolved
Hide resolved
szymonrybczak
approved these changes
Mar 20, 2025
|
rebased; should be mergeable |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
will rebase this soon |
|
okay this should be ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
picocolorsis much smaller and slightly faster thanchalk. this PR migrates the various CLI packages topicocolors.Test Plan
yarn test- worked fine with one minor change (see review comments). the output should be identical.Checklist