Skip to content

Commit 0f991f2

Browse files
committed
quick cleanup
1 parent 29dfdab commit 0f991f2

File tree

1 file changed

+33
-33
lines changed

1 file changed

+33
-33
lines changed

proposals/0011-introduce-reactNativeMeta.md

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -23,48 +23,48 @@ This is how this section would look like...
2323

2424
```json
2525
{
26-
"name": "@rnx-kit/metro-serializer",
27-
"version": "1.0.11",
28-
...,
29-
"reactNativeMeta": {
30-
"version": "2.3",
31-
"type": "library",
32-
"features": {
33-
"fabric": "true",
26+
"name": "@rnx-kit/metro-serializer",
27+
"version": "1.0.11",
28+
...,
29+
"reactNativeMeta": {
30+
"version": "2.3",
31+
"type": "library",
32+
"features": {
33+
"fabric": "true",
3434
"android": {
3535
"turbomodules": "true",
36-
},
37-
},
38-
"requirements": {
39-
"react-native": ">= 0.71.0",
40-
"expo": ">= 46.0.0",
41-
"expo-modules-core": "1.2.0"
36+
},
37+
},
38+
"requirements": {
39+
"react-native": ">= 0.71.0",
40+
"expo": ">= 46.0.0",
41+
"expo-modules-core": "1.2.0"
42+
}
4243
}
43-
...
4444
}
4545
```
4646

4747
...for an app:
4848

4949
```json
5050
{
51-
"name": "contoso",
52-
"version": "2.0.3",
53-
...,
54-
"reactNativeMeta": {
51+
"name": "contoso",
52+
"version": "2.0.3",
53+
...,
54+
"reactNativeMeta": {
5555
"version": "1.0",
5656
"type": "app",
5757
"features": {
58-
"newArchEnabled": "true",
59-
"android": {
60-
"codegen": "true",
61-
"turbomodules": "true",
62-
},
63-
// Future example
64-
// "metroExportsMode": "strict"
58+
"newArchEnabled": "true",
59+
"android": {
60+
"codegen": "true",
61+
"turbomodules": "true",
62+
},
63+
// Future example
64+
// "metroExportsMode": "strict"
6565
},
6666
...
67-
}
67+
}
6868
```
6969

7070
## Motivation
@@ -97,18 +97,18 @@ reactNativeMeta: {
9797
features: {
9898
// can be global...
9999
newArchEnabled: boolean,
100-
hermesEnabled: boolean,
100+
jsEngine: string, // ex. "hermes", "jsc", "V8"...
101101
// ...or platform specific
102102
android: {
103103
newArchEnabled: boolean,
104104
fabric: boolean,
105105
turbomodules: boolean,
106-
hermesEnabled: boolean,
106+
jsEngine: string,
107107
},
108-
ios: {
108+
iOs: {
109109
... // same as android
110110
},
111-
macos: {
111+
macOs: {
112112
... // same as android
113113
},
114114
windows: {
@@ -118,7 +118,7 @@ reactNativeMeta: {
118118
},
119119
// this section would most likely only be relevant for libraries
120120
requirements: {
121-
react-native: string, // semver compliant range of versions of RN supported
121+
"react-native": string, // semver compliant range of versions of RN supported
122122
expo: string, // semver compliant range of versions of Expo supported (if any)
123123
}
124124
}
@@ -130,7 +130,7 @@ The main drawback is that we'd need to convince developers to start using it, so
130130

131131
## Alternatives
132132

133-
This section is, in itself, fully original and new: there are other files that are used to define configurations for various aspect of react-native based projects (such as `react-native.config.js`, `app.json`, Expo's `app.config.js`, `expo-module.config.json`) but by design this section does **not** overlap with any of them. Explicitly, this one has the purpose of being filled only with metadata to be read by package managers and other tools.
133+
`reactNativeMeta` is, by design, fully original and new: there are other files that are used to define configurations for various aspect of react-native based projects (such as `react-native.config.js`, `app.json`, Expo's `app.config.js`, `expo-module.config.json`) but this one does **not** overlap with any of them. Explicitly, this one has the purpose of being filled only with metadata to be read by package managers and other tools.
134134

135135
## Adoption strategy
136136

0 commit comments

Comments
 (0)