Skip to content

Commit fb37517

Browse files
authored
Fixes a typo
sorry, I have this thing with typos
1 parent aff34df commit fb37517

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

proposals/0002-Turbo-Modules.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ When the JavaScript code like `require('NativeModule').DeviceInfoModule` is call
4242
> [TODO] - A work in process.
4343
4444
## Open Questions
45-
1. How would the C++ object corresponding to the shape of a Native Module know the Java class (for example com.facebook.react.nativemodule.DeviceInfo) that it needs to call. Does this need to be a switch/case or a map in Java/ObjC that is constructed manually ? Would this be done using BUCK dependencies ?
46-
2. Today, native modules usually take `ReactApplicationContext` as a parameter when they are constructed, but they can also be constructed in other ways like using a builder, or multiple parameters in the constructor. How would this be enforced ?
47-
3. How would the C++ code gen happen in Open Source, where BUCK is not used ?
48-
4. Since the generated C++ host objects have the same lifetime of the JS scopes they are referred in, what is the API to tell Java/ObjC when these objects are deallocated ?
49-
5. ReactModule options like `OnBatchCompleteListener` and `hasEagerInitialization` will be removed. Are they needed anymore, if yes - whats the alternative ?
50-
6. This method allows Native Modules to not be singletons. What would this new pattern look like ? Would this lead to memory leaks ?
51-
52-
## Backward Compatiability
45+
1. How would the C++ object corresponding to the shape of a Native Module know the Java class (for example com.facebook.react.nativemodule.DeviceInfo) that it needs to call. Does this need to be a switch/case or a map in Java/ObjC that is constructed manually? Would this be done using BUCK dependencies?
46+
2. Today, native modules usually take `ReactApplicationContext` as a parameter when they are constructed, but they can also be constructed in other ways like using a builder, or multiple parameters in the constructor. How would this be enforced?
47+
3. How would the C++ code gen happen in Open Source, where BUCK is not used?
48+
4. Since the generated C++ host objects have the same lifetime of the JS scopes they are referred in, what is the API to tell Java/ObjC when these objects are deallocated?
49+
5. ReactModule options like `OnBatchCompleteListener` and `hasEagerInitialization` will be removed. Are they needed anymore, if yes - whats the alternative?
50+
6. This method allows Native Modules to not be singletons. What would this new pattern look like? Would this lead to memory leaks?
51+
52+
## Backward Compatibility
5353
1. It looks like existing native modules do not have to change since they are usually singletons.

0 commit comments

Comments
 (0)