Skip to content

Commit 1ab42cd

Browse files
authored
Merge pull request #50 from Naturalclar/chore/addEslint
Add Eslint and Prettier
2 parents a30f739 + 59e7b01 commit 1ab42cd

15 files changed

+1048
-52
lines changed

.eslintrc.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
module.exports = {
2+
extends: ['@react-native-community'],
3+
rules: {
4+
semi: 0,
5+
},
6+
}

.prettierrc.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
module.exports = {
2+
bracketSpacing: false,
3+
jsxBracketSameLine: true,
4+
singleQuote: true,
5+
trailingComma: 'all',
6+
semi: false,
7+
};

package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"prepare":"yarn build",
99
"build": "yarn tsc",
1010
"release": "release-it",
11-
"test": "echo \"Error: no test specified\" && exit 1"
11+
"test": "echo \"Error: no test specified\" && exit 1",
12+
"lint": "eslint src/**/*.ts"
1213
},
1314
"author": "Nader Dabit",
1415
"license": "ISC",
@@ -17,12 +18,16 @@
1718
"react-native": ">=0.59"
1819
},
1920
"devDependencies": {
21+
"@react-native-community/eslint-config": "^0.0.7",
2022
"@types/react": "^16.9.10",
2123
"@types/react-native": "^0.60.21",
24+
"eslint": "^6.8.0",
25+
"eslint-plugin-prettier": "^3.1.2",
26+
"prettier": "^1.19.1",
2227
"release-it": "^12.3.5",
2328
"typescript": "^3.6.4"
2429
},
2530
"files": [
2631
"lib"
2732
]
28-
}
33+
}

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ export {
1919
useKeyboard,
2020
useInteractionManager,
2121
useDeviceOrientation,
22-
useLayout
22+
useLayout,
2323
}

src/useAccessibilityInfo.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect, useState } from 'react'
1+
import {useEffect, useState} from 'react'
22
import {
33
AccessibilityInfo,
44
AccessibilityChangeEvent,
@@ -39,5 +39,5 @@ export default function useAccessibilityInfo() {
3939
}
4040
}, [])
4141

42-
return { reduceMotionEnabled, screenReaderEnabled }
42+
return {reduceMotionEnabled, screenReaderEnabled}
4343
}

src/useAppState.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import React, { useEffect, useState } from 'react'
2-
import { AppState, AppStateStatus } from 'react-native'
1+
import {useEffect, useState} from 'react'
2+
import {AppState, AppStateStatus} from 'react-native'
33

44
export default function useAppState() {
55
const currentState = AppState.currentState

src/useBackHandler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import React, { useEffect } from 'react'
2-
import { BackHandler } from 'react-native'
1+
import {useEffect} from 'react'
2+
import {BackHandler} from 'react-native'
33

44
export default function useBackHandler(handler: () => void) {
55
useEffect(() => {

src/useCameraRoll.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
import React, { useState } from 'react'
2-
import {
3-
CameraRoll,
4-
GetPhotosParamType,
5-
GetPhotosReturnType,
6-
} from 'react-native'
1+
import {useState} from 'react'
2+
import {CameraRoll, GetPhotosParamType, GetPhotosReturnType} from 'react-native'
73

84
const initialState: GetPhotosReturnType = {
95
edges: [],

src/useClipboard.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import React, { useEffect, useState } from 'react'
2-
import { Clipboard } from 'react-native'
1+
import {useEffect, useState} from 'react'
2+
import {Clipboard} from 'react-native'
33

44
export default function useClipBoard() {
55
const [data, updateClipboardData] = useState('')

src/useDeviceOrientation.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import React, { useEffect, useState } from 'react'
2-
import { Dimensions, ScaledSize } from 'react-native'
1+
import {useEffect, useState, useCallback} from 'react'
2+
import {Dimensions, ScaledSize} from 'react-native'
33

44
const screen = Dimensions.get('screen')
55

@@ -24,20 +24,20 @@ export default function() {
2424
landscape: isOrientationLandscape(screen),
2525
})
2626

27-
const onChange = ({ screen }: { screen: ScaledSize }) => {
27+
const onChange = useCallback(({screen}: {screen: ScaledSize}) => {
2828
setOrientation({
2929
portrait: isOrientationPortrait(screen),
3030
landscape: isOrientationLandscape(screen),
3131
})
32-
}
32+
}, [])
3333

3434
useEffect(() => {
3535
Dimensions.addEventListener('change', onChange)
3636

3737
return () => {
3838
Dimensions.removeEventListener('change', onChange)
3939
}
40-
}, [orientation.portrait, orientation.landscape])
40+
}, [orientation.portrait, orientation.landscape, onChange])
4141

4242
return orientation
4343
}

0 commit comments

Comments
 (0)