Merge remote-tracking branch 'upstream/master'

Author: Greg-Bush

.all-contributorsrc

@@ -187,6 +187,17 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "Gamal-Shaban",
+      "name": "Gamal Shaban",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/17288652?v=4",
+      "profile": "https://github.com/Gamal-Shaban",
+      "contributions": [
+        "code",
+        "doc",
+        "test"
+      ]
     }
   ],
   "contributorsPerLine": 7

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 
 
 orbs:
-  rn: react-native-community/react-native@3.0.1
+  rn: react-native-community/react-native@4.1.0
 
 
 jobs:
@@ -52,12 +52,12 @@ workflows:
         - analyze:
             requires:
               - checkout_code
-        - release-canary:
-            requires:
-              - analyze
-            filters:
-              branches:
-                ignore: master
+        # - release-canary:
+        #     requires:
+        #       - analyze
+        #     filters:
+        #       branches:
+        #         ignore: master
         - release:
             requires:
               - analyze

CHANGELOG.md

@@ -1,3 +1,97 @@
+# v2.4.9 (Mon Apr 13 2020)
+
+:tada: This release contains work from a new contributor! :tada:
+
+Thank you, WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot)), for all your work!
+
+#### 🐛 Bug Fix
+
+- Update dependency @auto-it/first-time-contributor to v9.26.4 [#134](https://github.com/react-native-community/hooks/pull/134) ([@renovate-bot](https://github.com/renovate-bot))
+- add value to Coordinates when hide [#120](https://github.com/react-native-community/hooks/pull/120) ([@Gamal-Shaban](https://github.com/Gamal-Shaban) [@pvinis](https://github.com/pvinis))
+- Update dependency @auto-it/all-contributors to v9.26.8 [#114](https://github.com/react-native-community/hooks/pull/114) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency ts-jest to v25.3.1 [#119](https://github.com/react-native-community/hooks/pull/119) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @types/react-native to v0.62.2 [#110](https://github.com/react-native-community/hooks/pull/110) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency auto to v9.26.8 [#123](https://github.com/react-native-community/hooks/pull/123) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency jest to v25.3.0 [#138](https://github.com/react-native-community/hooks/pull/138) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update rn orb to v4 [#141](https://github.com/react-native-community/hooks/pull/141) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency eslint-plugin-prettier to v3.1.3 [#142](https://github.com/react-native-community/hooks/pull/142) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.8 [#137](https://github.com/react-native-community/hooks/pull/137) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency react-native to v0.62.2 [#139](https://github.com/react-native-community/hooks/pull/139) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.6 [#136](https://github.com/react-native-community/hooks/pull/136) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.5 [#135](https://github.com/react-native-community/hooks/pull/135) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @types/jest to v25.2.1 [#129](https://github.com/react-native-community/hooks/pull/129) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @auto-it/first-time-contributor to v9.26.3 [#133](https://github.com/react-native-community/hooks/pull/133) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.2 [#132](https://github.com/react-native-community/hooks/pull/132) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency prettier to v2.0.4 [#131](https://github.com/react-native-community/hooks/pull/131) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.1 [#115](https://github.com/react-native-community/hooks/pull/115) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency prettier to v2.0.3 [#130](https://github.com/react-native-community/hooks/pull/130) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency react-native to v0.62.1 [#128](https://github.com/react-native-community/hooks/pull/128) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.7 [#127](https://github.com/react-native-community/hooks/pull/127) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @types/jest to v25.1.5 [#126](https://github.com/react-native-community/hooks/pull/126) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency all-contributors-cli to v6.14.1 [#125](https://github.com/react-native-community/hooks/pull/125) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.6 [#124](https://github.com/react-native-community/hooks/pull/124) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.22.4 [#122](https://github.com/react-native-community/hooks/pull/122) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.22.2 [#121](https://github.com/react-native-community/hooks/pull/121) ([@renovate-bot](https://github.com/renovate-bot))
+
+#### ⚠️  Pushed to `master`
+
+- dont worry about canary, since we cant publish from forks ([@pvinis](https://github.com/pvinis))
+
+#### Authors: 4
+
+- [@renovate[bot]](https://github.com/renovate[bot])
+- Gamal Shaban ([@Gamal-Shaban](https://github.com/Gamal-Shaban))
+- Pavlos Vinieratos ([@pvinis](https://github.com/pvinis))
+- WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot))
+
+---
+
+# v2.4.8 (Mon Mar 30 2020)
+
+:tada: This release contains work from new contributors! :tada:
+
+Thanks for all your work!
+
+:heart: Gamal Shaban ([@Gamal-Shaban](https://github.com/Gamal-Shaban))
+
+:heart: WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot))
+
+#### 🐛 Bug Fix
+
+- Update dependency react-native to v0.62.0 [#105](https://github.com/react-native-community/hooks/pull/105) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- fix crash in android when hide keyboard [#117](https://github.com/react-native-community/hooks/pull/117) ([@Gamal-Shaban](https://github.com/Gamal-Shaban))
+- Update dependency auto to v9.22.1 [#116](https://github.com/react-native-community/hooks/pull/116) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @auto-it/first-time-contributor to v9.21.2 [#112](https://github.com/react-native-community/hooks/pull/112) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.21.2 [#113](https://github.com/react-native-community/hooks/pull/113) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/all-contributors to v9.21.2 [#111](https://github.com/react-native-community/hooks/pull/111) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @react-native-community/eslint-config to v1 [#109](https://github.com/react-native-community/hooks/pull/109) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency jest to v25.2.3 [#108](https://github.com/react-native-community/hooks/pull/108) ([@renovate-bot](https://github.com/renovate-bot))
+- [META] Stop using default export internally [#106](https://github.com/react-native-community/hooks/pull/106) ([@pvinis](https://github.com/pvinis))
+- Update dependency jest to v25.2.4 [#118](https://github.com/react-native-community/hooks/pull/118) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.2 [#104](https://github.com/react-native-community/hooks/pull/104) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.1 [#103](https://github.com/react-native-community/hooks/pull/103) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.0 [#102](https://github.com/react-native-community/hooks/pull/102) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @types/react to v16.9.25 [#98](https://github.com/react-native-community/hooks/pull/98) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @auto-it/first-time-contributor to v9.20.1 [#93](https://github.com/react-native-community/hooks/pull/93) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.20.1 [#94](https://github.com/react-native-community/hooks/pull/94) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/all-contributors to v9.20.1 [#92](https://github.com/react-native-community/hooks/pull/92) ([@renovate-bot](https://github.com/renovate-bot))
+- Update react monorepo to v16.13.1 [#91](https://github.com/react-native-community/hooks/pull/91) ([@renovate-bot](https://github.com/renovate-bot))
+
+#### ⚠️  Pushed to `master`
+
+- get rid of some shadowing ([@pvinis](https://github.com/pvinis))
+- bump pretteir ([@pvinis](https://github.com/pvinis))
+- upg ([@pvinis](https://github.com/pvinis))
+
+#### Authors: 4
+
+- [@renovate[bot]](https://github.com/renovate[bot])
+- Gamal Shaban ([@Gamal-Shaban](https://github.com/Gamal-Shaban))
+- Pavlos Vinieratos ([@pvinis](https://github.com/pvinis))
+- WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot))
+
+---
+
 # v2.4.7 (Thu Mar 19 2020)
 
 :tada: This release contains work from new contributors! :tada:

README.md

@@ -204,6 +204,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
     <td align="center"><a href="https://dylanvann.com/"><img src="https://avatars0.githubusercontent.com/u/1537615?v=4" width="100px;" alt=""/><br /><sub><b>Dylan Vann</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=DylanVann" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/thinklinux"><img src="https://avatars1.githubusercontent.com/u/326949?v=4" width="100px;" alt=""/><br /><sub><b>Tihomir Valkanov</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=thinklinux" title="Documentation">📖</a></td>
     <td align="center"><a href="http://twitter.com/pistoudev"><img src="https://avatars1.githubusercontent.com/u/6703711?v=4" width="100px;" alt=""/><br /><sub><b>Pierre Skowron</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=pistou" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/Gamal-Shaban"><img src="https://avatars1.githubusercontent.com/u/17288652?v=4" width="100px;" alt=""/><br /><sub><b>Gamal Shaban</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Code">💻</a> <a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Documentation">📖</a> <a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Tests">⚠️</a></td>
   </tr>
 </table>
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native-community/hooks",
-  "version": "2.4.7",
+  "version": "2.4.9",
   "description": "",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -19,24 +19,24 @@
     "react-native": ">=0.59"
   },
   "devDependencies": {
-    "@auto-it/all-contributors": "9.21.0",
-    "@auto-it/first-time-contributor": "9.21.0",
-    "@react-native-community/eslint-config": "0.0.7",
+    "@auto-it/all-contributors": "9.26.8",
+    "@auto-it/first-time-contributor": "9.26.8",
+    "@react-native-community/eslint-config": "1.0.0",
     "@testing-library/react-hooks": "3.2.1",
     "@testing-library/react-native": "5.0.3",
-    "@types/jest": "25.1.4",
-    "@types/react": "16.9.25",
-    "@types/react-native": "0.61.23",
-    "all-contributors-cli": "6.14.0",
-    "auto": "9.21.0",
+    "@types/jest": "25.2.1",
+    "@types/react": "16.9.34",
+    "@types/react-native": "0.62.2",
+    "all-contributors-cli": "6.14.1",
+    "auto": "9.26.8",
     "eslint": "6.8.0",
-    "eslint-plugin-prettier": "3.1.2",
-    "jest": "25.2.2",
-    "prettier": "2.0.2",
+    "eslint-plugin-prettier": "3.1.3",
+    "jest": "25.3.0",
+    "prettier": "2.0.4",
     "react": "16.13.1",
-    "react-native": "0.62.0",
+    "react-native": "0.62.2",
     "react-test-renderer": "16.13.1",
-    "ts-jest": "25.2.1",
+    "ts-jest": "25.3.1",
     "typescript": "3.8.3"
   },
   "author": "Nader Dabit",

src/useKeyboard.ts

@@ -1,15 +1,23 @@
 import {useEffect, useState} from 'react'
 import {Keyboard, KeyboardEventListener, ScreenRect} from 'react-native'
 
+const emptyCoordinates = Object.freeze({
+  screenX: 0,
+  screenY: 0,
+  width: 0,
+  height: 0,
+})
+const initialValue = {
+  start: emptyCoordinates,
+  end: emptyCoordinates,
+}
+
 export function useKeyboard() {
   const [shown, setShown] = useState(false)
   const [coordinates, setCoordinates] = useState<{
     start: ScreenRect
     end: ScreenRect
-  }>({
-    start: {screenX: 0, screenY: 0, width: 0, height: 0},
-    end: {screenX: 0, screenY: 0, width: 0, height: 0},
-  })
+  }>(initialValue)
   const [keyboardHeight, setKeyboardHeight] = useState<number>(0)
 
   const handleKeyboardWillShow: KeyboardEventListener = (e) => {
@@ -25,8 +33,12 @@ export function useKeyboard() {
   }
   const handleKeyboardDidHide: KeyboardEventListener = (e) => {
     setShown(false)
-    setCoordinates({start: e.startCoordinates, end: e.endCoordinates})
-    setKeyboardHeight(0)
+    if (e) {
+      setCoordinates({start: e.startCoordinates, end: e.endCoordinates})
+    } else {
+      setCoordinates(initialValue)
+      setKeyboardHeight(0)
+    }
   }
 
   useEffect(() => {

tsconfig.json

@@ -21,6 +21,7 @@
     // "importHelpers": true,                 /* Import emit helpers from 'tslib'. */
     // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
     // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
+    "skipLibCheck": true,
 
     /* Strict Type-Checking Options */
     "strict": true,                           /* Enable all strict type-checking options. */