Skip to content

Commit 7e7bf72

Browse files
authored
Fix cppruntime duplicated package name causes build error (#97)
Summary: Gradle will have a build error during generating APK if user depends both android-jsc and android-jsc-cppruntime. ``` > Task :app:transformDexArchiveWithExternalLibsDexMergerForDebug FAILED D8: Program type already present: org.webkit.androidjsc.BuildConfig ``` The reason is that gradle will generate BuildConfig from each libraries and there are two duplicated org.webkit.androidjsc.BuildConfig. Test Plan: Pure RN 0.57 + JSC from this repo (build locally or from CircleCI). To test if gradle could generate APK successfully.
1 parent d4f4f90 commit 7e7bf72

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2-
package="org.webkit.androidjsc" />
2+
package="org.webkit.androidjsc_cppruntime" />

0 commit comments

Comments
 (0)