Skip to content

Commit 9061e40

Browse files
committed
x64 is faster. measured with custom built RN51
1 parent 8697f68 commit 9061e40

File tree

6 files changed

+33
-10
lines changed

6 files changed

+33
-10
lines changed

measure/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,6 @@ The table blow is generated by calling `npm run generateReadmeTable`
3838
| - | - | webkitGTK:2.17.1<br/>androidICU:7.1.2_r11<br/>i18n:false<br/>env:nojit<br/> | 216113 | 2017-05-03 | 563 | 1045 | 9164 | 3856 | 574 | 900 | 1165 | 5.9/8.8 |
3939
| 224109.0.0 | 2018-06-04 | webkitGTK:2.18.2<br/>androidICU:8.0.0_r34<br/>i18n:false<br/> | 224109 | 2017-10-27 | 575 | 461 | 3148 | 1884 | 423 | 899 | 1182 | 6.1/9.3 |
4040
| 224109.0.0 | 2018-06-04 | webkitGTK:2.18.2<br/>androidICU:8.0.0_r34<br/>i18n:true<br/> | 224109 | 2017-10-27 | 598 | 462 | 3115 | 1885 | 415 | 911 | 1094 | 13/16 |
41+
| 224109.0.0 | 2018-06-04 | webkitGTK:2.18.2<br/>androidICU:8.0.0_r34<br/>i18n:false<br/>env:react-native@0.51 x64<br/> | 224109 | 2017-10-27 | 517 | 423 | 2739 | 1486 | 343 | 1154 | 1304 | 13/16 |
4142

4243

measure/android/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ ext {
77

88
def i18nProp = project.findProperty("i18n")
99
JSC_NAME = Boolean.valueOf(i18nProp) ? "android-jsc-intl" : "android-jsc"
10-
11-
// ABI_FILTERS = JSC_VERSION && JSC_VERSION.contains("x64") ? ["armeabi-v7a", "x86", "arm64-v8a", "x86_64"] : []
1210
}
1311

1412
if (JSC_VERSION) {
@@ -37,7 +35,7 @@ buildscript {
3735
mavenLocal()
3836
}
3937
dependencies {
40-
classpath 'com.android.tools.build:gradle:3.1.2'
38+
classpath 'com.android.tools.build:gradle:3.1.3'
4139
}
4240
}
4341

measure/android/gradle.properties

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,3 @@
1616
# This option should only be used with decoupled projects. More details, visit
1717
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
1818
# org.gradle.parallel=true
19-
20-
android.useDeprecatedNdk=true
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.7-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.8-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

measure/results.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,5 +129,25 @@
129129
"renderflat": "911",
130130
"renderdeep": "1094",
131131
"size": "13/16"
132+
},
133+
{
134+
"npm": "224109.0.0",
135+
"date": "2018-06-04",
136+
"config": {
137+
"webkitGTK": "2.18.2",
138+
"androidICU": "8.0.0_r34",
139+
"i18n": false,
140+
"env": "[email protected] x64"
141+
},
142+
"revision": "224109",
143+
"revisionDate": "2017-10-27",
144+
"tti": "517",
145+
"sunspider": "423",
146+
"jetstream": "2739",
147+
"octane2": "1486",
148+
"sixspeed": "343",
149+
"renderflat": "1154",
150+
"renderdeep": "1304",
151+
"size": "13/16"
132152
}
133153
]

measure/scripts/measure.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ const TESTS = {
2020
run();
2121

2222
function run() {
23-
installProfiler();
24-
2523
let resultsStr = '';
24+
installProfiler();
2625

27-
_.times(TIMES, () => {
26+
_.times(TIMES, (i) => {
27+
console.log(`test #${i}:`);
2828
clearLogcat();
2929

3030
launchProfiler();
@@ -84,25 +84,31 @@ function waitForLogcatMsg(msg) {
8484
}
8585

8686
function launchProfiler() {
87-
exec.execSyncSilent(`adb shell am start-activity -W "${PACKAGE_NAME}/.${ACTIVITY_NAME}" && sleep 1`);
87+
console.log(`launching...`);
88+
exec.execSyncSilent(`adb shell am start-activity -W "${PACKAGE_NAME}/.${ACTIVITY_NAME}" && sleep 2`);
8889
}
8990

9091
function killProfiler() {
92+
console.log(`killing`);
9193
exec.execSyncSilent(`adb shell am force-stop ${PACKAGE_NAME}`);
9294
exec.execSyncSilent(`adb shell am kill ${PACKAGE_NAME}`);
95+
exec.execSyncSilent(`sleep 2`);
9396
}
9497

9598
function clickOnJsTest() {
99+
console.log(`js test`);
96100
exec.execSyncSilent(`adb shell input tap 720 1008`); // TODO replace with non-magical values
97101
waitForLogcatMsg(`${LOGCAT_TAG}:JSProfile:Done`);
98102
}
99103

100104
function clickOnFlatRenderTest() {
105+
console.log(`flat render test`);
101106
exec.execSyncSilent(`adb shell input tap 720 1240`); // TODO replace with non-magical values
102107
waitForLogcatMsg(`${LOGCAT_TAG}:RenderFlatResult:`);
103108
}
104109

105110
function clickOnDeepRenderTest() {
111+
console.log(`deep render test`);
106112
exec.execSyncSilent(`adb shell input tap 720 1470`);// TODO replace with non-magical values
107113
waitForLogcatMsg(`${LOGCAT_TAG}:RenderDeepResult:`);
108114
}

0 commit comments

Comments
 (0)