Skip to content

Commit a7d373e

Browse files
authored
Merge pull request #172 from devnev/no-java-options-env
fix: remove _JAVA_OPTIONS parameter & environment BREAKING CHANGE: The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.
2 parents faee857 + d737af9 commit a7d373e

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

src/executors/linux_android.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
parameters:
2-
java_options:
3-
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
4-
type: string
5-
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
62
gradle_options:
73
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
84
type: string
@@ -19,5 +15,4 @@ docker:
1915
- image: reactnativecommunity/react-native-android:<<parameters.build_image_version>>
2016
resource_class: <<parameters.resource_class>>
2117
environment:
22-
- _JAVA_OPTIONS: <<parameters.java_options>>
2318
- GRADLE_OPTS: <<parameters.gradle_options>>

src/jobs/android_build.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@ parameters:
4747
description: Configure the android tests to run. Defaults to assembleAndroidTest
4848
type: string
4949
default: assembleAndroidTest
50-
java_options:
51-
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
52-
type: string
53-
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
5450
gradle_options:
5551
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
5652
type: string
@@ -66,7 +62,6 @@ parameters:
6662

6763
executor:
6864
name: linux_android
69-
java_options: <<parameters.java_options>>
7065
gradle_options: <<parameters.gradle_options>>
7166
build_image_version: <<parameters.build_image_version>>
7267
resource_class: <<parameters.resource_class>>

0 commit comments

Comments
 (0)