Skip to content

Commit 6b81b4e

Browse files
author
Lucas Bento
authored
Merge pull request #133 from react-native-community/fix/close-button-consistency
Change the close button on `UsefulContentSection` to match the app name warning
2 parents e1b1a84 + 554c863 commit 6b81b4e

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/__tests__/components/common/__snapshots__/UsefulContentSection.spec.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ exports[`renders without crashing 1`] = `
1919
Useful content for upgrading
2020
</h2>
2121
<button
22-
class="ant-btn sc-EHOje xNCZY ant-btn-ghost ant-btn-circle ant-btn-icon-only"
22+
class="ant-btn sc-EHOje kMAZtT ant-btn-link ant-btn-icon-only"
2323
type="button"
2424
>
2525
<i

src/components/common/UsefulContentSection.js

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,18 @@ const Icon = styled(props => (
2929
`
3030

3131
const CloseButton = styled(({ toggleVisibility, ...props }) => (
32-
<Button
33-
{...props}
34-
type="ghost"
35-
shape="circle"
36-
icon="close"
37-
onClick={toggleVisibility}
38-
/>
32+
<Button {...props} type="link" icon="close" onClick={toggleVisibility} />
3933
))`
4034
float: right;
4135
position: absolute;
42-
top: 10px;
43-
right: 10px;
36+
top: 11px;
37+
right: 12px;
4438
font-size: 12px;
4539
border-width: 0px;
4640
width: 20px;
4741
height: 20px;
4842
margin-right: 8px;
49-
&,
43+
color: rgba(0, 0, 0, 0.45);
5044
&:hover,
5145
&:focus {
5246
color: #24292e;

0 commit comments

Comments
 (0)