Skip to content

Commit d15f413

Browse files
authored
Merge pull request #107 from react-native-community/add-62
some comments on 62
2 parents 1a3140b + 9ac4e4c commit d15f413

File tree

4 files changed

+57
-1
lines changed

4 files changed

+57
-1
lines changed

CONTRIBUTING.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
## 💻 Contributing
2+
3+
If you want to help us making this better, you can start by forking the project and follow these steps to testing it out locally:
4+
5+
1. Clone the project
6+
1. Run `yarn install`
7+
1. Run `yarn start`
8+
1. Open `http://localhost:3000`
9+
1. Select starting & target versions
10+
1. Click the `Show me how to upgrade` button
11+
12+
After which, you can create a branch to to make your changes and then open a PR against this repository following the provided template 🤗
13+
14+
## Adding comments, notes, links to releases
15+
16+
Inside `src/releases`, there are files for each release of React Native. `0.60.js` is a great example of how to add a description, some links, and some inline comments on the diff.

src/components/pages/Home.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ const TitleContainer = styled.div`
2828
align-items: center;
2929
`
3030

31+
const Subtitle = styled.div({
32+
display: 'flex',
33+
alignItems: 'center',
34+
marginTop: 50
35+
})
36+
3137
const LogoImg = styled.img`
3238
width: 100px;
3339
margin-bottom: 15px;
@@ -112,6 +118,12 @@ const Home = () => {
112118
showDiff={handleShowDiff}
113119
showReleaseCandidates={settings[SHOW_LATEST_RCS]}
114120
/>
121+
122+
<Subtitle>
123+
Don't forget: `RnDiffApp` is a placeholder. When upgrading, all
124+
instances of `RnDiffApp` should be `YourProjectName`, all `rndiffapp`
125+
should be `yourprojectname` etc.
126+
</Subtitle>
115127
</Container>
116128

117129
<DiffViewer

src/releases/0.62.js

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import React, { Fragment } from 'react'
2+
3+
export default {
4+
usefulContent: {
5+
description:
6+
'React Native 0.62 includes built-in integration with Flipper.',
7+
links: []
8+
},
9+
comments: [
10+
{
11+
fileName: '.gitignore',
12+
lineNumber: 23,
13+
lineChangeType: 'add',
14+
content: (
15+
<Fragment>
16+
This line should not be here. Please ignore this. It will be removed
17+
on an upcoming release. Because of this line, the files
18+
`ios/RnDiffApp.xcodeproj/xcshareddata/xcschemes/RnDiffApp.xcscheme`
19+
and
20+
`ios/RnDiffApp.xcodeproj/xcshareddata/xcschemes/RnDiffApp-tvOS.xcscheme`
21+
appear as deleted. They should not be deleted from your project.
22+
Ignore these two changes as well.
23+
</Fragment>
24+
)
25+
}
26+
]
27+
}

src/releases/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
const versions = ['0.61', '0.60', '0.59', '0.58', '0.57']
1+
// this line HAAAAAAAAS to go
2+
const versions = ['0.62', '0.61', '0.60', '0.59', '0.58', '0.57']
23

34
export default versions.map(version => ({
45
...require(`./${version}`).default,

0 commit comments

Comments
 (0)