Skip to content

Commit 08072ae

Browse files
authored
Wrap Android dismiss methods in try-catch blocks (#449)
* Wrap Android dismiss methods in try-catch blocks * Move try-catch block to dismissDialog method
1 parent f9238ab commit 08072ae

File tree

1 file changed

+11
-7
lines changed
  • android/src/main/java/com/reactcommunity/rndatetimepicker

1 file changed

+11
-7
lines changed

android/src/main/java/com/reactcommunity/rndatetimepicker/Common.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,18 @@ public static void dismissDialog(FragmentActivity activity, String fragmentTag,
1616
return;
1717
}
1818

19-
FragmentManager fragmentManager = activity.getSupportFragmentManager();
20-
final DialogFragment oldFragment = (DialogFragment) fragmentManager.findFragmentByTag(fragmentTag);
19+
try {
20+
FragmentManager fragmentManager = activity.getSupportFragmentManager();
21+
final DialogFragment oldFragment = (DialogFragment) fragmentManager.findFragmentByTag(fragmentTag);
2122

22-
boolean fragmentFound = oldFragment != null;
23-
if (fragmentFound) {
24-
oldFragment.dismiss();
25-
}
23+
boolean fragmentFound = oldFragment != null;
24+
if (fragmentFound) {
25+
oldFragment.dismiss();
26+
}
2627

27-
promise.resolve(fragmentFound);
28+
promise.resolve(fragmentFound);
29+
} catch (Exception e) {
30+
promise.reject(e);
31+
}
2832
}
2933
}

0 commit comments

Comments
 (0)