chore: update repo and example to React Native 0.73 (#879)

* ^ This is a combination of 2 commits.
^ This is the 1st commit message:

Update RNTA to 0.73

^ The commit message #2 will be skipped:

^ update RNTA

* Try remove test butler

* Remove E2E tests for Android new arch

* Pick up main's version of ComponentDescriptor

* Update react-native-localize and locks

* Undo comment out test-butler

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

Co-authored-by: Vojtech Novak <[email protected]>

* Update package.json

* Update lock

---------

Co-authored-by: Vojtech Novak <[email protected]>

Author: Saadnajmi

.circleci/config.yml

@@ -33,7 +33,7 @@ jobs:
   new_arch_ios_build_only:
     executor:
       name: rn/macos
-      xcode_version: '15.0.0'
+      xcode_version: '15.3.0'
     steps:
       - checkout
       - run:
@@ -50,7 +50,7 @@ jobs:
   e2e_release_ios:
     executor:
       name: rn/macos
-      xcode_version: '15.0.0'
+      xcode_version: '15.3.0'
     steps:
       - checkout
       - run:
@@ -127,7 +127,7 @@ jobs:
           path: ./artifacts
 
 
-  e2e_release_android_new_arch:
+  new_arch_android_build_only:
     executor:
       name: android/android-machine
       resource-class: large
@@ -164,9 +164,6 @@ jobs:
           name: build app for e2e tests
       #      - android/wait-for-emulator
       #      - android/disable-animations
-      - run:
-          command: yarn detox:android:test:release
-          name: run e2e tests
       - store_artifacts:
           path: ./artifacts
 
@@ -191,12 +188,12 @@ workflows:
       - analyse_js
       - e2e_release_ios
       - e2e_release_android
-      - e2e_release_android_new_arch
+      - new_arch_android_build_only
       - new_arch_ios_build_only
       - publish:
           requires:
             - e2e_release_android
-            - e2e_release_android_new_arch
+            - new_arch_android_build_only
             - e2e_release_ios
             - new_arch_ios_build_only
           filters:

.flowconfig

@@ -15,6 +15,7 @@ node_modules/react-native/Libraries/polyfills/.*
 
 [untyped]
 .*/node_modules/@react-native-community/cli/.*/.*
+.*/test/.*
 
 [include]
 
@@ -63,4 +64,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.182.0
+^0.217.0

RNDateTimePicker.podspec

@@ -10,7 +10,7 @@ Pod::Spec.new do |s|
   s.license      = package['license']
   s.author       = package['author']
   s.homepage     = package['homepage']
-  s.platforms = { :ios => "11.0", :visionos => "1.0" }
+  s.platforms    = { :ios => "11.0", :visionos => "1.0" }
   s.source       = { :git => "https://github.com/react-native-community/datetimepicker", :tag => "v#{s.version}" }
   s.source_files = "ios/**/*.{h,m,mm,cpp}"
   s.requires_arc = true

android/src/main/AndroidManifest.xml

@@ -1,3 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.reactcommunity.rndatetimepicker">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
   <application />
 </manifest>

babel.config.js

@@ -4,7 +4,7 @@ const isLintingOrTesting =
 module.exports = {
   presets: [
     [
-      'module:metro-react-native-babel-preset',
+      'module:@react-native/babel-preset',
       // this is a workaround for some deeper issue
       {useTransformReactJSXExperimental: !isLintingOrTesting},
     ],

example/.gitignore

@@ -6,9 +6,11 @@
 .gradle/
 .idea/
 .vs/
+.xcode.env
 Pods/
 build/
-dist/
+dist/*
+!dist/.gitignore
 local.properties
 msbuild.binlog
 node_modules/

example/App.js

@@ -25,7 +25,7 @@ import {
   IOS_MODE,
   ANDROID_DISPLAY,
   IOS_DISPLAY,
-} from '../src/constants';
+} from '@react-native-community/datetimepicker/src/constants';
 import * as RNLocalize from 'react-native-localize';
 
 const timezone = [
@@ -632,3 +632,5 @@ const styles = StyleSheet.create({
     width: 350,
   },
 });
+
+export default App;

example/android/build.gradle

@@ -1,6 +1,14 @@
 buildscript {
-    def androidTestAppDir = "../../node_modules/react-native-test-app/android"
-    apply(from: "${androidTestAppDir}/dependencies.gradle")
+    apply(from: {
+        def searchDir = rootDir.toPath()
+        do {
+            def p = searchDir.resolve("node_modules/react-native-test-app/android/dependencies.gradle")
+            if (p.toFile().exists()) {
+                return p.toRealPath().toString()
+            }
+        } while (searchDir = searchDir.getParent())
+        throw new GradleException("Could not find `react-native-test-app`");
+    }())
 
     repositories {
         mavenCentral()
@@ -18,14 +26,23 @@ allprojects {
     repositories {
         maven {
             // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
-            url("${rootDir}/../../node_modules/react-native/android")
+            url({
+                def searchDir = rootDir.toPath()
+                do {
+                    def p = searchDir.resolve("node_modules/react-native/android")
+                    if (p.toFile().exists()) {
+                        return p.toRealPath().toString()
+                    }
+                } while (searchDir = searchDir.getParent())
+                throw new GradleException("Could not find `react-native`");
+            }())
         }
+        maven {
+             // All of Detox' artifacts are provided via the npm module
+             url "$rootDir/../../node_modules/detox/Detox-android"
+         }
         mavenCentral()
         google()
-        maven {
-            // All of Detox' artifacts are provided via the npm module
-            url "$rootDir/../../node_modules/detox/Detox-android"
-        }
     }
     afterEvaluate { project ->
         def androidExtension = project.extensions.findByName('android')

example/android/gradle.properties

@@ -26,20 +26,28 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryEr
 android.useAndroidX=true
 # Automatically convert third-party libraries to use AndroidX
 android.enableJetifier=true
-
-# Version of Flipper to use with React Native. Default value is whatever React
-# Native defaults to. To disable Flipper, set it to `false`.
-FLIPPER_VERSION=false
-
-# Enable Fabric at runtime.
-#USE_FABRIC=1
-
-# Enable new architecture, i.e. Fabric + TurboModule - implies USE_FABRIC=1.
+# Jetifier randomly fails on these libraries
+android.jetifier.ignorelist=hermes-android
+
+# Use this property to specify which architecture you want to build.
+# You can also override it from the CLI using
+# ./gradlew <task> -PreactNativeArchitectures=x86_64
+reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
+
+# Use this property to enable support to the new architecture.
+# This will allow you to use TurboModules and the Fabric render in
+# your application. You should enable this flag either if you want
+# to write custom TurboModules/Fabric components OR use libraries that
+# are providing them.
 # Note that this is incompatible with web debugging.
 #newArchEnabled=true
+#bridgelessEnabled=true
+
+# Uncomment the line below to build React Native from source.
+#react.buildFromSource=true
 
-# Uncomment the line below if building react-native from source
-#ANDROID_NDK_VERSION=21.4.7075529
+# Version of Android NDK to build against.
+#ANDROID_NDK_VERSION=26.1.10909125
 
 # Version of Kotlin to build against.
-#KOTLIN_VERSION=1.7.10
+#KOTLIN_VERSION=1.8.22