Skip to content

Commit 14a794a

Browse files
authored
Merge pull request #24 from Naturalclar/chore/updateDevDependencies
chore: update jest and eslint related packages
2 parents 23b5c89 + 4b74dae commit 14a794a

File tree

5 files changed

+1506
-914
lines changed

5 files changed

+1506
-914
lines changed

.circleci/config.yml

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ aliases:
1919

2020
- &type-check
2121
name: TypeScript Checks
22-
command: yarn test:type-check
22+
command: yarn type-check
2323

2424
- &jest
2525
name: Jest Unit Tests
@@ -35,7 +35,9 @@ orbs:
3535
jobs:
3636
# Set up a Linux environment for downstream jobs
3737
linux-checkout:
38-
executor: rn/linux_js
38+
executor:
39+
name: rn/linux_js
40+
node_version: '10'
3941
steps:
4042
- attach_workspace:
4143
at: .
@@ -46,21 +48,27 @@ jobs:
4648
paths: .
4749

4850
eslint:
49-
executor: rn/linux_js
51+
executor:
52+
name: rn/linux_js
53+
node_version: '10'
5054
steps:
5155
- attach_workspace:
5256
at: .
5357
- run: *eslint
5458

55-
# type-check:
56-
# <<: *linux_defaults
57-
# steps:
58-
# - attach_workspace:
59-
# at: .
60-
# - run: *type-check
59+
type-check:
60+
executor:
61+
name: rn/linux_js
62+
node_version: '10'
63+
steps:
64+
- attach_workspace:
65+
at: .
66+
- run: *type-check
6167

6268
jest:
63-
executor: rn/linux_js
69+
executor:
70+
name: rn/linux_js
71+
node_version: '10'
6472
steps:
6573
- attach_workspace:
6674
at: .
@@ -116,10 +124,9 @@ workflows:
116124
- eslint:
117125
requires:
118126
- linux-checkout
119-
# TODO: uncomment when files are written in typescript
120-
# - type-check:
121-
# requires:
122-
# - linux-checkout
127+
- type-check:
128+
requires:
129+
- linux-checkout
123130
- jest:
124131
requires:
125132
- linux-checkout

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

package.json

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"start:android": "adb shell am start -n com.androidprogressbar/.MainActivity",
1010
"build:android": "cd example/android && ./gradlew clean assembleDebug",
1111
"test": "jest",
12-
"lint": "eslint 'js/**/*.js' && eslint 'example/**/*.js'"
12+
"lint": "eslint 'js/**/*.js' && eslint 'example/**/*.js'",
13+
"type-check":"tsc --noEmit"
1314
},
1415
"homepage": "https://github.com/react-native-community/react-native-progress-bar-android#readme",
1516
"repository": {
@@ -45,14 +46,15 @@
4546
"devDependencies": {
4647
"@babel/core": "^7.4.3",
4748
"@babel/runtime": "^7.4.3",
48-
"@react-native-community/eslint-config": "0.0.5",
49+
"@react-native-community/eslint-config": "0.0.6",
50+
"@react-native-community/eslint-plugin": "^1.0.0",
4951
"@types/react": "^16.9.17",
50-
"babel-jest": "^24.9.0",
52+
"babel-jest": "^25.1.0",
5153
"babel-plugin-module-resolver": "^3.2.0",
52-
"eslint": "^5.16.0",
54+
"eslint": "5",
5355
"eslint-plugin-prettier": "^3.0.1",
54-
"jest": "^24.9.0",
55-
"metro-react-native-babel-preset": "^0.53.1",
56+
"jest": "^25.1.0",
57+
"metro-react-native-babel-preset": "^0.58.0",
5658
"prettier": "^1.17.0",
5759
"react": "16.9.0",
5860
"react-native": "^0.61.5",

tsconfig.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"compilerOptions": {
3+
"target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
4+
"module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
5+
"lib": ["es6"],
6+
"jsx": "react" /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */,
7+
/* Strict Type-Checking Options */
8+
"strict": true /* Enable all strict type-checking options. */,
9+
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
10+
}
11+
}

0 commit comments

Comments
 (0)