moved displayIncomingCall callback moved to addEventListener.

Author: aarkalyk

README.md

@@ -137,7 +137,6 @@ Initialise RNCallKit with options
 - **hasVideo**: boolean (optional)
   - false (default)
 - **localizedCallerName**: string (optional)
-- **callback**: (error?: string) => void (optional)
 
 Call when you receive incoming calls to display system UI
 

index.js

@@ -42,7 +42,13 @@ export default class RNCallKit {
                 RNCallKitDidActivateAudioSession,
                 () => { handler(); }
             );
+        } else if (type === 'didDisplayIncomingCall') {
+            listener = _RNCallKitEmitter.addListener(
+                RNCallKitDidDisplayIncomingCall,
+                (data) => { handler(data.error); }
+            );
         }
+
         _callkitEventHandlers.set(handler, listener);
     }
 
@@ -67,16 +73,8 @@ export default class RNCallKit {
         _RNCallKit.setup(options);
     }
 
-    static displayIncomingCall(uuid, handle, handleType = 'number', hasVideo = false, localizedCallerName?: String, callback) {
+    static displayIncomingCall(uuid, handle, handleType = 'number', hasVideo = false, localizedCallerName?: String) {
         if (Platform.OS !== 'ios') return;
-        if (callback) {
-          _callkitEventHandlers.set(
-            callback,
-            _RNCallKitEmitter.addListener(
-              RNCallKitDidDisplayIncomingCall,
-              (data) => { callback(data.error); }
-          ));
-        }
         _RNCallKit.displayIncomingCall(uuid, handle, handleType, hasVideo, localizedCallerName);
     }
 

ios/RNCallKit/RNCallKit.m

@@ -106,7 +106,6 @@ - (void)dealloc
     callUpdate.localizedCallerName = localizedCallerName;
 
     [self.callKitProvider reportNewIncomingCallWithUUID:uuid update:callUpdate completion:^(NSError * _Nullable error) {
-        // Invoking the displayIncomingCall callback
         [self sendEventWithName:RNCallKitDidDisplayIncomingCall body:@{ @"error": error ? error.localizedDescription : @"" }];
         if (error == nil) {
             // Workaround per https://forums.developer.apple.com/message/169511