Merge remote-tracking branch 'upstream/master'

Author: Kyle Kurz

README.md

@@ -51,7 +51,7 @@ const options = {
   }
 };
 
-RNCallKeep.setup(options);
+RNCallKeep.setup(options).then(accepted => {});
 ```
 
 - `options`: Object
@@ -85,6 +85,27 @@ RNCallKeep.setup(options);
       Any additional permissions you'd like your app to have at first launch. Can be used to simplify permission flows and avoid
       multiple popups to the user at different times.
 
+## Constants
+
+To make passing the right integer into methods easier, there are constants that are exported from the module.
+
+```
+const CONSTANTS = {
+  END_CALL_REASONS: {
+    FAILED: 1,
+    REMOTE_ENDED: 2,
+    UNANSWERED: 3,
+    ANSWERED_ELSEWHERE: 4,
+    DECLINED_ELSEWHERE: 5,
+    MISSED: 6
+  }
+};
+
+const { CONSTANTS as CK_CONSTANTS, RNCallKeep } from 'react-native-callkeep';
+
+console.log(CK_CONSTANTS.END_CALL_REASONS.FAILED) // outputs 1
+```
+
 ## Methods
 
 ### setAvailable
@@ -238,14 +259,14 @@ RNCallKeep.reportEndCallWithUUID(uuid, reason);
     - Call failed: 1
     - Remote user ended call: 2
     - Remote user did not answer: 3
-  - `CXCallEndedReason` constants used for iOS. `DisconnectCause` used for Android.
-  - Example enum for reasons
+    - Call Answered elsewhere: 4
+    - Call declined elsewhere: 5 (on Android this will map to Remote user ended call if you use the constants)
+    - Missed: 6 (on iOS this will map to remote user ended call)
+  - Access reasons as constants
   ```js
-  END_CALL_REASON = {
-    failed: 1,
-    remoteEnded: 2,
-    unanswered: 3
-  }
+  const { CONSTANTS as CK_CONSTANTS, RNCallKeep } from 'react-native-callkeep';
+
+  RNCallKeep.reportEndCallWithUUID(uuid, CK_CONSTANTS.END_CALL_REASONS.FAILED);
   ```
 
 ### setMutedCall
@@ -420,14 +441,28 @@ RNCallKeep.addEventListener('didActivateAudioSession', () => {
 Callback for `RNCallKeep.displayIncomingCall`
 
 ```js
-RNCallKeep.addEventListener('didDisplayIncomingCall', ({ error, uuid, handle, localizedCallerName, fromPushKit }) => {
+RNCallKeep.addEventListener('didDisplayIncomingCall', ({ error, callUUID, handle, localizedCallerName, hasVideo, fromPushKit, payload }) => {
   // you might want to do following things when receiving this event:
   // - Start playing ringback if it is an outgoing call
 });
 ```
 
 - `error` (string)
   - iOS only.
+- `callUUID` (string)
+  - The UUID of the call.
+- `handle` (string)
+  - Phone number of the caller
+- `localizedCallerName` (string)
+  - Name of the caller to be displayed on the native UI
+- `hasVideo` (string)
+  - `1` (video enabled)
+  - `0` (video not enabled)
+- `fromPushKit` (string)
+  - `1` (call triggered from PushKit)
+  - `0` (call not triggered from PushKit)
+- `didDisplayIncomingCall` (object)
+  - VOIP push payload.
 
 ### - didPerformSetMutedCallAction
 
@@ -471,7 +506,7 @@ RNCallKeep.addEventListener('didPerformDTMFAction', ({ digits, callUUID }) => {
   - The digits that emit the dtmf tone
 - `callUUID` (string)
   - The UUID of the call.
-  
+
 ### - checkReachability
 
 On Android when the application is in background, after a certain delay the OS will close every connection with informing about it.
@@ -611,7 +646,7 @@ class RNCallKeepExample extends React.Component {
 ## Receiving a call when the application is not reachable.
 
 In some case your application can be unreachable :
-- when the user kill the application 
+- when the user kill the application
 - when it's in background since a long time (eg: after ~5mn the os will kill all connections).
 
 To be able to wake up your application to display the incoming call, you can use [https://github.com/ianlin/react-native-voip-push-notification](react-native-voip-push-notification) on iOS or BackgroundMessaging from [react-native-firebase](https://rnfirebase.io/docs/v5.x.x/messaging/receiving-messages#4)-(Optional)(Android-only)-Listen-for-FCM-messages-in-the-background).
@@ -626,13 +661,14 @@ Since iOS 13, you'll have to report the incoming calls that wakes up your applic
 - (void)pushRegistry:(PKPushRegistry *)registry didReceiveIncomingPushWithPayload:(PKPushPayload *)payload forType:(PKPushType)type withCompletionHandler:(void (^)(void))completion {
   // Process the received push
   [RNVoipPushNotificationManager didReceiveIncomingPushWithPayload:payload forType:(NSString *)type];
-  
+
   // Retrieve information like handle and callerName here
   // NSString *uuid = /* fetch for payload or ... */ [[[NSUUID UUID] UUIDString] lowercaseString];
   // NSString *callerName = @"caller name here";
   // NSString *handle = @"caller number here";
-  
-  [RNCallKeep reportNewIncomingCall:uuid handle:handle handleType:@"generic" hasVideo:false localizedCallerName:callerName fromPushKit: YES];
+  // NSDictionary *extra = [payload.dictionaryPayload valueForKeyPath:@"custom.path.to.data"]; /* use this to pass any special data (ie. from your notification) down to RN. Can also be `nil` */
+
+  [RNCallKeep reportNewIncomingCall:uuid handle:handle handleType:@"generic" hasVideo:false localizedCallerName:callerName fromPushKit: YES payload:extra];
 
   completion();
 }
@@ -646,6 +682,9 @@ Since iOS 13, you'll have to report the incoming calls that wakes up your applic
 adb logcat *:S RNCallKeepModule:V
 ```
 
+## Troubleshooting
+- Ensure that you construct a valid `uuid` by importing the `uuid` library and running `uuid.v4()` as shown in the examples. If you don't do this and use a custom string, the incoming call screen will never be shown on iOS.
+
 ## Contributing
 
 Any pull request, issue report and suggestion are highly welcome!

RNCallKeep.podspec

@@ -13,6 +13,6 @@ Pod::Spec.new do |s|
   s.requires_arc        = true
   s.platform            = :ios, "8.0"
   s.source_files        = "ios/RNCallKeep/*.{h,m}"
-  s.dependency 'React/Core'
+  s.dependency 'React'
 end
 

android/src/main/java/io/wazo/callkeep/RNCallKeepModule.java

@@ -478,7 +478,7 @@ private Boolean hasPermissions() {
     }
 
     private static boolean hasPhoneAccount() {
-        return isConnectionServiceAvailable() && telecomManager.getPhoneAccount(handle).isEnabled();
+        return isConnectionServiceAvailable() && telecomManager != null && telecomManager.getPhoneAccount(handle).isEnabled();
     }
 
     private void registerReceiver() {

android/src/main/java/io/wazo/callkeep/VoiceConnection.java

@@ -100,7 +100,7 @@ public void onAnswer() {
         setAudioModeIsVoip(true);
 
         sendCallRequestToActivity(ACTION_ANSWER_CALL, handle);
-        sendCallRequestToActivity(ACTION_AUDIO_SESSION, null);
+        sendCallRequestToActivity(ACTION_AUDIO_SESSION, handle);
         Log.d(TAG, "onAnswer executed");
     }
 
@@ -135,11 +135,18 @@ public void reportDisconnect(int reason) {
                 setDisconnected(new DisconnectCause(DisconnectCause.ERROR));
                 break;
             case 2:
+            case 5:
                 setDisconnected(new DisconnectCause(DisconnectCause.REMOTE));
                 break;
             case 3:
                 setDisconnected(new DisconnectCause(DisconnectCause.BUSY));
                 break;
+            case 4:
+                setDisconnected(new DisconnectCause(DisconnectCause.ANSWERED_ELSEWHERE));
+                break;
+            case 6:
+                setDisconnected(new DisconnectCause(DisconnectCause.MISSED));
+                break;
             default:
                 break;
         }

android/src/main/java/io/wazo/callkeep/VoiceConnectionService.java

@@ -188,7 +188,7 @@ private Connection makeOutgoingCall(ConnectionRequest request, String uuid, Bool
         HashMap<String, String> extrasMap = this.bundleToMap(extras);
 
         sendCallRequestToActivity(ACTION_ONGOING_CALL, extrasMap);
-        sendCallRequestToActivity(ACTION_AUDIO_SESSION, null);
+        sendCallRequestToActivity(ACTION_AUDIO_SESSION, extrasMap);
 
         Log.d(TAG, "onCreateOutgoingConnection: calling");
 

example/package.json

@@ -11,7 +11,7 @@
     "react-dom": "^16.8.6",
     "react-native": "0.59.8",
     "react-native-background-timer": "^2.1.1",
-    "react-native-callkeep": "https://github.com/react-native-webrtc/react-native-callkeep#fix_outgoing_call_ios",
+    "react-native-callkeep": "3.0.7",
     "react-native-device-info": "^2.3.2",
     "react-native-gesture-handler": "~1.3.0",
     "react-native-reanimated": "~1.1.0",

example/yarn.lock

@@ -4132,9 +4132,10 @@ react-native-branch@~3.0.1:
   resolved "https://registry.yarnpkg.com/react-native-branch/-/react-native-branch-3.0.1.tgz#5b07b61cbd290168cd3c3662e017ebe0f356d2ca"
   integrity sha512-vbcYxPZlpF5f39GAEUF8kuGQqCNeD3E6zEdvtOq8oCGZunHXlWlKgAS6dgBKCvsHvXgHuMtpvs39VgOp8DaKig==
 
-"react-native-callkeep@https://github.com/react-native-webrtc/react-native-callkeep#fix_outgoing_call_ios":
-  version "3.0.1"
-  resolved "https://github.com/react-native-webrtc/react-native-callkeep#22a3f2d9f8ede5e83f88d9a16c3786efe249ce1f"
+[email protected]:
+  version "3.0.7"
+  resolved "https://registry.yarnpkg.com/react-native-callkeep/-/react-native-callkeep-3.0.7.tgz#3e9afbfaaf795e74d2b92750d14f144792278467"
+  integrity sha512-T0BiCmE2/egDCc4tlVjna5YpQ/4YdUH4uv8e3WlCcM80SpUyKLY6cPwbLXTXhBgF08l260oVUFSNfQX6snUQbg==
 
 react-native-device-info@^2.3.2:
   version "2.3.2"

index.d.ts

@@ -1,4 +1,4 @@
-export type Events = 
+export type Events =
   'didReceiveStartCallAction' |
   'answerCall' |
   'endCall' |
@@ -17,9 +17,9 @@ interface IOptions {
   ios: {
     appName: string,
     imageName?: string,
-    supportsVideo: false,
-    maximumCallGroups: '1',
-    maximumCallsPerCallGroup: '1'
+    supportsVideo?: boolean,
+    maximumCallGroups?: string,
+    maximumCallsPerCallGroup?: string,
     ringtoneSound?: string,
   },
   android: {

index.js

@@ -6,6 +6,18 @@ const RNCallKeepModule = NativeModules.RNCallKeep;
 const isIOS = Platform.OS === 'ios';
 const supportConnectionService = !isIOS && Platform.Version >= 23;
 
+const CONSTANTS = {
+  END_CALL_REASONS: {
+    FAILED: 1,
+    REMOTE_ENDED: 2,
+    UNANSWERED: 3,
+    ANSWERED_ELSEWHERE: 4,
+    DECLINED_ELSEWHERE: isIOS ? 5 : 2, // make declined elsewhere link to "Remote ended" on android because that's kinda true
+    MISSED: isIOS ? 2 : 6  }
+};
+
+export { CONSTANTS };
+
 class RNCallKeep {
 
   constructor() {
@@ -175,7 +187,10 @@ class RNCallKeep {
 
     if (shouldOpenAccounts) {
       RNCallKeepModule.openPhoneAccounts();
+      return true;
     }
+
+    return false;
   };
 
   _hasDefaultPhoneAccount = async (options) => {

ios/RNCallKeep/RNCallKeep.h

@@ -32,5 +32,9 @@ continueUserActivity:(NSUserActivity *)userActivity
                    handleType:(NSString *)handleType
                      hasVideo:(BOOL)hasVideo
           localizedCallerName:(NSString * _Nullable)localizedCallerName
-                  fromPushKit:(BOOL)fromPushKit;
-@end
+                  fromPushKit:(BOOL)fromPushKit
+                      payload:(NSDictionary * _Nullable)payload;
+
++ (void)endCallWithUUID:(NSString *)uuidString
+                 reason:(int)reason;
+@end