Skip to content

Commit 3817bfd

Browse files
authored
Merge pull request #11 from mikehardy/null-safe-sim-operator
Safely access getSimOperator in case of empty string
2 parents 54f2ecd + 0e05a0f commit 3817bfd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

android/src/main/java/com/ianlin/RNCarrierInfo/RNCarrierInfoModule.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public String getName() {
3030
@ReactMethod
3131
public void carrierName(Promise promise) {
3232
String carrierName = mTelephonyManager.getSimOperatorName();
33-
if (carrierName != null) {
33+
if (carrierName != null && !"".equals(carrierName)) {
3434
promise.resolve(carrierName);
3535
} else {
3636
promise.reject(E_NO_CARRIER_NAME, "No carrier name");
@@ -40,7 +40,7 @@ public void carrierName(Promise promise) {
4040
@ReactMethod
4141
public void isoCountryCode(Promise promise) {
4242
String iso = mTelephonyManager.getSimCountryIso();
43-
if (iso != null) {
43+
if (iso != null && !"".equals(iso)) {
4444
promise.resolve(iso);
4545
} else {
4646
promise.reject(E_NO_ISO_COUNTRY_CODE, "No iso country code");
@@ -51,7 +51,7 @@ public void isoCountryCode(Promise promise) {
5151
@ReactMethod
5252
public void mobileCountryCode(Promise promise) {
5353
String plmn = mTelephonyManager.getSimOperator();
54-
if (plmn != null) {
54+
if (plmn != null && !"".equals(plmn)) {
5555
promise.resolve(plmn.substring(0, 3));
5656
} else {
5757
promise.reject(E_NO_MOBILE_COUNTRY_CODE, "No mobile country code");
@@ -62,7 +62,7 @@ public void mobileCountryCode(Promise promise) {
6262
@ReactMethod
6363
public void mobileNetworkCode(Promise promise) {
6464
String plmn = mTelephonyManager.getSimOperator();
65-
if (plmn != null) {
65+
if (plmn != null && !"".equals(plmn)) {
6666
promise.resolve(plmn.substring(3));
6767
} else {
6868
promise.reject(E_NO_MOBILE_NETWORK, "No mobile network code");
@@ -73,7 +73,7 @@ public void mobileNetworkCode(Promise promise) {
7373
@ReactMethod
7474
public void mobileNetworkOperator(Promise promise) {
7575
String plmn = mTelephonyManager.getSimOperator();
76-
if (plmn != null) {
76+
if (plmn != null && !"".equals(plmn)) {
7777
promise.resolve(plmn);
7878
} else {
7979
promise.reject(E_NO_NETWORK_OPERATOR, "No mobile network operator");

0 commit comments

Comments
 (0)