Skip to content

Commit e9af5ca

Browse files
jquensetaion
andauthored
Apply suggestions from code review
Co-Authored-By: Jimmy Jia <[email protected]>
1 parent 49e51ec commit e9af5ca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/useCustomEffect.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import useMounted from './useMounted'
1010

1111
export type EffectHook = (effect: EffectCallback, deps?: DependencyList) => void
1212

13-
export type IsEqual<TDeps> = (nextDeps: TDeps, prev: TDeps) => boolean
13+
export type IsEqual<TDeps extends DependencyList> = (nextDeps: TDeps, prevDeps: TDeps) => boolean
1414

1515
export type CustomEffectOptions<TDeps> = {
1616
isEqual: IsEqual<TDeps>
@@ -31,7 +31,7 @@ type CleanUp = {
3131
*/
3232
function useCustomEffect<TDeps extends DependencyList = DependencyList>(
3333
effect: EffectCallback,
34-
dependencies: DependencyList,
34+
dependencies: TDeps,
3535
isEqual: IsEqual<TDeps>,
3636
): void
3737
/**
@@ -45,7 +45,7 @@ function useCustomEffect<TDeps extends DependencyList = DependencyList>(
4545
*/
4646
function useCustomEffect<TDeps extends DependencyList = DependencyList>(
4747
effect: EffectCallback,
48-
dependencies: DependencyList,
48+
dependencies: TDeps,
4949
options: CustomEffectOptions<TDeps>,
5050
): void
5151
function useCustomEffect<TDeps extends DependencyList = DependencyList>(

0 commit comments

Comments
 (0)