Skip to content

Commit decc475

Browse files
committed
address feedback
1 parent 6e8ca42 commit decc475

File tree

6 files changed

+87
-77
lines changed

6 files changed

+87
-77
lines changed

src/index.ts

Lines changed: 43 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,45 @@
1-
import Dropdown from './Dropdown.js';
2-
import { useDropdownMenu } from './DropdownMenu.js';
3-
import { useDropdownToggle } from './DropdownToggle.js';
4-
import { useDropdownItem } from './DropdownItem.js';
5-
import Modal from './Modal.js';
6-
import Overlay from './Overlay.js';
7-
import Portal from './Portal.js';
8-
import useRootClose from './useRootClose.js';
9-
import Nav from './Nav.js';
10-
import NavItem, { useNavItem } from './NavItem.js';
11-
import Button from './Button.js';
12-
import Tabs from './Tabs.js';
13-
import TabPanel from './TabPanel.js';
14-
151
export {
16-
Button,
17-
Dropdown,
18-
useDropdownMenu,
19-
useDropdownToggle,
20-
useDropdownItem,
21-
Nav,
22-
NavItem,
23-
useNavItem,
24-
Modal,
25-
Overlay,
26-
Portal,
27-
useRootClose,
28-
Tabs,
29-
TabPanel,
30-
};
31-
32-
export type { ButtonProps } from './Button.js';
33-
export type {
34-
DropdownProps,
35-
DropdownMenuProps,
36-
UseDropdownMenuMetadata,
37-
UseDropdownMenuOptions,
38-
DropdownToggleProps,
39-
UseDropdownToggleMetadata,
40-
DropdownItemProps,
2+
default as Dropdown,
3+
type DropdownProps,
4+
type DropdownMenuProps,
5+
type UseDropdownMenuMetadata,
6+
type UseDropdownMenuOptions,
7+
type DropdownToggleProps,
8+
type UseDropdownToggleMetadata,
9+
type DropdownItemProps,
4110
} from './Dropdown.js';
42-
export type { NavItemProps, UseNavItemOptions, NavProps } from './Nav.js';
43-
export type { ModalProps } from './Modal.js';
44-
export type { OverlayProps } from './Overlay.js';
45-
export type { PortalProps } from './Portal.js';
46-
export type { TabsProps, TabPanelProps } from './Tabs.js';
11+
export { useDropdownMenu } from './DropdownMenu.js';
12+
export { useDropdownToggle } from './DropdownToggle.js';
13+
export { useDropdownItem } from './DropdownItem.js';
14+
export { default as Modal, type ModalProps } from './Modal.js';
15+
export { default as Overlay, type OverlayProps } from './Overlay.js';
16+
export { default as Portal, type PortalProps } from './Portal.js';
17+
export {
18+
default as useRootClose,
19+
type RootCloseOptions,
20+
} from './useRootClose.js';
21+
export {
22+
default as Nav,
23+
type NavItemProps,
24+
type UseNavItemOptions,
25+
type NavProps,
26+
} from './Nav.js';
27+
export { default as NavItem, useNavItem } from './NavItem.js';
28+
export { default as Button, type ButtonProps } from './Button.js';
29+
export { default as Tabs, type TabsProps, type TabPanelProps } from './Tabs.js';
30+
export { default as TabPanel } from './TabPanel.js';
31+
32+
export {
33+
default as Waypoint,
34+
type WaypointProps,
35+
type WaypointEvent,
36+
} from './Waypoint.js';
37+
export {
38+
default as useWaypoint,
39+
Position,
40+
type WaypointOptions,
41+
} from './useWaypoint.js';
42+
export {
43+
default as useClickOutside,
44+
type ClickOutsideOptions,
45+
} from './useClickOutside.js';

www/docs/Button.mdx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
An abstract button component for creating accessible buttons regardless of the HTML
22
element used to render it.
33

4-
```jsx live className=button-example
4+
```jsx live
55
import { Button } from "@restart/ui";
66

7-
<Button>I'm a Button</Button>;
7+
<div className="button-example">
8+
<Button>I'm a Button</Button>
9+
</div>;
810
```
911
1012
Not very impressive on its own, but `Button` does come with a few conveniences
@@ -14,10 +16,10 @@ over the plain HTML element.
1416
- Ensures that non `button` `as` options remain accessible
1517
- contextually renders an `<a>` if href or other anchor props are added.
1618
17-
```jsx live className=button-example
19+
```jsx live
1820
import { Button } from "@restart/ui";
1921
20-
<div className="space-x-4">
22+
<div className="space-x-4 button-example">
2123
<Button>I'm a Button</Button>
2224
<Button href="/home">I'm a link</Button>
2325
<Button as="span">I'm a span but also a button</Button>
@@ -73,7 +75,7 @@ function StyledButton(props) {
7375
!props.disabled &&
7476
"cursor-pointer hover:bg-primary hover:text-white",
7577
"active:bg-primary-600 active:text-white",
76-
props.disabled && "cursor-not-allowed opacity-60"
78+
props.disabled && "cursor-not-allowed opacity-60",
7779
)}
7880
/>
7981
);

www/docs/Waypoint.mdx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,8 @@ to the `root` prop.
3939

4040
```tsx
4141
function ScrollArea({ items, onPositionChange }) {
42-
const [element, setElement] = useState<HTMLDivElement>(
43-
null
44-
);
42+
const [element, setElement] =
43+
useState<HTMLDivElement>(null);
4544

4645
return (
4746
<div ref={setElement} style={{ overflow: "auto" }}>
@@ -91,9 +90,7 @@ when you want an individual component to respond
9190

9291
```tsx live
9392
import getScrollParent from "dom-helpers/scrollParent";
94-
import useWaypoint, {
95-
Position,
96-
} from "@restart/ui/useWaypoint";
93+
import { useWaypoint, Position } from "@restart/ui";
9794

9895
function LazyImage({ src }) {
9996
const [element, attachRef] = useState(null);
@@ -112,7 +109,7 @@ function LazyImage({ src }) {
112109
root: "scrollParent",
113110
scrollDirection: "horizontal",
114111
rootMargin: { right: -80 },
115-
}
112+
},
116113
);
117114

118115
return (

www/docs/useRootClose.mdx

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,30 @@
22
import { useRootClose } from "@restart/ui";
33
import Button from "../src/Button";
44

5-
const ref = useRef();
6-
const [show, setShow] = useState(false);
7-
const handleRootClose = () => setShow(false);
5+
function RootCloseWrapper() {
6+
const ref = useRef();
7+
const [show, setShow] = useState(false);
8+
const handleRootClose = () => setShow(false);
89

9-
useRootClose(ref, handleRootClose, {
10-
disabled: !show,
11-
});
10+
useRootClose(ref, handleRootClose, {
11+
disabled: !show,
12+
});
1213

13-
return (
14-
<div className="flex flex-col items-center space-y-4">
15-
<Button type="button" onClick={() => setShow(true)}>
16-
Render RootCloseWrapper
17-
</Button>
14+
return (
15+
<div className="flex flex-col items-center space-y-4">
16+
<Button type="button" onClick={() => setShow(true)}>
17+
Render RootCloseWrapper
18+
</Button>
1819

19-
{show && (
20-
<div
21-
ref={ref}
22-
className="rounded shadow bg-white p-6"
23-
>
24-
<span>Click anywhere to dismiss me!</span>
25-
</div>
26-
)}
27-
</div>
28-
);
20+
{show && (
21+
<div
22+
ref={ref}
23+
className="rounded shadow bg-white p-6"
24+
>
25+
<span>Click anywhere to dismiss me!</span>
26+
</div>
27+
)}
28+
</div>
29+
);
30+
}
2931
```

www/src/LiveCodeblock.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ import * as RestartUi from '@restart/ui';
1616
import Button from './Button';
1717
import Dropdown from './Dropdown';
1818
import Tooltip from './Tooltip';
19+
import Transition from 'react-transition-group/Transition';
20+
import scrollParent from 'dom-helpers/scrollParent';
21+
import '../src/css/transitions.css';
1922

2023
// @ts-ignore
2124
import styles from './LiveCodeBlock.module.css';
@@ -31,10 +34,13 @@ const LocalImports = {
3134
react: React,
3235
'react-dom': ReactDOM,
3336
'@restart/ui': RestartUi,
37+
'react-transition-group/Transition': Transition,
38+
'dom-helpers/scrollParent': scrollParent,
3439
clsx,
3540
'../src/Button': Button,
3641
'../src/Dropdown': Dropdown,
3742
'../src/Tooltip': Tooltip,
43+
'../src/css/transitions.css': '',
3844
};
3945

4046
export interface Props

www/src/css/tailwind.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ ul {
5252
--ifm-code-font-size: 95%;
5353
}
5454

55+
svg {
56+
display: initial;
57+
}
58+
5559
@import 'tailwindcss/utilities';
5660

5761
.button-example button {

0 commit comments

Comments
 (0)