Bump undici and discord.js (#474)

* Bump undici and discord.js

Bumps [undici](https://github.com/nodejs/undici) to 6.21.3 and updates ancestor dependency [discord.js](https://github.com/discordjs/discord.js/tree/HEAD/packages/discord.js). These dependencies need to be updated together.


Updates `undici` from 6.19.8 to 6.21.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.19.8...v6.21.3)

Updates `discord.js` from 14.15.3 to 14.21.0
- [Release notes](https://github.com/discordjs/discord.js/releases)
- [Changelog](https://github.com/discordjs/discord.js/blob/14.21.0/packages/discord.js/CHANGELOG.md)
- [Commits](https://github.com/discordjs/discord.js/commits/14.21.0/packages/discord.js)

---
updated-dependencies:
- dependency-name: undici
  dependency-version: 6.21.3
  dependency-type: indirect
- dependency-name: discord.js
  dependency-version: 14.21.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix types

* Fix a last type error

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carl Vitullo <[email protected]>

Author: dependabot[bot]

package-lock.json

@@ -27,7 +27,7 @@
     "@fastify/swagger": "^9.4.0",
     "date-fns": "3.6.0",
     "dedent": "1.5.3",
-    "discord.js": "14.15.3",
+    "discord.js": "14.21.0",
     "dotenv": "16.4.5",
     "fastify": "^5.3.2",
     "gists": "2.0.0",

package.json

@@ -5,6 +5,8 @@ import {
   ChannelType,
   EmbedType,
   Message,
+  OmitPartialGroupDMChannel,
+  PartialGroupDMChannel,
   TextChannel,
 } from "discord.js";
 import cooldown from "./cooldown.js";
@@ -25,7 +27,7 @@ type Command = {
   words: string[];
   help: string;
   category: Categories;
-  handleMessage: (msg: Message) => void;
+  handleMessage: (msg: OmitPartialGroupDMChannel<Message>) => void;
   cooldown?: number;
 };
 
@@ -1349,12 +1351,15 @@ const createCommandsMessage = () => {
 
 const commands: ChannelHandlers = {
   handleMessage: async ({ msg: maybeMessage }) => {
-    if (!maybeMessage.guild && maybeMessage.channel.type !== ChannelType.DM) {
+    if (
+      (!maybeMessage.inGuild() &&
+        maybeMessage.channel.type !== ChannelType.DM) ||
+      maybeMessage.channel instanceof PartialGroupDMChannel
+    ) {
       return;
     }
-    const msg = maybeMessage.partial
-      ? await maybeMessage.fetch()
-      : maybeMessage;
+
+    const msg = await maybeMessage.fetch();
 
     commandsList.forEach((command) => {
       const keyword = command.words.find((word) => {

src/features/commands.ts

@@ -230,6 +230,13 @@ const validationRepl = async (message: Message) => {
   const posts = parseContent(message.content);
   const errors = validate(posts, message);
 
+  if (
+    message.channel.type !== ChannelType.GuildText &&
+    message.channel.type !== ChannelType.PublicThread
+  ) {
+    return;
+  }
+
   await message.channel.send(
     errors.length > 0
       ? errors.map((e) => `- ${getValidationMessage(e)}`).join("\n")

src/features/jobs-moderation.ts

@@ -65,17 +65,18 @@ configure();
 
 export const resumeResources = async (bot: Client) => {
   bot.on("interactionCreate", async (interaction) => {
+    const { channel } = interaction;
     if (
       interaction.type !== InteractionType.MessageComponent ||
       interaction.componentType !== ComponentType.Button ||
-      !interaction.channel ||
-      interaction.channel.type !== ChannelType.PublicThread ||
-      interaction.channel.parentId !== CHANNELS.resumeReview
+      !channel ||
+      channel.type !== ChannelType.PublicThread ||
+      channel.parentId !== CHANNELS.resumeReview
     ) {
       return;
     }
 
-    if (interaction.user.id !== interaction.channel.ownerId) {
+    if (interaction.user.id !== channel.ownerId) {
       interaction.reply({
         ephemeral: true,
         content:
@@ -92,8 +93,7 @@ export const resumeResources = async (bot: Client) => {
     if (interaction.customId === REVIEW_COMMAND) {
       const deferred = await interaction.deferReply({ ephemeral: true });
       deferred.edit("Looking for a resume…");
-      const messages = await interaction.channel.messages.fetch();
-      const channel = interaction.channel;
+      const messages = await channel.messages.fetch();
 
       let firstMessage: Message<true> | null = null;
       try {
@@ -173,7 +173,7 @@ export const resumeResources = async (bot: Client) => {
         );
 
         run.on("textCreated", () => {
-          interaction.channel?.sendTyping();
+          channel?.sendTyping();
         });
 
         run.on("textDone", (content) => {
@@ -189,7 +189,7 @@ export const resumeResources = async (bot: Client) => {
             content: "Done!",
           });
 
-          interaction.channel?.send(content.value);
+          channel?.send(content.value);
         });
       } catch (e) {
         // recover

src/features/resume.ts

@@ -40,6 +40,9 @@ const MESSAGE_SCHEDULE: MessageConfig[] = [
       { interval: FREQUENCY.moreThanWeekly, channelId: CHANNELS.jobBoard },
     ],
     message: async (channel) => {
+      if (channel.type !== ChannelType.GuildText) {
+        return;
+      }
       const msg = await channel.send({
         content: `Messages must start with [FORHIRE]/[HIRING]. Check the channel description for a full list of tags and rules!
 

src/features/scheduled-messages.ts

@@ -138,7 +138,7 @@ const handleMessage = async (message: Message) => {
   if (message.system) {
     return;
   }
-  const msg = message.partial ? await message.fetch() : message;
+  const msg = await message.fetch();
 
   const channel = msg.channel;
   const channelId = channel.isThread()

src/index.ts

@@ -6,14 +6,15 @@ import {
   PartialMessageReaction,
   PartialUser,
   VoiceState,
+  OmitPartialGroupDMChannel,
 } from "discord.js";
 
 type CommonArgs = {
   bot: Client;
 };
 
 export type HandleMessageArgs = CommonArgs & {
-  msg: Message;
+  msg: OmitPartialGroupDMChannel<Message>;
 };
 
 export type HandleReactionArgs = CommonArgs & {