refactor: better place for getGit

Signed-off-by: Brian Nguyen <[email protected]>

Author: vanpho93

commands/create-project-api.js

@@ -9,20 +9,6 @@ import Logger from "../utils/logger.js";
 
 const reactionRepoRoot = "https://raw.githubusercontent.com/reactioncommerce/reaction/trunk";
 
-/**
- * @summary create the git instance
- * @param {String} projectName - The name of the directory to create
- * @returns {Object} - the git instance
- */
-function getGitInstance(projectName) {
-  const gitOptions = {
-    baseDir: `${process.cwd()}/${projectName}`,
-    binary: "git",
-    maxConcurrentProcesses: 6
-  };
-  return simpleGit(gitOptions);
-}
-
 /**
  * @summary create project directory
  * @param {String} projectName - The name of the directory to create
@@ -130,16 +116,28 @@ async function getFilesFromCore(projectName, options) {
   return true;
 }
 
+/**
+ * @summary create the git instance
+ * @param {String} projectName - The name of the directory to create
+ * @returns {Object} - the git instance
+ */
+function getGit(projectName) {
+  const gitOptions = {
+    baseDir: `${process.cwd()}/${projectName}`,
+    binary: "git",
+    maxConcurrentProcesses: 6
+  };
+  return simpleGit(gitOptions);
+}
 
 /**
  * @summary git init the newly created project
  * @param {String} projectName - The project to init
  * @returns {Promise<Boolean>} true if success
  */
 async function gitInitDirectory(projectName) {
-  const git = getGitInstance(projectName);
   try {
-    await git.init();
+    await getGit(projectName).init();
   } catch (error) {
     Logger.error(error);
   }
@@ -152,9 +150,8 @@ async function gitInitDirectory(projectName) {
  * @returns {Promise<boolean>} true for success
  */
 async function addSampleDataPlugin(projectName) {
-  const git = getGitInstance(projectName);
   try {
-    await git.clone("[email protected]:reactioncommerce/api-plugin-sample-data.git", "custom-packages/api-plugin-sample-data");
+    await getGit(projectName).clone("[email protected]:reactioncommerce/api-plugin-sample-data.git", "./custom-packages/api-plugin-sample-data");
 
     const pluginJsonPath = `${projectName}/plugins.json`;
     const plugins = JSON.parse(await readFile(pluginJsonPath));