Skip to content

Commit 2d00dfb

Browse files
[FEATURE] Additional minor improvements before merging new tool (- WIP #155 -)
Changes in file .github/workflows/CI-CHGLOG.yml: * Oops, almost missed an ID refactor Changes in file generate_changelog.sh: * style improvements
1 parent 8433056 commit 2d00dfb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/CI-CHGLOG.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ jobs:
231231
CHGLOG_ARTIFACT_NAME: ${{ needs.CHGLOG.outputs.artifact-name }}
232232
CHGLOG_ARTIFACT_URL: ${{ needs.CHGLOG.outputs.artifact-url }}
233233
run: |
234-
if [[ "${{ needs.chglog.outputs.chglog_status }}" == "success" ]]; then
234+
if [[ "${{ needs.CHGLOG.outputs.chglog_status }}" == "success" ]]; then
235235
printf "%s\n\n" "# :page_facing_up: Changelog Summary" > "${CHGLOG_COMMENT_BODY}"
236236
printf "%s\n" " * :ballot_box_with_check: Generating Changelog \`${CHGLOG_ID}\` succeeded with commit [${BUILD_SHA}](https://github.com/reactive-firewall/multicast/commit/${BUILD_SHA})" >> "${CHGLOG_COMMENT_BODY}"
237237
printf "%s\n" "chglog_success=true" >> "$GITHUB_OUTPUT"
@@ -319,7 +319,7 @@ jobs:
319319
else
320320
printf "%s\n" "build_success=false" >> "$GITHUB_OUTPUT"
321321
fi
322-
if [[ "${{ needs.chglog.result }}" == "success" && "${{ needs.check_build.result }}" == "success" ]]; then
322+
if [[ "${{ needs.CHGLOG.result }}" == "success" && "${{ needs.check_build.result }}" == "success" ]]; then
323323
printf "%s\n" "chglog_success=true" >> "$GITHUB_OUTPUT"
324324
printf "%s\n" "chglog_url=${{ github.api_url }}" >> "$GITHUB_OUTPUT"
325325
printf "%s\n" "chglog_ref=${{ needs.check_build.outputs.build_ref }}" >> "$GITHUB_OUTPUT"

generate_changelog.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ git log "${GIT_RANGE}" --reverse --pretty=format:"COMMIT_START%n%h%n%B%nCOMMIT_E
263263
RAW_FLAGS_LIST=$(grep -oE "([\[][A-Z]+[]]){1}" "${CHANGELOG_BUFFER}" | sort -id | uniq -c | sort -rid | grep -oE "([A-Z]+){1}" | sort -id | uniq | sort -rd ; wait ;)
264264

265265
RAW_IMPACTED_ISSUES=$(grep -oE "([#]\d+){1}\b" "${CHANGELOG_BUFFER}" | sort -iV | uniq | sort -V | xargs -L1 -I{} printf "%s, " "{}" ; wait ;)
266-
RAW_FLAGS_USED=$(cat <(printf "%s\n" "${RAW_FLAGS_LIST}") | xargs -L1 -I{} printf "%s, " "{}" ; wait ;)
266+
RAW_FLAGS_USED=$(printf "%s\n" "${RAW_FLAGS_LIST}" | xargs -L1 -I{} printf "%s, " "{}" ; wait ;)
267267
RAW_NEW_FILES=$(grep -F "Additions with file" "${CHANGELOG_BUFFER}" | sort -id | cut -d\ -f4- | sort -id | uniq -c | tr -s ' ' ' ' | cut -d\ -f 3- | cut -d: -f 1-1 | xargs -L1 -I{} printf "%s, " "{}" ; wait ;)
268268
RAW_DEL_FILES=$(grep -F "Deletions from file" "${CHANGELOG_BUFFER}" | sort -id | cut -d\ -f4- | sort -id | uniq -c | tr -s ' ' ' ' | cut -d\ -f 3- | cut -d: -f 1-1 | xargs -L1 -I{} printf "%s, " "{}" ; wait ;)
269269

0 commit comments

Comments
 (0)