[PATCH] Applied changes from review (- WIP PR #348 -)

Changes in file multicast/env.py:
 * minor tweaks and related work

Changes in file multicast/recv.py:
 * RECV implementation now honors new environment variable for muticast message buffering (- WIP #264 -)
 * related work

Changes in file multicast/send.py:
 * SEND implementation now honors new environment variable for muticast message buffering (- WIP #264 -)
 * related work

Author: reactive-firewall

multicast/env.py

@@ -862,7 +862,7 @@ def load_config() -> dict:
 	ttl = load_TTL()
 	buffer_size = load_buffer_size()
 	groups_str = os.getenv("MULTICAST_GROUPS", "")
-	bind_addr = os.getenv("MULTICAST_BIND_ADDR", group)  # skipcq: PYL-W1508
+	bind_addr = os.getenv("MULTICAST_BIND_ADDR", str(group))  # skipcq: PYL-W1508
 	# Process and validate groups
 	groups = set()
 	if groups_str:

multicast/recv.py

@@ -310,12 +310,17 @@ def tryrecv(msgbuffer, chunk, sock):
 
 	Will try to listen on the given socket directly into the given chunk for decoding.
 	If the read into the chunk results in content, the chunk will be decoded and appended
-	to the caller-instantiated `msgbuffer`, which is a collection of strings (or None).
+	to the caller-instantiated `msgbuffer`, which is a collection of utf8 strings (or None).
 	After decoding, `chunk` is zeroed for memory efficiency and security. Either way the
 	message buffer will be returned.
 
 	Tries to receive data without blocking and appends it to the message buffer.
 
+	Individual chunk sizes are controled by the module attribute `_MCAST_DEFAULT_BUFFER_SIZE` set
+	at module's load-time. It is possible to override the buffer size via the environment variable
+	"MULTICAST_BUFFER_SIZE" if available at load-time. However changing the value is not reccomended
+	unless absolutly needed, and can be done on the sender side too.
+
 	Args:
 		msgbuffer (list or None): Caller-instantiated collection to store received messages.
 		chunk (variable or None): Caller-instantiated variable for raw received data.
@@ -381,7 +386,7 @@ def tryrecv(msgbuffer, chunk, sock):
 			>>>
 
 	"""
-	chunk = sock.recv(1316)
+	chunk = sock.recv(multicast._MCAST_DEFAULT_BUFFER_SIZE)
 	if not (chunk is None):  # pragma: no branch
 		msgbuffer += str(chunk, encoding='utf8')  # pragma: no cover
 		chunk = None  # pragma: no cover

multicast/send.py

@@ -354,7 +354,8 @@ def doStep(self, *args, **kwargs):
 			# Read from stdin in chunks
 			while True:
 				try:
-					chunk = sys.stdin.read(1316)  # Read 1316 bytes at a time - matches read size
+					# Read configured amount of bytes at a time - matches read size by default
+					chunk = sys.stdin.read(multicast._MCAST_DEFAULT_BUFFER_SIZE)
 				except IOError as e:
 					print(f"Error reading from stdin: {e}", file=sys.stderr)
 					break