[PATCH] Implements the improvements from #198

Changes in file tests/check_pip:
 * Fixed cleanup for venv
 * improved check_license_when_given_req

Author: reactive-firewall

tests/check_pip

@@ -102,6 +102,11 @@ umask 137
 export LC_CTYPE="${LC_CTYPE:-en_US.UTF-8}"
 # set remaining variables
 LOCK_FILE="${TMPDIR:-/tmp}/org.pak.multicast.pip-check-shell"
+# Global variable to track temporary directories
+TEMP_DIRS=""
+# Global variable to track initial directories
+readonly PRE_OLDPWD="${OLDPWD:-${PWD:-$(pwd)}}"
+readonly PRE_PWD="${PWD:-$(pwd)}"
 
 # Function to check if a command exists.
 
@@ -153,8 +158,19 @@ EXIT_CODE=1
 # Results:
 #	returns -- once cleanup has been done on a best-effort case.
 function cleanup() {
+	for dir in ${TEMP_DIRS}; do
+		if [[ ( -n "${dir}" ) ]] && [[ ( -d "${dir}" ) ]]; then
+			rm -rfd "${dir}" 2>/dev/null || : ;
+		fi
+	done
 	rm -f "${LOCK_FILE}" 2>/dev/null || : ; wait ;
+	# best effort to restore starting location
+	cd "${PRE_PWD}" && cd "${PRE_OLDPWD}" 2>/dev/null || : ;
+	cd "${PRE_PWD}" 2>/dev/null || : ;
 	# unset when done
+	unset TEMP_DIRS 2>/dev/null || : ;
+	unset PRE_OLDPWD 2>/dev/null || : ;
+	unset PRE_PWD 2>/dev/null || : ;
 	unset LOCK_FILE 2>/dev/null || : ;
 	hash -d shlock 2>/dev/null || : ;
 }
@@ -172,7 +188,7 @@ function handle_signals() {
 		trap 'cleanup 2>/dev/null || rm -f ${LOCK_FILE} 2>/dev/null || true ; wait ; exit ${EXIT_CODE} ;' EXIT || EXIT_CODE=1
 	else
 		# shellcheck disable=SC2046
-		printf "\t%s\n" "Check Setup Scripts Tests Coverage already in progress by "$(head "${LOCK_FILE}") >&2 ;
+		printf "\t%s\n" "Check PIP Configuration Tests already in progress by "$(head "${LOCK_FILE}") >&2 ;
 		exit 126 ;
 	fi
 }
@@ -241,8 +257,8 @@ function check_license_when_given_req() {
 	umask 007
 	printf "::debug::%s\n" "need venv ..." ;
 	# Create a temporary directory for the virtual environment
-	temp_dir=$(mktemp -d)
-
+	local temp_dir=$(mktemp -d)
+	TEMP_DIRS="${TEMP_DIRS} ${temp_dir}" ;
 	# Enter the temporary directory
 	cd "${temp_dir}"