Skip to content

Commit 696274f

Browse files
[MERGE] Close PR #339
- [x] Closes #210 --- <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **New Features** - Introduced an automated pip upgrade mechanism for Windows that helps ensure compatibility and reliability on Windows systems. - **Chores** - Streamlined continuous integration workflows by replacing manual pip upgrade commands with a reusable action, enhancing maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- Additions with file .github/actions/upgrade-windows-pip/action.yml: * implements a DRY action for windows hosts to upgrade pip (- Resolves #210 -) Changes in file .github/workflows/CI-DOCS.yml: * use the new DRY action. Changes in file .github/workflows/Tests.yml: * use the new DRY action.
2 parents f099ec5 + 6cbb682 commit 696274f

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
name: 'Upgrade Windows Pip'
3+
description: 'Fixes Windows pip issues by upgrading'
4+
author: 'Mr. Walls'
5+
branding:
6+
icon: 'chevron-up'
7+
color: 'yellow'
8+
9+
runs:
10+
using: composite
11+
steps:
12+
- run: python -m pip install --upgrade pip
13+
shell: bash
14+
if: ${{ !cancelled() && runner.os == 'Windows' }}

.github/workflows/CI-DOCS.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ jobs:
5252
with:
5353
python-version: ${{ matrix.python-version }}
5454
- name: Fix braindead windows ${{ matrix.python-version }} on ${{ matrix.os }}
55-
if: ${{ !cancelled() && runner.os == 'Windows' }}
56-
run: python -m pip install --upgrade pip
55+
uses: ./.github/actions/upgrade-windows-pip
5756
- name: Install dependencies for python ${{ matrix.python-version }} on ${{ matrix.os }}
5857
run: |
5958
pip install --upgrade "pip>=24.3.1" "setuptools>=75.0" "wheel>=0.44" "build>=1.2.1";

.github/workflows/Tests.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ jobs:
9191
with:
9292
python-version: ${{ matrix.python-version }}
9393
- name: Fix braindead windows ${{ matrix.python-version }} on ${{ matrix.os }}
94-
if: ${{ !cancelled() && runner.os == 'Windows' }}
95-
run: python -m pip install --upgrade pip
94+
uses: ./.github/actions/upgrade-windows-pip
9695
- name: Install dependencies for python ${{ matrix.python-version }} on ${{ matrix.os }}
9796
run: make -f Makefile test-reqs || true
9897
- name: Install code-climate tools for ${{ matrix.python-version }} on ${{ matrix.os }}

0 commit comments

Comments
 (0)