@@ -10,7 +10,7 @@ reviews:
1010
1111 - Ensure the code follows best practices and coding standards.
1212 - Check for security vulnerabilities and potential issues.
13- - Ensure the code follows the **DRY, AHA , and SOLID** principles.
13+ - Ensure the code follows the **DRY, Avoid-Hasty-Abstractions , and SOLID** design principles.
1414 - Our "Code Review Checklist Guide" is documented in
1515 [CEP-4](https://gist.github.com/reactive-firewall/cc041f10aad1d43a5ef15f50a6bbd5a5),
1616 be sure to always consider
@@ -35,7 +35,7 @@ reviews:
3535 - Verify that technical documentation includes a "References" section at
3636 the end of documentation, using the same format as actual RFCs, with
3737 both "Normative References" and "Informative References". Suggest improvements if unable.
38- - Ensure that that project documentation and comments follow
38+ - Ensure that the project documentation and source-code comments follow
3939 [CEP-7](https://gist.github.com/reactive-firewall/123b8a45f1bdeb064079e0524a29ec20)
4040
4141 # Test Code Review Instructions
@@ -44,7 +44,7 @@ reviews:
4444 - Verify that minimal acceptance tests (e.g., those run by the workflow CI-MATs) are passing and
4545 error free, pointing out any failure as below minimal acceptance (i.e. un-acceptable).
4646 - Ensure that the test coverage meets or exceeds the project's required threshold
47- (e.g., aiming for 100% coverage as per Issue #53).
47+ (e.g., aiming for 100% coverage as per GitHub Issue #53).
4848 - For **test** code, *also* follow
4949 [CEP-9](https://gist.github.com/reactive-firewall/d840ee9990e65f302ce2a8d78ebe73f6)
5050
@@ -57,6 +57,8 @@ reviews:
5757 not assume a dependency is optional, confirm if it is or is not optional.
5858 - For **Python** code, consider [PEP 290](https://peps.python.org/pep-0290/) whenever a python
5959 (e.g., has the extension '.py') file is changed.
60+ - Our project's "AI Usage Policy" is documented in
61+ [.github/AI_USAGE_POLICY.md](https://github.com/reactive-firewall-org/multicast/tree/master/.github/AI_USAGE_POLICY.md).
6062 request_changes_workflow : true
6163 high_level_summary : true
6264 high_level_summary_placeholder : ' @coderabbitai summary'
@@ -77,17 +79,27 @@ reviews:
7779 instructions : >-
7880 Apply when the PR/MR contains changes to the file `Makefile` or makefile
7981 code snippets.
80- - label : Documentation
82+ - label : documentation
8183 instructions : >-
8284 Apply whenever project documentation (namely markdown source-code) is
8385 updated by the PR/MR. Also apply when PR contains a commit with a commit
8486 message prefixed with "[DOCUMENTATION] "
87+ - label : CI
88+ instructions : >-
89+ Apply whenever any project CI/CD components (namely GitHub Action source-code) are
90+ updated by the PR/MR. Also apply when PR contains a commit with a commit
91+ message prefixed with "[CI] "
8592 - label : Linter
8693 instructions : >-
8794 Apply when the purpose of the PR/MR is related to fixing the feedback
8895 from a linter. Also apply if suggested fixes are used and improve the
89- code's compliance with the PEP-8 standard.
90- path_filters : ['!*.xc*/**', '!node_modules/**', '!dist/**', '!build/**', '!.git/**', '!venv/**', '!__pycache__/**']
96+ code's compliance with project conventions or adopted standards.
97+ - label : Testing
98+ instructions : >-
99+ Apply when the purpose of the PR/MR is related to fixing/improving any
100+ testing components or test-code. Also apply if suggested fixes are
101+ used and improve the project's test-code.
102+ path_filters : ['!*.xc*/**', '!node_modules/**', '!dist/**', '!package.json', '!package-lock.json', '!yarn.lock', '!build/**', '!.git/**', '!venv/**', '!__pycache__/**']
91103 path_instructions :
92104 - path : README.md
93105 instructions : >-
@@ -120,7 +132,7 @@ reviews:
120132 the guidelines set by
121133 [CEP-7](https://gist.github.com/reactive-firewall/123b8a45f1bdeb064079e0524a29ec20).
122134 6. Verify Flake8's configuration file is located at ".flake8.ini". Flake8 is run
123- automaticly by the `flake8-cq` GHA used by the `.github/workflows/flake8.yml` workflow.
135+ automatically by the `flake8-cq` GHA used by the `.github/workflows/flake8.yml` workflow.
124136 7. Verify alignment of any new changes, with the code style advocated in
125137 [CEP-8](https://gist.github.com/reactive-firewall/b7ee98df9e636a51806e62ef9c4ab161),
126138 pointing out any introduced deviations.
@@ -167,8 +179,8 @@ reviews:
167179 4. Consider these 'requirements.txt' files the records of truth regarding project
168180 dependencies.
169181 5. Consider the 'requirements.txt' file in the base of the git repository
170- (e.g., './requirements.txt') the required python dependencies regarding Multicast project
171- dependencies.
182+ (e.g., './requirements.txt') the required python dependencies regarding Multicast
183+ project dependencies.
172184 - path : tests/requirements.txt
173185 instructions : >-
174186 1. The multicast project's own dependencies are recorded in './requirements.txt'
0 commit comments