[HOTFIX] Fixed GHI #455

Changes in file .github/workflows/CI-BUILD.yml:
 * add pr number details to build info

Changes in file .github/workflows/CI-MATs.yml:
 * add pr number details to build info

Changes in file .github/workflows/Tests.yml:
 * add pr number details to codecov coverage upload

Changes in file multicast/__init__.py:
 * possible fix for PYL-R0401

Changes in file multicast/hear.py:
 * minor style refactor

Author: reactive-firewall

.github/workflows/CI-BUILD.yml

@@ -320,6 +320,11 @@ jobs:
             printf "%s\n" "build-artifact-attestation-url=${{ needs.BUILD_ATTEST.outputs.build-artifact-attestation-url }}" >> "$GITHUB_OUTPUT"
             printf "%s\n" "build-artifact-attestation-id=${{ needs.BUILD_ATTEST.outputs.build-artifact-attestation-id }}" >> "$GITHUB_OUTPUT"
           fi
+          if [[ "${{ github.event_name }}" == "pull_request" ]]; then
+            printf "%s\n" "build_pr_number=${{ github.event.pull_request.number }}" >> $GITHUB_OUTPUT
+          else
+            printf "%s\n" "build_pr_number=null" >> $GITHUB_OUTPUT
+          fi
           printf "%s\n" "build_environment=${ENVIRONMENT}" >> "$GITHUB_OUTPUT"
           printf "%s\n" "build_id=${{ github.run_id }}" >> "$GITHUB_OUTPUT"
           cat <"$GITHUB_OUTPUT" >> "BUILD-info.txt"

.github/workflows/CI-MATs.yml

@@ -53,6 +53,7 @@ jobs:
       build_artifact_url: ${{ steps.load_build_info.outputs.build_artifact_url }}
       build_artifact_id: ${{ steps.load_build_info.outputs.build_artifact_id }}
       build_artifact_digest: ${{ steps.load_build_info.outputs.build_artifact_digest }}
+      build_pr_number: ${{ steps.load_build_info.outputs.build_pr_number }}
       build_environment: ${{ steps.load_build_info.outputs.build_environment }}
       mats_url: ${{ steps.output_run_id.outputs.mats_url }}
       mats_id: ${{ steps.output_run_id.outputs.mats_id }}
@@ -342,6 +343,7 @@ jobs:
             printf "%s\n" "build_artifact_url=${{ needs.check_build.outputs.build_artifact_url }}" >> "$GITHUB_OUTPUT"
             printf "%s\n" "build_artifact_id=${{ needs.check_build.outputs.build_artifact_id }}" >> "$GITHUB_OUTPUT"
             printf "%s\n" "build_artifact_digest=${{ needs.check_build.outputs.build_artifact_digest }}" >> "$GITHUB_OUTPUT"
+            printf "%s\n" "build_pr_number=${{ needs.check_build.outputs.build_pr_number }}" >> "$GITHUB_OUTPUT"
             printf "%s\n" "build_environment=${{ needs.check_build.outputs.build_environment }}" >> "$GITHUB_OUTPUT"
             printf "%s\n" "build_id=${{ needs.check_build.outputs.build_id }}" >> "$GITHUB_OUTPUT"
             cat <"$GITHUB_OUTPUT" >> "BUILD-info.txt"

.github/workflows/Tests.yml

@@ -63,6 +63,7 @@ jobs:
       build_artifact_url: ${{ steps.load_build_info.outputs.build_artifact_url }}
       build_artifact_id: ${{ steps.load_build_info.outputs.build_artifact_id }}
       build_artifact_digest: ${{ steps.load_build_info.outputs.build_artifact_digest }}
+      build_pr_number: ${{ steps.load_build_info.outputs.build_pr_number }}
       build_environment: ${{ steps.load_build_info.outputs.build_environment }}
       mats_environment: ${{ steps.load_build_info.outputs.mats_environment }}
       mats_id: ${{ steps.load_build_info.outputs.mats_id }}
@@ -240,6 +241,7 @@ jobs:
         override_branch: ${{ needs.check_mats.outputs.build_ref_name }}
         override_build: ${{ needs.check_mats.outputs.build_id }}
         override_build_url: ${{ needs.check_mats.outputs.build_url }}
+        override_pr: ${{ needs.check_mats.outputs.build_pr_number }}
         files: ./coverage.xml,./test-reports/coverage.xml,./test-reports/coverage_*.xml
         directory: .
         env_vars: OS,PYTHON_VERSION
@@ -477,6 +479,7 @@ jobs:
         override_branch: ${{ needs.check_mats.outputs.build_ref_name }}
         override_build: ${{ needs.check_mats.outputs.build_id }}
         override_build_url: ${{ needs.check_mats.outputs.build_url }}
+        override_pr: ${{ needs.check_mats.outputs.build_pr_number }}
         files: ./test-reports/coverage_doctests.xml
         directory: .
         env_vars: OS,PYTHON_VERSION
@@ -897,6 +900,7 @@ jobs:
         override_branch: ${{ needs.check_mats.outputs.build_ref_name }}
         override_build: ${{ needs.check_mats.outputs.build_id }}
         override_build_url: ${{ needs.check_mats.outputs.build_url }}
+        override_pr: ${{ needs.check_mats.outputs.build_pr_number }}
         report_type: 'coverage'
         slug: 'reactive-firewall-org/multicast'
         files: ./test-reports/coverage_supplement.xml,./test-reports/coverage.xml,./test-reports/coverage_*.xml

multicast/__init__.py

@@ -1022,21 +1022,21 @@ def doStep(self, *args, **kwargs) -> tuple:  # pragma: no cover
 
 if "multicast.recv" not in sys.modules:
 	# pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
-	from . import recv as recv  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
+	from . import recv  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
 else:  # pragma: no branch
 	global recv  # skipcq: PYL-W0604
 	recv = sys.modules["multicast.recv"]
 
 if "multicast.send" not in sys.modules:
 	# pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
-	from . import send as send  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
+	from . import send  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
 else:  # pragma: no branch
 	global send  # skipcq: PYL-W0604
 	send = sys.modules["multicast.send"]
 
 if "multicast.hear" not in sys.modules:
 	# pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
-	from . import hear as hear  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
+	from . import hear  # pylint: disable=cyclic-import - skipcq: PYL-R0401, PYL-C0414
 else:  # pragma: no branch
 	global hear  # skipcq: PYL-W0604
 	hear = sys.modules["multicast.hear"]

multicast/hear.py

@@ -726,18 +726,18 @@ def handle(self) -> None:
 			>>>
 		"""
 		(data, sock) = self.request
-		if data is None or not sock:
+		if data is None or not sock:  # pragma: no branch
 			return  # nothing to do -- fail fast.
-		else:  # skipcq: PYL-R1705 -- otherwise try to decode
-			try:
-				data = data.decode('utf8') if isinstance(data, bytes) else str(data)
-			except UnicodeDecodeError:  # pragma: no cover
-				if __debug__:
-					module_logger.debug(
-						"Received invalid UTF-8 data from %s",  # lazy formatting to avoid PYL-W1203
-						self.client_address[0],
-					)
-				return  # silently ignore invalid UTF-8 data -- fail quickly.
+		# skipcq: PYL-R1705 -- otherwise can try to decode
+		try:
+			data = data.decode('utf8') if isinstance(data, bytes) else str(data)
+		except UnicodeDecodeError:  # pragma: no cover -- defensive code branch
+			if __debug__:
+				module_logger.debug(
+					"Received invalid UTF-8 data from %s",  # lazy formatting to avoid PYL-W1203
+					self.client_address[0],
+				)
+			return  # silently ignore invalid UTF-8 data -- fail quickly.
 		_logger = logging.getLogger(f"{type(self).__module__}.{type(self).__qualname__}")
 		if __debug__:
 			_logger.info(
@@ -747,7 +747,7 @@ def handle(self) -> None:
 		me = str(sock.getsockname()[0])
 		_sender: multicast.send.McastSAY = None
 		_sender = send.McastSAY()
-		if __debug__:  # pragma: no cover
+		if __debug__:  # pragma: no cover -- defensive code branch
 			_what = data.strip().replace("""\r""", str()).replace("""%""", """%%""")
 			_logger.info(
 				"%s HEAR: [%s SAID %s]",  # lazy formatting to avoid PYL-W1203