[STYLE] Apply fixes from review

Changes in file .github/tools/checkmake.bash:
 * improve log handling
 * improve error log cleanup

Changes in file Makefile:
 * corrected dependency order

Author: reactive-firewall

.github/tools/checkmake.bash

@@ -159,10 +159,16 @@ process_checkmake_output() {
 	local random_id="${RANDOM}${RANDOM}${RANDOM}${RANDOM}${RANDOM}"
 	local chmk_elog="checkmake_${random_id}_error_log.log"
 
+	# Clean up on normal exit, but preserve on error for debugging
+	trap "rm -f '${chmk_elog}' 2>/dev/null || :" EXIT ;
+
 	if ! output=$(checkmake "${file}" 2>"${chmk_elog}"); then
+		# On failure, preserve log by removing trap
+		trap - EXIT
 		printf "%s\n" "::error title='failure'::checkmake failed!"
-		printf "%s '%s'\n" "::error title='stderr'::checkmake error:" \
-			$(head -n 5000 "${chmk_elog}") >&2;
+		local error_log
+		error_log=$(head -n 5000 "${chmk_elog}")
+		printf "%s '%s'\n" "::error title='stderr'::checkmake error:" "$error_log" >&2
 
 		printf "%s\n" "${output}" | \
 			sed -e 's/   /:/g' | \

Makefile

@@ -532,7 +532,7 @@ user-install: ./dist
 	$(QUIET)$(WAIT)
 	$(QUIET)$(ECHO) "$@: Done."
 
-all: build-docs docs-req test-style test-mat test-reqs build init
+all: init build test-reqs test-mat test-style docs-reqs build-docs
 	$(QUIET)$(DO_FAIL) ;
 
 %: