Skip to content

Commit 06df291

Browse files
committed
enhance: Reorder action members for easier readability
1 parent 80c3323 commit 06df291

File tree

6 files changed

+15
-6
lines changed

6 files changed

+15
-6
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@data-client/core': patch
3+
'@data-client/react': patch
4+
---
5+
6+
Reorder action members for easier debuggability
7+
8+
- `key` at top - easiest to read 'subject'
9+
- `response` or `value` after - 'object' being set

packages/core/src/controller/actions/createFetch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ export function createFetch<
2727

2828
return {
2929
type: FETCH_TYPE,
30+
key: endpoint.key(...args),
3031
endpoint,
3132
args,
32-
key: endpoint.key(...args),
3333
meta,
3434
};
3535
}

packages/core/src/controller/actions/createOptimistic.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ export function createOptimistic<
2424

2525
return {
2626
type: OPTIMISTIC_TYPE,
27+
key: endpoint.key(...args),
2728
endpoint,
2829
args,
29-
key: endpoint.key(...args),
3030
meta: createMeta(endpoint.dataExpiryLength ?? 60000, fetchedAt),
3131
};
3232
}

packages/core/src/controller/actions/createSet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ export function createSet<S extends Queryable>(
2323
): SetAction<S> {
2424
return {
2525
type: SET_TYPE,
26-
schema,
2726
value,
27+
schema,
2828
args: args.map(ensurePojo) as SchemaArgs<S>,
2929
meta: createMeta(60000, fetchedAt),
3030
};

packages/core/src/controller/actions/createSetResponse.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ export function createSetResponse<
6363

6464
return {
6565
type: SET_RESPONSE_TYPE,
66-
endpoint,
66+
key: endpoint.key(...args),
6767
response,
68+
endpoint,
6869
args: args.map(ensurePojo),
69-
key: endpoint.key(...args),
7070
meta: createMeta(expiryLength, fetchedAt),
7171
error,
7272
};

packages/core/src/controller/actions/createSubscription.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ export function createUnsubscription<E extends EndpointInterface>(
2121
): UnsubscribeAction<E> {
2222
return {
2323
type: UNSUBSCRIBE_TYPE,
24+
key: endpoint.key(...args),
2425
endpoint,
2526
args,
26-
key: endpoint.key(...args),
2727
};
2828
}

0 commit comments

Comments
 (0)