enhance: Polyfills no longer pollute global scope

ntucker · ntucker · commit 0d501d4b0b58 · 2025-01-26T11:19:25.000Z
diff --git a/.changeset/wet-ravens-report.md b/.changeset/wet-ravens-report.md
@@ -0,0 +1,13 @@
+---
+'@data-client/use-enhanced-reducer': patch
+'@data-client/normalizr': patch
+'@data-client/endpoint': patch
+'@data-client/graphql': patch
+'@data-client/react': patch
+'@data-client/core': patch
+'@data-client/rest': patch
+'@data-client/test': patch
+'@data-client/img': patch
+---
+
+Polyfills no longer pollute global scope
diff --git a/.github/renovate.json b/.github/renovate.json
@@ -22,7 +22,7 @@
       "enabled": false
     },
     {
-      "matchPackageNames": ["@babel/runtime", "core-js", "core-js-compat"],
+      "matchPackageNames": ["@babel/runtime", "@babel/runtime-corejs3", "core-js", "core-js-pure", "core-js-compat"],
       "matchDepTypes": ["dependencies"],
       "rangeStrategy": "replace"
     },
@@ -69,7 +69,10 @@
       "matchUpdateTypes": ["major", "minor", "patch"],
       "matchPackageNames": [
         "@anansi/babel-preset",
+        "@babel/runtime",
+        "@babel/runtime-corejs3",
         "core-js",
+        "core-js-pure",
         "core-js-compat"
       ],
       "groupSlug": "build",
diff --git a/babel.config.js b/babel.config.js
@@ -3,7 +3,9 @@ const fs = require('fs');
 const path = require('path');
 
 module.exports = function (api) {
-  api.cache.using(() => process.env.NODE_ENV);
+  api.cache.using(
+    () => process.env.NODE_ENV + process.env.BROWSERSLIST_ENV + '0',
+  );
   return {
     presets: [
       [
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "benchmark": "^2.1.4",
     "conventional-changelog-anansi": "^0.2.0",
     "copyfiles": "^2.4.1",
-    "core-js": "3.40.0",
+    "core-js": "^3.40.0",
     "coveralls": "^3.1.0",
     "cpy-cli": "5.0.0",
     "cross-fetch": "^4.0.0",
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -120,8 +120,9 @@
     "url": "https://github.com/reactive/data-client/issues"
   },
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
+    "@babel/runtime-corejs3": "^7.26.0",
     "@data-client/normalizr": "^0.14.16",
+    "core-js-pure": "^3.40.0",
     "flux-standard-action": "^2.1.1"
   },
   "devDependencies": {
diff --git a/packages/core/rollup.config.mjs b/packages/core/rollup.config.mjs
@@ -1,11 +1,20 @@
-import { babel, commonjs, filesize, json, resolve, replace, terser, typeConfig, typeConfigNext } from 'rollup-plugins';
+import {
+  babel,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+  typeConfig,
+  typeConfigNext,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
-
 const dependencies = Object.keys(pkg.dependencies)
   //.concat(Object.keys(pkg.peerDependencies))
-  .filter(dep => !['@babel/runtime'].includes(dep));
+  .filter(dep => ![].includes(dep));
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node', '.jsx'];
 const nativeExtensions = ['.native.ts', ...extensions];
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -1,9 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
-
 export * as __INTERNAL__ from './internal.js';
 export type {
   NetworkError,
diff --git a/packages/endpoint/package.json b/packages/endpoint/package.json
@@ -131,7 +131,8 @@
     "url": "https://github.com/reactive/data-client/issues"
   },
   "dependencies": {
-    "@babel/runtime": "^7.17.0"
+    "@babel/runtime-corejs3": "^7.26.0",
+    "core-js-pure": "^3.40.0"
   },
   "devDependencies": {
     "@anansi/browserslist-config": "^1.4.2",
diff --git a/packages/endpoint/rollup.config.mjs b/packages/endpoint/rollup.config.mjs
@@ -1,9 +1,18 @@
-import { babel, dts, commonjs, filesize, json, resolve, replace, terser } from 'rollup-plugins';
+import {
+  babel,
+  dts,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies).filter(
-  dep => !['@babel/runtime'].includes(dep),
+  dep => ![].includes(dep),
 );
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node'];
diff --git a/packages/endpoint/src/index.ts b/packages/endpoint/src/index.ts
@@ -1,9 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
-
 export type {
   EndpointOptions,
   EndpointInstance,
diff --git a/packages/graphql/package.json b/packages/graphql/package.json
@@ -104,8 +104,9 @@
   "funding": "https://github.com/sponsors/ntucker",
   "license": "Apache-2.0",
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
-    "@data-client/endpoint": "^0.14.17"
+    "@babel/runtime-corejs3": "^7.26.0",
+    "@data-client/endpoint": "^0.14.17",
+    "core-js-pure": "^3.40.0"
   },
   "devDependencies": {
     "@anansi/browserslist-config": "^1.4.2",
diff --git a/packages/graphql/rollup.config.mjs b/packages/graphql/rollup.config.mjs
@@ -1,9 +1,19 @@
-import { babel, commonjs, filesize, json, resolve, replace, terser, typeConfig, typeConfigNext } from 'rollup-plugins';
+import {
+  babel,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+  typeConfig,
+  typeConfigNext,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies).filter(
-  dep => !['@babel/runtime'].includes(dep),
+  dep => ![].includes(dep),
 );
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node'];
diff --git a/packages/img/package.json b/packages/img/package.json
@@ -69,8 +69,9 @@
   "funding": "https://github.com/sponsors/ntucker",
   "license": "Apache-2.0",
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
-    "@data-client/endpoint": "^0.14.17"
+    "@babel/runtime-corejs3": "^7.26.0",
+    "@data-client/endpoint": "^0.14.17",
+    "core-js-pure": "^3.40.0"
   },
   "peerDependencies": {
     "@data-client/react": "^0.1.0 || ^0.2.0 || ^0.3.0 || ^0.4.0 || ^0.5.0 || ^0.7.0 || ^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^0.14.0",
diff --git a/packages/img/rollup.config.mjs b/packages/img/rollup.config.mjs
@@ -1,10 +1,18 @@
-import { babel, commonjs, filesize, json, resolve, replace, terser } from 'rollup-plugins';
+import {
+  babel,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies)
   .concat(Object.keys(pkg.peerDependencies))
-  .filter(dep => !['@babel/runtime'].includes(dep));
+  .filter(dep => ![].includes(dep));
 const peers = Object.keys(pkg.peerDependencies);
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node'];
diff --git a/packages/normalizr/package.json b/packages/normalizr/package.json
@@ -116,7 +116,8 @@
     "url": "https://github.com/reactive/data-client/issues"
   },
   "dependencies": {
-    "@babel/runtime": "^7.17.0"
+    "@babel/runtime-corejs3": "^7.26.0",
+    "core-js-pure": "^3.40.0"
   },
   "devDependencies": {
     "@anansi/browserslist-config": "^1.4.2",
diff --git a/packages/normalizr/src/index.ts b/packages/normalizr/src/index.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 import { denormalize } from './denormalize/denormalize.js';
 import { isEntity } from './isEntity.js';
 import WeakDependencyMap from './memo/WeakDependencyMap.js';
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -168,9 +168,10 @@
   "funding": "https://github.com/sponsors/ntucker",
   "license": "Apache-2.0",
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
+    "@babel/runtime-corejs3": "^7.26.0",
     "@data-client/core": "^0.14.18",
-    "@data-client/use-enhanced-reducer": "^0.1.11"
+    "@data-client/use-enhanced-reducer": "^0.1.11",
+    "core-js-pure": "^3.40.0"
   },
   "peerDependencies": {
     "@react-navigation/native": "^6.0.0 || ^7.0.0",
diff --git a/packages/react/rollup.config.mjs b/packages/react/rollup.config.mjs
@@ -1,13 +1,21 @@
-import { babel, banner, commonjs, filesize, json, resolve, replace, terser, typeConfig, typeConfigNext } from 'rollup-plugins';
+import {
+  babel,
+  banner,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+  typeConfig,
+  typeConfigNext,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies)
   .concat(Object.keys(pkg.peerDependencies))
-  .filter(
-    dep =>
-      !['@data-client/use-enhanced-reducer', '@babel/runtime'].includes(dep),
-  );
+  .filter(dep => !['@data-client/use-enhanced-reducer'].includes(dep));
 const peers = Object.keys(pkg.peerDependencies);
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node', '.jsx'];
diff --git a/packages/react/src/index.ts b/packages/react/src/index.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 export { Controller, ExpiryStatus, actionTypes } from '@data-client/core';
 export type {
   EndpointExtraOptions,
diff --git a/packages/react/src/server/index.ts b/packages/react/src/server/index.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 export { default as createPersistedStore } from './createPersistedStore.js';
 export * from './getInitialData.js';
 export { default as createServerDataComponent } from './createServerDataComponent.js';
diff --git a/packages/rest/package.json b/packages/rest/package.json
@@ -130,8 +130,9 @@
   "funding": "https://github.com/sponsors/ntucker",
   "license": "Apache-2.0",
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
+    "@babel/runtime-corejs3": "^7.26.0",
     "@data-client/endpoint": "^0.14.17",
+    "core-js-pure": "^3.40.0",
     "path-to-regexp": "^6.3.0"
   },
   "devDependencies": {
diff --git a/packages/rest/rollup.config.mjs b/packages/rest/rollup.config.mjs
@@ -1,9 +1,19 @@
-import { babel, commonjs, filesize, json, resolve, replace, terser, typeConfig, typeConfigNext } from 'rollup-plugins';
+import {
+  babel,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+  typeConfig,
+  typeConfigNext,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies).filter(
-  dep => !['@babel/runtime'].includes(dep),
+  dep => ![].includes(dep),
 );
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node'];
diff --git a/packages/rest/src/index.ts b/packages/rest/src/index.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 export { default as RestEndpoint } from './RestEndpoint.js';
 export type {
   GetEndpoint,
diff --git a/packages/test/package.json b/packages/test/package.json
@@ -111,10 +111,11 @@
   "funding": "https://github.com/sponsors/ntucker",
   "license": "Apache-2.0",
   "dependencies": {
-    "@babel/runtime": "^7.17.0",
+    "@babel/runtime-corejs3": "^7.26.0",
     "@testing-library/dom": "^10.1.0",
     "@testing-library/react": "^16.0.0",
-    "@testing-library/react-native": "^13.0.0"
+    "@testing-library/react-native": "^13.0.0",
+    "core-js-pure": "^3.40.0"
   },
   "peerDependencies": {
     "@data-client/react": "^0.12.15 || ^0.13.0 || ^0.14.0",
diff --git a/packages/test/rollup.config.mjs b/packages/test/rollup.config.mjs
@@ -1,10 +1,10 @@
-import {babel, banner, commonjs, resolve} from 'rollup-plugins';
+import { babel, banner, commonjs, resolve } from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.dependencies)
   .concat(Object.keys(pkg.peerDependencies))
-  .filter(dep => !['@data-client/normalizr', '@babel/runtime'].includes(dep));
+  .filter(dep => !['@data-client/normalizr'].includes(dep));
 
 const extensions = [
   '.js',
diff --git a/packages/test/src/browser.ts b/packages/test/src/browser.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 import mockInitialState from './mockState.js';
 export { default as MockResolver } from './MockResolver.js';
 export type {
diff --git a/packages/test/src/index.ts b/packages/test/src/index.ts
@@ -1,8 +1,3 @@
-Object.hasOwn =
-  Object.hasOwn ||
-  /* istanbul ignore next */ function hasOwn(it, key) {
-    return Object.prototype.hasOwnProperty.call(it, key);
-  };
 export { default as MockResolver } from './MockResolver.js';
 export {
   default as makeRenderDataClient,
diff --git a/packages/use-enhanced-reducer/rollup.config.mjs b/packages/use-enhanced-reducer/rollup.config.mjs
@@ -1,9 +1,18 @@
-import { babel, banner, commonjs, filesize, json, resolve, replace, terser } from 'rollup-plugins';
+import {
+  babel,
+  banner,
+  commonjs,
+  filesize,
+  json,
+  resolve,
+  replace,
+  terser,
+} from 'rollup-plugins';
 
 import pkg from './package.json' with { type: 'json' };
 
 const dependencies = Object.keys(pkg.peerDependencies).filter(
-  dep => !['@babel/runtime'].includes(dep),
+  dep => ![].includes(dep),
 );
 
 const extensions = ['.js', '.ts', '.tsx', '.mjs', '.json', '.node'];
diff --git a/yarn.lock b/yarn.lock
