fix: SSR hydration when removing devtools manager

Author: ntucker

.changeset/hip-shirts-tickle.md

@@ -0,0 +1,5 @@
+---
+'@data-client/react': patch
+---
+
+Fix SSR hydration when removing devtools manager

packages/react/src/components/DataProvider.tsx

@@ -71,6 +71,10 @@ See https://dataclient.io/docs/guides/ssr.`,
     managersRef.current,
   );
 
+  // only include if they have devtools integrated
+  const hasDevManager = !!managersRef.current.find(
+    manager => manager instanceof DevToolsManager,
+  );
   return (
     <ControllerContext.Provider value={controllerRef.current}>
       <DataStore
@@ -81,7 +85,7 @@ See https://dataclient.io/docs/guides/ssr.`,
       >
         {children}
       </DataStore>
-      {renderDevButton(devButton, managersRef.current)}
+      {renderDevButton(devButton, hasDevManager)}
     </ControllerContext.Provider>
   );
 }

packages/react/src/components/renderDevButton.tsx

@@ -1,4 +1,3 @@
-import { DevToolsManager, type Manager } from '@data-client/core';
 import { lazy } from 'react';
 
 import type { DevToolsPosition } from './DevToolsButton.js';
@@ -7,14 +6,10 @@ import UniversalSuspense from './UniversalSuspense.js';
 
 export function renderDevButton(
   devButton: DevToolsPosition | null | undefined,
-  managers: Manager[],
+  hasDevManager: boolean,
 ) {
   /* istanbul ignore else */
-  if (
-    process.env.NODE_ENV !== 'production' &&
-    // only include if they have devtools integrated
-    managers.find(manager => manager instanceof DevToolsManager)
-  ) {
+  if (process.env.NODE_ENV !== 'production' && hasDevManager) {
     return (
       <UniversalSuspense fallback={null}>
         {

packages/react/src/server/createPersistedStore.tsx

@@ -13,7 +13,10 @@ import { useSyncExternalStore } from 'react';
 import { ExternalDataProvider, PromiseifyMiddleware } from './redux/index.js';
 import { createStore, applyMiddleware } from './redux/redux.js';
 
-export default function createPersistedStore(managers?: Manager[]) {
+export default function createPersistedStore(
+  managers?: Manager[],
+  hasDevManager: boolean = true,
+) {
   const controller = new Controller();
   managers = managers ?? [new NetworkManager()];
   const nm: NetworkManager = managers.find(
@@ -56,6 +59,7 @@ export default function createPersistedStore(managers?: Manager[]) {
         store={store}
         selector={selector}
         controller={controller}
+        hasDevManager={hasDevManager}
       >
         {children}
       </ExternalDataProvider>

packages/react/src/server/nextjs/DataProvider/createPersistedStoreServer.tsx

@@ -6,6 +6,7 @@ import {
   createReducer,
   initialState,
   applyManager,
+  DevToolsManager,
 } from '@data-client/core';
 import type { ComponentProps } from 'react';
 
@@ -61,12 +62,22 @@ export default function createPersistedStore(managers?: Manager[]) {
     return getState();
   })();
 
-  const StoreDataProvider = ({ children }: ProviderProps) => {
+  const StoreDataProvider = ({
+    children,
+    devButton,
+    managers,
+  }: ProviderProps) => {
+    // only include if they have devtools integrated
+    const hasDevManager = !!managers?.find(
+      manager => manager instanceof DevToolsManager,
+    );
     return (
       <ExternalDataProvider
         store={store}
         selector={selector}
         controller={controller}
+        devButton={devButton}
+        hasDevManager={hasDevManager}
       >
         {children}
       </ExternalDataProvider>

packages/react/src/server/redux/DataProvider.tsx

@@ -1,16 +1,23 @@
 'use client';
-import type { Controller, Manager, State } from '@data-client/core';
+import {
+  DevToolsManager,
+  type Controller,
+  type Manager,
+  type State,
+} from '@data-client/core';
 import React, { useEffect, useMemo } from 'react';
 
 import ExternalCacheProvider from './ExternalDataProvider.js';
 import { prepareStore } from './prepareStore.js';
+import { DevToolsPosition } from '../../components/DevToolsButton.js';
 
 /** For usage with https://dataclient.io/docs/api/makeRenderDataClient */
 export default function ExternalDataProvider({
   children,
   managers,
   initialState,
   Controller,
+  devButton = 'bottom-right',
 }: Props) {
   const { selector, store, controller } = useMemo(
     () => prepareStore(initialState, managers, Controller),
@@ -33,11 +40,18 @@ export default function ExternalDataProvider({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [...managers]);
 
+  // only include if they have devtools integrated
+  const hasDevManager = !!managers.find(
+    manager => manager instanceof DevToolsManager,
+  );
+
   return (
     <ExternalCacheProvider
       store={store}
       selector={selector}
       controller={controller}
+      devButton={devButton}
+      hasDevManager={hasDevManager}
     >
       {children}
     </ExternalCacheProvider>
@@ -49,4 +63,5 @@ interface Props {
   managers: Manager[];
   initialState: State<unknown>;
   Controller: typeof Controller;
+  devButton?: DevToolsPosition | null | undefined;
 }

packages/react/src/server/redux/ExternalDataProvider.tsx

@@ -13,6 +13,8 @@ import React, {
   useCallback,
 } from 'react';
 
+import type { DevToolsPosition } from '../../components/DevToolsButton.js';
+import { renderDevButton } from '../../components/renderDevButton.js';
 import {
   ControllerContext,
   StoreContext,
@@ -32,6 +34,8 @@ interface Props<S> {
   store: Store<S>;
   selector: (state: S) => State<unknown>;
   controller: Controller;
+  devButton?: DevToolsPosition | null | undefined;
+  hasDevManager?: boolean;
 }
 
 /**
@@ -43,6 +47,8 @@ export default function ExternalDataProvider<S>({
   store,
   selector,
   controller,
+  devButton = 'bottom-right',
+  hasDevManager = false,
 }: Props<S>) {
   const masterReducer = useMemo(() => createReducer(controller), [controller]);
   const selectState = useCallback(() => {
@@ -80,9 +86,7 @@ export default function ExternalDataProvider<S>({
           <UniversalSuspense fallback={<BackupLoading />}>
             {children}
           </UniversalSuspense>
-          {process.env.NODE_ENV !== 'production' ?
-            <UniversalSuspense fallback={null} />
-          : undefined}
+          {renderDevButton(devButton, hasDevManager)}
         </ControllerContext.Provider>
       </StoreContext.Provider>
     </StateContext.Provider>

packages/react/src/server/redux/redux.d.ts

@@ -291,23 +291,23 @@ interface Store<S = any, A extends Action = UnknownAction, StateExt = unknown> {
    * @returns A function to remove this change listener.
    */
   subscribe(listener: ListenerCallback): Unsubscribe;
-  /**
-   * Replaces the reducer currently used by the store to calculate the state.
-   *
-   * You might need this if your app implements code splitting and you want to
-   * load some of the reducers dynamically. You might also need this if you
-   * implement a hot reloading mechanism for Redux.
-   *
-   * @param nextReducer The reducer for the store to use instead.
-   */
-  replaceReducer(nextReducer: Reducer<S, A>): void;
-  /**
-   * Interoperability point for observable/reactive libraries.
-   * @returns {observable} A minimal observable of state changes.
-   * For more information, see the observable proposal:
-   * https://github.com/tc39/proposal-observable
-   */
-  [Symbol.observable](): Observable<S & StateExt>;
+  // /**
+  //  * Replaces the reducer currently used by the store to calculate the state.
+  //  *
+  //  * You might need this if your app implements code splitting and you want to
+  //  * load some of the reducers dynamically. You might also need this if you
+  //  * implement a hot reloading mechanism for Redux.
+  //  *
+  //  * @param nextReducer The reducer for the store to use instead.
+  //  */
+  // replaceReducer(nextReducer: Reducer<S, A>): void;
+  // /**
+  //  * Interoperability point for observable/reactive libraries.
+  //  * @returns {observable} A minimal observable of state changes.
+  //  * For more information, see the observable proposal:
+  //  * https://github.com/tc39/proposal-observable
+  //  */
+  // [Symbol.observable](): Observable<S & StateExt>;
 }
 type UnknownIfNonSpecific<T> = {} extends T ? unknown : T;
 /**

packages/react/src/server/redux/redux.js

@@ -3,11 +3,6 @@ export function formatProdErrorMessage(code) {
   return `Minified Redux error #${code}; visit https://redux.js.org/Errors?code=${code} for the full message or use the non-minified dev environment for full errors. `;
 }
 
-// src/utils/symbol-observable.ts
-var $$observable = /* @__PURE__ */ (() =>
-  (typeof Symbol === 'function' && Symbol.observable) || '@@observable')();
-var symbol_observable_default = $$observable;
-
 // src/utils/actionTypes.ts
 var randomString = () =>
   Math.random().toString(36).substring(7).split('').join('.');
@@ -224,64 +219,13 @@ function createStore(reducer, preloadedState, enhancer) {
     });
     return action;
   }
-  function replaceReducer(nextReducer) {
-    if (typeof nextReducer !== 'function') {
-      throw new Error(
-        process.env.NODE_ENV === 'production' ?
-          formatProdErrorMessage(10)
-        : `Expected the nextReducer to be a function. Instead, received: '${kindOf(nextReducer)}`,
-      );
-    }
-    currentReducer = nextReducer;
-    dispatch({
-      type: actionTypes_default.REPLACE,
-    });
-  }
-  function observable() {
-    const outerSubscribe = subscribe;
-    return {
-      /**
-       * The minimal observable subscription method.
-       * @param observer Any object that can be used as an observer.
-       * The observer object should have a `next` method.
-       * @returns An object with an `unsubscribe` method that can
-       * be used to unsubscribe the observable from the store, and prevent further
-       * emission of values from the observable.
-       */
-      subscribe(observer) {
-        if (typeof observer !== 'object' || observer === null) {
-          throw new Error(
-            process.env.NODE_ENV === 'production' ?
-              formatProdErrorMessage(11)
-            : `Expected the observer to be an object. Instead, received: '${kindOf(observer)}'`,
-          );
-        }
-        function observeState() {
-          const observerAsObserver = observer;
-          if (observerAsObserver.next) {
-            observerAsObserver.next(getState());
-          }
-        }
-        observeState();
-        const unsubscribe = outerSubscribe(observeState);
-        return {
-          unsubscribe,
-        };
-      },
-      [symbol_observable_default]() {
-        return this;
-      },
-    };
-  }
   dispatch({
     type: actionTypes_default.INIT,
   });
   const store = {
     dispatch,
     subscribe,
     getState,
-    replaceReducer,
-    [symbol_observable_default]: observable,
   };
   return store;
 }

website/src/components/Playground/editor-types/@data-client/core.d.ts

@@ -485,9 +485,7 @@ declare class Controller<D extends GenericDispatch = DataClientDispatch> {
      * Forces refetching and suspense on useSuspense with the same Endpoint and parameters.
      * @see https://dataclient.io/docs/api/Controller#invalidate
      */
-    invalidate: <E extends EndpointInterface<FetchFunction, Schema | undefined, boolean | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [
-        null
-    ]) => Promise<void>;
+    invalidate: <E extends EndpointInterface<FetchFunction, Schema | undefined, boolean | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [null]) => Promise<void>;
     /**
      * Forces refetching and suspense on useSuspense on all matching endpoint result keys.
      * @see https://dataclient.io/docs/api/Controller#invalidateAll
@@ -549,16 +547,12 @@ declare class Controller<D extends GenericDispatch = DataClientDispatch> {
      * Marks a new subscription to a given Endpoint.
      * @see https://dataclient.io/docs/api/Controller#subscribe
      */
-    subscribe: <E extends EndpointInterface<FetchFunction, Schema | undefined, false | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [
-        null
-    ]) => Promise<void>;
+    subscribe: <E extends EndpointInterface<FetchFunction, Schema | undefined, false | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [null]) => Promise<void>;
     /**
      * Marks completion of subscription to a given Endpoint.
      * @see https://dataclient.io/docs/api/Controller#unsubscribe
      */
-    unsubscribe: <E extends EndpointInterface<FetchFunction, Schema | undefined, false | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [
-        null
-    ]) => Promise<void>;
+    unsubscribe: <E extends EndpointInterface<FetchFunction, Schema | undefined, false | undefined>>(endpoint: E, ...args: readonly [...Parameters<E>] | readonly [null]) => Promise<void>;
     /*************** More ***************/
     /**
      * Gets a snapshot (https://dataclient.io/docs/api/Snapshot)