fix: Refcounts should maintain based on mount cycle

Author: ntucker

packages/react/src/hooks/useCache.ts

@@ -7,7 +7,7 @@ import type {
   NI,
 } from '@data-client/core';
 import { ExpiryStatus } from '@data-client/core';
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 
 import useCacheState from './useCacheState.js';
 import useController from '../hooks/useController.js';
@@ -39,7 +39,7 @@ export default function useCache<
   const meta = state.meta[key];
 
   // Compute denormalized value
-  const { data, expiryStatus, expiresAt } = useMemo(() => {
+  const { data, expiryStatus, expiresAt, countRef } = useMemo(() => {
     return controller.getResponse(endpoint, ...args, state);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [
@@ -69,6 +69,9 @@ export default function useCache<
   const loading = expiryStatus !== ExpiryStatus.Valid && expired;
   /****************************************************************************************************/
 
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(countRef, [data]);
+
   return useMemo(() => {
     // if useSuspense() would suspend, don't include entities from cache
     if (loading) {

packages/react/src/hooks/useDLE.native.ts

@@ -8,13 +8,12 @@ import type {
   ResolveType,
 } from '@data-client/core';
 import { ExpiryStatus } from '@data-client/core';
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 import { InteractionManager } from 'react-native';
 
 import useCacheState from './useCacheState.js';
 import useController from './useController.js';
 import useFocusEffect from './useFocusEffect.native.js';
-import { useUniveralEffect } from './useUniversalEffect.js';
 
 type SchemaReturn<S extends Schema | undefined> =
   | {
@@ -137,7 +136,8 @@ export default function useDLE<
 
   const error = controller.getError(endpoint, ...args, state);
 
-  useUniveralEffect(countRef, [data]);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(countRef, [data]);
 
   return {
     data,

packages/react/src/hooks/useDLE.ts

@@ -8,11 +8,10 @@ import type {
   ResolveType,
 } from '@data-client/core';
 import { ExpiryStatus } from '@data-client/core';
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 
 import useCacheState from './useCacheState.js';
 import useController from './useController.js';
-import { useUniveralEffect } from './useUniversalEffect.js';
 
 type SchemaReturn<S extends Schema | undefined> =
   | {
@@ -124,7 +123,8 @@ export default function useDLE<
 
   const error = controller.getError(endpoint, ...args, state);
 
-  useUniveralEffect(countRef, [data]);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(countRef, [data]);
 
   return {
     data,

packages/react/src/hooks/useSuspense.native.ts

@@ -8,13 +8,12 @@ import type {
   ResolveType,
   NI,
 } from '@data-client/core';
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 import { InteractionManager } from 'react-native';
 
 import useCacheState from './useCacheState.js';
 import useController from './useController.js';
 import useFocusEffect from './useFocusEffect.native.js';
-import { useUniveralEffect } from './useUniversalEffect.js';
 
 /**
  * Ensure an endpoint is available.
@@ -113,7 +112,8 @@ export default function useSuspense<
     return () => task.cancel();
   }, []);
 
-  useUniveralEffect(countRef, [data]);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(countRef, [data]);
 
   return data;
 }

packages/react/src/hooks/useSuspense.ts

@@ -7,11 +7,10 @@ import type {
   DenormalizeNullable,
   ResolveType,
 } from '@data-client/core';
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 
 import useCacheState from './useCacheState.js';
 import useController from './useController.js';
-import { useUniveralEffect } from './useUniversalEffect.js';
 
 /**
  * Ensure an endpoint is available.
@@ -99,7 +98,8 @@ export default function useSuspense<
 
   if (error) throw error;
 
-  useUniveralEffect(countRef, [data]);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(countRef, [data]);
 
   return data;
 }