Skip to content

Commit 9db7433

Browse files
authored
internal: Remove unused actions/cache from benchmark workflows (#3797)
The rhysd/github-action-benchmark action fetches data directly from gh-pages-bench branch — the actions/cache steps were never used. Also set name: 'Benchmark React' so PR comments are distinguishable. Made-with: Cursor
1 parent 9e9fb70 commit 9db7433

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

.github/workflows/benchmark-react.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,11 @@ jobs:
5555
cd examples/benchmark-react && yarn bench | tee react-bench-output.json
5656
5757
# PR comments on changes
58-
- name: Download previous benchmark data (PR)
59-
if: ${{ github.event_name == 'pull_request' }}
60-
uses: actions/cache@v5
61-
with:
62-
path: ./cache
63-
key: ${{ runner.os }}-benchmark-react-pr-${{ github.run_number }}
64-
restore-keys: |
65-
${{ runner.os }}-benchmark-react
6658
- name: Store benchmark result (PR)
6759
if: ${{ github.event_name == 'pull_request' }}
6860
uses: rhysd/github-action-benchmark@v1
6961
with:
62+
name: 'Benchmark React'
7063
tool: 'customSmallerIsBetter'
7164
output-file-path: examples/benchmark-react/react-bench-output.json
7265
github-token: "${{ secrets.GITHUB_TOKEN }}"
@@ -80,16 +73,11 @@ jobs:
8073
auto-push: false
8174

8275
# master reports to history
83-
- name: Download previous benchmark data (main)
84-
if: ${{ github.event_name == 'push' }}
85-
uses: actions/cache@v5
86-
with:
87-
path: ./cache
88-
key: ${{ runner.os }}-benchmark-react
8976
- name: Store benchmark result (main)
9077
if: ${{ github.event_name == 'push' }}
9178
uses: rhysd/github-action-benchmark@v1
9279
with:
80+
name: 'Benchmark React'
9381
tool: 'customSmallerIsBetter'
9482
output-file-path: examples/benchmark-react/react-bench-output.json
9583
github-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/benchmark.yml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,7 @@ jobs:
4747
- name: Run benchmark
4848
run: yarn workspace example-benchmark start | tee output.txt
4949

50-
5150
# PR comments on changes
52-
- name: Download previous benchmark data (PR)
53-
if: ${{ github.event_name == 'pull_request' }}
54-
uses: actions/cache@v5
55-
with:
56-
path: ./cache
57-
key: ${{ runner.os }}-benchmark-pr-${{ github.run_number }}
58-
restore-keys: |
59-
${{ runner.os }}-benchmark
6051
- name: Store benchmark result (PR)
6152
if: ${{ github.event_name == 'pull_request' }}
6253
uses: rhysd/github-action-benchmark@v1
@@ -65,22 +56,14 @@ jobs:
6556
output-file-path: output.txt
6657
github-token: "${{ secrets.GITHUB_TOKEN }}"
6758
gh-pages-branch: 'gh-pages-bench'
68-
# Show alert with commit comment on detecting possible performance regression
6959
alert-threshold: '150%'
7060
comment-always: true
7161
fail-on-alert: false
7262
alert-comment-cc-users: '@ntucker'
73-
# we only want to compare against master, so do not save for PR
7463
save-data-file: false
7564
auto-push: false
7665

7766
# master reports to history
78-
- name: Download previous benchmark data (main)
79-
if: ${{ github.event_name == 'push' }}
80-
uses: actions/cache@v5
81-
with:
82-
path: ./cache
83-
key: ${{ runner.os }}-benchmark
8467
- name: Store benchmark result (main)
8568
if: ${{ github.event_name == 'push' }}
8669
uses: rhysd/github-action-benchmark@v1

0 commit comments

Comments
 (0)