enhance: Minor optimizations to store creation

Author: ntucker

.changeset/long-numbers-vanish.md

@@ -0,0 +1,5 @@
+---
+'@data-client/core': patch
+---
+
+Minor store creation optimizations

packages/core/src/manager/applyManager.ts

@@ -6,11 +6,13 @@ export default function applyManager(
   managers: Manager[],
   controller: Controller,
 ): Middleware[] {
-  return managers.map(manager => {
+  return managers.map((manager, i) => {
     const middleware = manager.getMiddleware();
     return ({ dispatch, getState }) => {
-      (controller as any).dispatch = dispatch;
-      (controller as any).getState = getState;
+      if (i === 0) {
+        (controller as any).dispatch = dispatch;
+        (controller as any).getState = getState;
+      }
       // controller is a superset of the middleware API
       return middleware(controller as Controller<any>);
     };

packages/react/src/components/DataStore.tsx

@@ -31,11 +31,8 @@ function DataStore({
 }: StoreProps) {
   const masterReducer = useMemo(() => createReducer(controller), [controller]);
 
-  const [state, dispatch] = useEnhancedReducer(
-    masterReducer,
-    initialState,
-    middlewares,
-  );
+  // we don't need `dispatch` here, since applyManager() assigns the dispatch to controller
+  const [state] = useEnhancedReducer(masterReducer, initialState, middlewares);
 
   const optimisticState = useMemo(
     () => state.optimistic.reduce(masterReducer, state),