internal: Simplify type casting for non-exposed types

Author: ntucker

packages/core/src/controller/Controller.ts

@@ -267,7 +267,7 @@ export default class Controller<
     args[0] !== null ?
       this.dispatch(
         createSubscription(endpoint, {
-          args: args as readonly [...Parameters<E>],
+          args: args as Parameters<E>,
         }),
       )
     : Promise.resolve();
@@ -289,7 +289,7 @@ export default class Controller<
     args[0] !== null ?
       this.dispatch(
         createUnsubscription(endpoint, {
-          args: args as readonly [...Parameters<E>],
+          args: args as Parameters<E>,
         }),
       )
     : Promise.resolve();

packages/react/src/hooks/useDLE.native.ts

@@ -115,7 +115,7 @@ export default function useDLE<
     // revalidating non-suspending data is low priority, so make sure it doesn't stutter animations
     const task = InteractionManager.runAfterInteractions(() => {
       if (Date.now() > expiresAt && key) {
-        controller.fetch(endpoint, ...(args as readonly [...Parameters<E>]));
+        controller.fetch(endpoint, ...(args as Parameters<E>));
       }
     });
 

packages/react/src/hooks/useFetch.native.ts

@@ -60,11 +60,7 @@ export default function useFetch<
 
   // Compute denormalized value
   const { expiryStatus, expiresAt } = useMemo(() => {
-    return controller.getResponse(endpoint, ...args, state) as {
-      data: Denormalize<E['schema']>;
-      expiryStatus: ExpiryStatus;
-      expiresAt: number;
-    };
+    return controller.getResponse(endpoint, ...args, state);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [
     cacheResults,
@@ -82,7 +78,7 @@ export default function useFetch<
     // null params mean don't do anything
     if ((Date.now() <= expiresAt && !forceFetch) || !key) return;
     // if args is [null], we won't get to this line
-    return controller.fetch(endpoint, ...(args as [...Parameters<E>]));
+    return controller.fetch(endpoint, ...(args as Parameters<E>));
     // we need to check against serialized params, since params can change frequently
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [expiresAt, controller, key, forceFetch, state.lastReset]);
@@ -91,7 +87,7 @@ export default function useFetch<
     // revalidating non-suspending data is low priority, so make sure it doesn't stutter animations
     const task = InteractionManager.runAfterInteractions(() => {
       if (Date.now() > expiresAt && key) {
-        controller.fetch(endpoint, ...(args as readonly [...Parameters<E>]));
+        controller.fetch(endpoint, ...(args as Parameters<E>));
       }
     });
 

packages/react/src/hooks/useFetch.ts

@@ -58,11 +58,7 @@ export default function useFetch<
 
   // Compute denormalized value
   const { expiryStatus, expiresAt } = useMemo(() => {
-    return controller.getResponse(endpoint, ...args, state) as {
-      data: Denormalize<E['schema']>;
-      expiryStatus: ExpiryStatus;
-      expiresAt: number;
-    };
+    return controller.getResponse(endpoint, ...args, state);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [
     cacheResults,
@@ -81,7 +77,7 @@ export default function useFetch<
     if ((Date.now() <= expiresAt && !forceFetch) || !key) return;
 
     // if args is [null], we won't get to this line
-    return controller.fetch(endpoint, ...(args as [...Parameters<E>]));
+    return controller.fetch(endpoint, ...(args as Parameters<E>));
     // we need to check against serialized params, since params can change frequently
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [expiresAt, controller, key, forceFetch, state.lastReset]);

packages/react/src/hooks/useSubscription.native.tsx

@@ -27,7 +27,7 @@ export default function useSubscription<
     () => {
       if (!key) return;
       // typescript cannot infer truthy key means args is not null
-      const cleanedArgs = args as readonly [...Parameters<E>];
+      const cleanedArgs = args as Parameters<E>;
 
       controller.subscribe(endpoint, ...cleanedArgs);
       return () => {

packages/react/src/hooks/useSuspense.native.ts

@@ -88,7 +88,7 @@ export default function useSuspense<
     return (
       controller
         // if args is [null], we won't get to this line
-        .fetch(endpoint, ...(args as [...Parameters<E>]))
+        .fetch(endpoint, ...(args as Parameters<E>))
         .catch(() => {})
     );
     // we need to check against serialized params, since params can change frequently
@@ -106,7 +106,7 @@ export default function useSuspense<
     // revalidating non-suspending data is low priority, so make sure it doesn't stutter animations
     const task = InteractionManager.runAfterInteractions(() => {
       if (Date.now() > expiresAt && key) {
-        controller.fetch(endpoint, ...(args as readonly [...Parameters<E>]));
+        controller.fetch(endpoint, ...(args as Parameters<E>));
       }
     });
 

packages/react/src/hooks/useSuspense.ts

@@ -86,7 +86,7 @@ export default function useSuspense<
     return (
       controller
         // if args is [null], we won't get to this line
-        .fetch(endpoint, ...(args as [...Parameters<E>]))
+        .fetch(endpoint, ...(args as Parameters<E>))
         .catch(() => {})
     );
     // we need to check against serialized params, since params can change frequently