Use correct override signature for MessageCodec.jsonArrayCodec
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @WojciechMazur The code has since changed a little bit, I incorporated your change. Thanks a lot for testing and creating this PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compilation error found in Scala 3 Open Community Build for the improved checks of overriden signatures.
Previously method taking a varargs could have been overriden with a method taking a
Seq, it was an unintended bug. It was fixed in scala/scala3#16836 and would target Scala 3.4.0. It was the only public codebase which was using the no longer legal override.Open CB logs
We provide a fix for the broken compilation to allow for further testing of this project in the Open Community Build allowing us to find any other possible compiler regressions in the future.