Update robolectric and move unit tests

Author: Ashwini Kumar

app/build.gradle.kts

@@ -134,10 +134,10 @@ dependencies {
 
     // start-region Test
     testImplementation(Deps.junit)
-    testImplementation(Deps.Mockito.core)
-    androidTestImplementation(Deps.Mockito.android)
-    testImplementation(Deps.Mockito.kotlin)
-    testImplementation(Deps.Mockito.inline)
+    testImplementation(Deps.Test.Mockito.core)
+    androidTestImplementation(Deps.Test.Mockito.android)
+    testImplementation(Deps.Test.Mockito.kotlin)
+    testImplementation(Deps.Test.Mockito.inline)
     testImplementation(Deps.AndroidX.Test.arch_core_testing)
     testImplementation(Deps.AndroidX.Test.core)
     androidTestImplementation(Deps.AndroidX.Test.runner)
@@ -147,8 +147,8 @@ dependencies {
     androidTestImplementation(Deps.AndroidX.Test.Espresso.contrib)
     androidTestImplementation(Deps.AndroidX.Test.Espresso.idling_resource)
     androidTestImplementation(Deps.AndroidX.Test.rules)
-    testImplementation(Deps.truth)
-    androidTestImplementation(Deps.truth)
+    testImplementation(Deps.Test.truth)
+    testImplementation(Deps.Test.robolectric)
     testImplementation(Deps.Coroutines.test)
     // end-region Test
 

app/src/androidTest/java/com/android/tvmaze/utils/TestUtils.kt

@@ -21,7 +21,7 @@ class FavoriteShowsAdapter(
         val layoutInflater = LayoutInflater.from(parent.context)
         val showListItemBinding = ShowListItemBinding.inflate(layoutInflater, parent, false)
         val holder = FavoriteShowHolder(showListItemBinding)
-        holder.binding.favorite.setOnClickListener { onFavouriteIconClicked(holder.adapterPosition) }
+        holder.binding.favorite.setOnClickListener { onFavouriteIconClicked(holder.absoluteAdapterPosition) }
         holder.binding.showFavoriteIcon = false
         return holder
     }

app/src/main/java/com/android/tvmaze/favorite/FavoriteShowsAdapter.kt

@@ -27,7 +27,7 @@ class ShowsAdapter constructor(
             .inflate(layoutInflater, parent, false)
         val showHolder = ShowHolder(showListItemBinding)
         showHolder.binding.showFavoriteIcon = true
-        showHolder.binding.favorite.setOnClickListener { onFavouriteIconClicked(showHolder.adapterPosition) }
+        showHolder.binding.favorite.setOnClickListener { onFavouriteIconClicked(showHolder.absoluteAdapterPosition) }
         return showHolder
     }
 

app/src/main/java/com/android/tvmaze/home/ShowsAdapter.kt

@@ -3,22 +3,19 @@ package com.android.tvmaze.favorites
 import android.content.Context
 import androidx.room.Room
 import androidx.test.core.app.ApplicationProvider
-import androidx.test.ext.junit.runners.AndroidJUnit4
-import androidx.test.filters.LargeTest
 import com.android.tvmaze.db.TvMazeDatabase
 import com.android.tvmaze.db.favouriteshow.ShowDao
 import com.android.tvmaze.favorite.FavoriteShowsRepository
-import com.android.tvmaze.utils.TestUtils
+import com.android.tvmaze.utils.TestUtil
 import com.google.common.truth.Truth.assertThat
 import kotlinx.coroutines.runBlocking
 import org.junit.After
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
-import java.io.IOException
+import org.robolectric.RobolectricTestRunner
 
-@LargeTest
-@RunWith(AndroidJUnit4::class)
+@RunWith(RobolectricTestRunner::class)
 class FavoritesRepositoryTest {
     private lateinit var favoriteShowsRepository: FavoriteShowsRepository
     private lateinit var tvMazeDb: TvMazeDatabase
@@ -37,7 +34,7 @@ class FavoritesRepositoryTest {
     @Test
     fun testShowInsertionInDb() {
         runBlocking {
-            favoriteShowsRepository.insertIntoFavorites(TestUtils.getFakeShow())
+            favoriteShowsRepository.insertIntoFavorites(TestUtil.getFakeShow())
             val favShows = favoriteShowsRepository.allFavoriteShows()
             assertThat(favShows.isNotEmpty()).isTrue()
         }
@@ -54,15 +51,14 @@ class FavoritesRepositoryTest {
     @Test
     fun testFavoriteShows() {
         runBlocking {
-            val fakeShow = TestUtils.getFakeShow()
+            val fakeShow = TestUtil.getFakeShow()
             favoriteShowsRepository.insertIntoFavorites(fakeShow)
             val favoriteShows = favoriteShowsRepository.allFavoriteShows()
             assertThat(favoriteShows[0] == fakeShow).isTrue()
         }
     }
 
     @After
-    @Throws(IOException::class)
     fun release() {
         tvMazeDb.close()
     }

app/src/androidTest/java/com/android/tvmaze/favorites/FavoritesRepositoryTest.kt renamed to app/src/test/java/com/android/tvmaze/favorites/FavoritesRepositoryTest.kt

@@ -1,11 +1,15 @@
 package com.android.tvmaze.utils
 
+import com.android.tvmaze.db.favouriteshow.FavoriteShow
 import com.android.tvmaze.home.HomeViewData
 import com.android.tvmaze.network.home.Episode
 import com.android.tvmaze.network.home.Show
 import java.text.SimpleDateFormat
-import java.util.Calendar
-import java.util.Locale
+import java.util.*
+import kotlin.collections.ArrayList
+import kotlin.collections.List
+import kotlin.collections.emptyList
+import kotlin.collections.forEach
 
 object TestUtil {
     fun getFakeEpisodeViewDataList(isFavorite: Boolean): List<HomeViewData.EpisodeViewData> {
@@ -62,4 +66,13 @@ object TestUtil {
         episodeList.add(episode2)
         return episodeList
     }
+
+    fun getFakeShow(): FavoriteShow {
+        return FavoriteShow(
+            id = 222, name = "Friends",
+            premiered = "Aug 2002", imageUrl = null,
+            summary = "Friends for life!", rating = "10 stars",
+            runtime = 132000, isFavorite = true
+        )
+    }
 }

app/src/test/java/com/android/tvmaze/utils/TestUtil.kt

@@ -34,6 +34,7 @@ object Deps {
         const val material = "1.1.0"
         const val android_test_junit = "1.1.1"
         const val multidex = "2.0.1"
+        const val robolectric = "4.4"
     }
 
     const val android_plugin = "com.android.tools.build:gradle:${Versions.android_plugin}"
@@ -140,17 +141,20 @@ object Deps {
         const val codegen = "com.squareup.moshi:moshi-kotlin-codegen:${Versions.moshi}"
     }
 
-    object Mockito {
-        const val core = "org.mockito:mockito-core:${Versions.mockito}"
-        const val android = "org.mockito:mockito-android:${Versions.mockito}"
-        const val inline = "org.mockito:mockito-inline:${Versions.mockito}"
-        const val kotlin = "com.nhaarman.mockitokotlin2:mockito-kotlin:${Versions.mockito_kotlin}"
+    object Test {
+        object Mockito {
+            const val core = "org.mockito:mockito-core:${Versions.mockito}"
+            const val android = "org.mockito:mockito-android:${Versions.mockito}"
+            const val inline = "org.mockito:mockito-inline:${Versions.mockito}"
+            const val kotlin = "com.nhaarman.mockitokotlin2:mockito-kotlin:${Versions.mockito_kotlin}"
+        }
+        const val truth = "com.google.truth:truth:${Versions.truth}"
+        const val robolectric = "org.robolectric:robolectric:${Versions.robolectric}"
     }
 
+
     object Chucker {
         const val debug = "com.github.chuckerteam.chucker:library:${Versions.chucker}"
         const val release = "com.github.chuckerteam.chucker:library-no-op:${Versions.chucker}"
     }
-
-    const val truth = "com.google.truth:truth:${Versions.truth}"
 }