Fix footer issue on pagination

Author: Ashwini Kumar

app/src/main/java/com/android/tvmaze/shows/ShowsStateViewHolder.kt

@@ -5,7 +5,6 @@ import android.view.ViewGroup
 import androidx.core.view.isVisible
 import androidx.paging.LoadState
 import androidx.recyclerview.widget.RecyclerView
-import com.android.tvmaze.R
 import com.android.tvmaze.databinding.NetworkFailureListItemBinding
 
 class ShowsStateViewHolder(
@@ -26,9 +25,8 @@ class ShowsStateViewHolder(
 
     companion object {
         fun create(parent: ViewGroup, retry: () -> Unit): ShowsStateViewHolder {
-            val view = LayoutInflater.from(parent.context)
-                .inflate(R.layout.network_failure_list_item, parent, false)
-            val binding = NetworkFailureListItemBinding.bind(view)
+            val layoutInflater = LayoutInflater.from(parent.context)
+            val binding = NetworkFailureListItemBinding.inflate(layoutInflater, parent, false)
             return ShowsStateViewHolder(binding, retry)
         }
     }

app/src/main/res/layout/activity_all_shows.xml

@@ -14,10 +14,14 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/shows"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            android:scrollbars="vertical"
             app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintLeft_toLeftOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toBottomOf="@id/toolbar"
             tools:listitem="@layout/show_list_item" />
 

app/src/main/res/layout/network_failure_list_item.xml

@@ -22,30 +22,32 @@
             android:id="@+id/error_group"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            app:constraint_referenced_ids="retry, error_msg" />
+            android:visibility="gone"
+            app:constraint_referenced_ids="retry, error_msg"
+            tools:visibility="visible" />
 
         <TextView
             android:id="@+id/error_msg"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="16dp"
+            android:gravity="center"
             android:textColor="@color/red"
             android:textSize="14sp"
             android:textStyle="bold"
-            app:layout_constraintBaseline_toBaselineOf="@id/retry"
-            app:layout_constraintHorizontal_bias="0"
+            app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintLeft_toLeftOf="parent"
-            app:layout_constraintRight_toLeftOf="@id/retry"
+            app:layout_constraintRight_toRightOf="parent"
             app:layout_constraintTop_toTopOf="parent"
-            tools:text="No Internet Connection " />
+            tools:text="No Internet Connection. Please check your internet connection and try again " />
 
         <Button
             android:id="@+id/retry"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:text="@string/retry"
             app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintLeft_toLeftOf="parent"
             app:layout_constraintRight_toRightOf="parent"
-            app:layout_constraintTop_toTopOf="parent" />
+            app:layout_constraintTop_toBottomOf="@id/error_msg" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 </layout>