fix(dock): fixing double launch of applications

Removing click from render option.
Stopping propagation on ConfirmButton.

Author: markmcdowell

packages/desktop-dock/src/components/Search/SearchRenderOption.tsx

@@ -43,14 +43,7 @@ class SearchRenderOption extends React.PureComponent<ISearchRenderOptionProps> {
         const primary = display ?? name;
 
         return (
-            <ListItem
-                ContainerProps={{ className: classes.root }}
-                ContainerComponent="div"
-                button
-                dense
-                selected={selected}
-                onClick={this.onClick}
-            >
+            <ListItem ContainerProps={{ className: classes.root }} ContainerComponent="div" dense selected={selected}>
                 {icon && (
                     <ListItemIcon>
                         <SearchResultIcon src={icon} />
@@ -73,16 +66,6 @@ class SearchRenderOption extends React.PureComponent<ISearchRenderOptionProps> {
         );
     }
 
-    private readonly onClick = async () => {
-        try {
-            const { applicationsStore, result } = this.props;
-
-            await applicationsStore?.launch(result);
-        } catch (error) {
-            console.error(`Failed to launch application: ${error}`);
-        }
-    };
-
     private readonly remove = async () => {
         try {
             const { applicationsStore, result } = this.props;

packages/desktop-dock/src/components/System/ConfirmButton.tsx

@@ -45,6 +45,8 @@ class ConfirmButton extends React.Component<IConfirmButtonProps> {
 
     @action
     private readonly onClick = (event: React.MouseEvent) => {
+        event.stopPropagation();
+
         if (!this.confirm) {
             this.confirm = true;