Skip to content

Commit d43faee

Browse files
committed
Re-enable PrompterImplTest on Windows
See #644 As advised by jline developer, create the terminal by forcing usage of the exec provider.
1 parent b29ed61 commit d43faee

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/main/java/io/reactiverse/vertx/maven/plugin/components/impl/PrompterImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ public PrompterImpl() throws IOException {
5151

5252
public PrompterImpl(InputStream in, OutputStream out) throws IOException {
5353
Terminal terminal = TerminalBuilder.builder()
54-
.system(false)
55-
.jni(false)
54+
.provider(TerminalBuilder.PROP_PROVIDER_EXEC)
5655
.streams(in, out)
5756
.build();
5857
console = LineReaderBuilder.builder()

src/test/java/io/reactiverse/vertx/maven/plugin/components/impl/PrompterImplTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package io.reactiverse.vertx.maven.plugin.components.impl;
22

33
import org.apache.commons.io.IOUtils;
4-
import org.apache.commons.lang3.SystemUtils;
54
import org.junit.After;
65
import org.junit.Before;
76
import org.junit.Test;
87

98
import java.io.*;
109

1110
import static org.assertj.core.api.Assertions.assertThat;
12-
import static org.junit.Assume.assumeFalse;
1311

1412
/**
1513
* Tests the Prompter implementation.
@@ -25,7 +23,6 @@ public class PrompterImplTest {
2523

2624
@Before
2725
public void setUp() throws Exception {
28-
assumeFalse(SystemUtils.IS_OS_WINDOWS);
2926
input = new PipedInputStream();
3027
pipeToInput = new PrintWriter(new PipedOutputStream(input), true);
3128
output = new ByteArrayOutputStream();

0 commit comments

Comments
 (0)