Feature ReactiveCommand With Parameterised Attribute (#21)

ReactiveCommand With ParameterisedAttribute

Feature ReactiveCommand With Parameterised Attribute Passthrough

Author: ChrisPulman

README.md

@@ -283,5 +283,4 @@ public partial class MyReactiveControl : UserControl
 ```
 
 ### TODO:
-- Add ReactiveCommand with parameterised Attribute pass through
 - Add ObservableAsProperty to generate from a IObservable creating a property and the property helper wired to the Observable.

src/Directory.build.props

@@ -68,3 +68,4 @@
     <AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />
   </ItemGroup>
 </Project>
+<!--SyntaxFactory helper https://roslynquoter.azurewebsites.net/-->

src/ReactiveUI.SourceGenerators.Execute/TestAttribute.cs

@@ -0,0 +1,22 @@
+// Copyright (c) 2024 .NET Foundation and Contributors. All rights reserved.
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for full license information.
+
+namespace SGReactiveUI.SourceGenerators.Test;
+
+/// <summary>
+/// TestAttribute.
+/// </summary>
+/// <seealso cref="System.Attribute" />
+[AttributeUsage(AttributeTargets.Property, AllowMultiple = false, Inherited = false)]
+public sealed class TestAttribute : Attribute
+{
+    /// <summary>
+    /// Gets a parameter.
+    /// </summary>
+    /// <value>
+    /// a parameter.
+    /// </value>
+    public string? AParameter { get; init; }
+}

src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs

@@ -92,6 +92,7 @@ public TestViewModel()
     /// </summary>
     [ReactiveCommand(CanExecute = nameof(CanExecuteTest1))]
     [property: JsonInclude]
+    [property: Test(AParameter = "Test Input")]
     private void Test1() => Console.Out.WriteLine("Test1");
 
     /// <summary>

src/ReactiveUI.SourceGenerators/ObservableAsProperty/ObservableAsPropertyGenerator.Execute.cs

@@ -25,6 +25,8 @@ namespace ReactiveUI.SourceGenerators;
 /// <seealso cref="IIncrementalGenerator" />
 public partial class ObservableAsPropertyGenerator
 {
+    private const string GeneratedCode = "global::System.CodeDom.Compiler.GeneratedCode";
+    private const string ExcludeFromCodeCoverage = "global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage";
     /// <summary>
     /// A container for all the logic for <see cref="ObservableAsPropertyGenerator"/>.
     /// </summary>
@@ -86,7 +88,7 @@ internal static ImmutableArray<MemberDeclarationSyntax> GetPropertySyntax(Proper
                 .AddDeclarationVariables(VariableDeclarator(getterFieldIdentifierName + "Helper"))
                 .AddAttributeLists(
                     AttributeList(SingletonSeparatedList(
-                        Attribute(IdentifierName("global::System.CodeDom.Compiler.GeneratedCode"))
+                        Attribute(IdentifierName(GeneratedCode))
                         .AddArgumentListArguments(
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ObservableAsPropertyGenerator).FullName))),
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ObservableAsPropertyGenerator).Assembly.GetName().Version.ToString()))))))
@@ -97,12 +99,12 @@ internal static ImmutableArray<MemberDeclarationSyntax> GetPropertySyntax(Proper
                     PropertyDeclaration(propertyType, Identifier(propertyInfo.PropertyName))
                 .AddAttributeLists(
                     AttributeList(SingletonSeparatedList(
-                        Attribute(IdentifierName("global::System.CodeDom.Compiler.GeneratedCode"))
+                        Attribute(IdentifierName(GeneratedCode))
                         .AddArgumentListArguments(
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ObservableAsPropertyGenerator).FullName))),
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ObservableAsPropertyGenerator).Assembly.GetName().Version.ToString()))))))
                     .WithOpenBracketToken(Token(TriviaList(Comment($"/// <inheritdoc cref=\"{getterFieldIdentifierName}\"/>")), SyntaxKind.OpenBracketToken, TriviaList())),
-                    AttributeList(SingletonSeparatedList(Attribute(IdentifierName("global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage")))))
+                    AttributeList(SingletonSeparatedList(Attribute(IdentifierName(ExcludeFromCodeCoverage)))))
                 .AddAttributeLists([.. forwardedAttributes])
                 .AddModifiers(Token(SyntaxKind.PublicKeyword))
                 .AddAccessorListAccessors(

src/ReactiveUI.SourceGenerators/Reactive/ReactiveGenerator.Execute.cs

@@ -25,6 +25,9 @@ namespace ReactiveUI.SourceGenerators;
 /// <seealso cref="IIncrementalGenerator" />
 public partial class ReactiveGenerator
 {
+    private const string GeneratedCode = "global::System.CodeDom.Compiler.GeneratedCode";
+    private const string ExcludeFromCodeCoverage = "global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage";
+
     /// <summary>
     /// A container for all the logic for <see cref="ReactiveCommandGenerator"/>.
     /// </summary>
@@ -120,12 +123,12 @@ internal static MemberDeclarationSyntax GetPropertySyntax(PropertyInfo propertyI
                 PropertyDeclaration(propertyType, Identifier(propertyInfo.PropertyName))
                 .AddAttributeLists(
                     AttributeList(SingletonSeparatedList(
-                        Attribute(IdentifierName("global::System.CodeDom.Compiler.GeneratedCode"))
+                        Attribute(IdentifierName(GeneratedCode))
                         .AddArgumentListArguments(
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ReactiveGenerator).FullName))),
                             AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(typeof(ReactiveGenerator).Assembly.GetName().Version.ToString()))))))
                     .WithOpenBracketToken(Token(TriviaList(Comment($"/// <inheritdoc cref=\"{getterFieldIdentifierName}\"/>")), SyntaxKind.OpenBracketToken, TriviaList())),
-                    AttributeList(SingletonSeparatedList(Attribute(IdentifierName("global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage")))))
+                    AttributeList(SingletonSeparatedList(Attribute(IdentifierName(ExcludeFromCodeCoverage)))))
                 .AddAttributeLists([.. forwardedAttributes])
                 .AddModifiers(Token(SyntaxKind.PublicKeyword))
                 .AddAccessorListAccessors(