Skip to content

Commit 1d08cd2

Browse files
ChrisPulmanChrisPulman
authored
Fix for partial classes add documentation comments (#269)
1 parent b4c45ad commit 1d08cd2

File tree

50 files changed

+99
-178
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+99
-178
lines changed

‎src/Directory.Packages.props‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<PackageVersion Include="NuGet.Protocol" Version="6.14.0" />
1212
<PackageVersion Include="stylecop.analyzers" Version="1.2.0-beta.556" />
1313
<PackageVersion Include="Roslynator.Analyzers" Version="4.13.1" />
14-
<PackageVersion Include="ReactiveUI" Version="20.3.1" />
14+
<PackageVersion Include="ReactiveUI" Version="20.4.1" />
1515
<PackageVersion Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
1616
<PackageVersion Include="Microsoft.Maui.Controls.Compatibility" Version="$(MauiVersion)" />
1717
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0" />
@@ -35,7 +35,7 @@
3535
<PackageVersion Include="xunit.runner.console" Version="2.9.3" />
3636
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.1" />
3737
<PackageVersion Include="Xunit.StaFact" Version="2.1.7" />
38-
<PackageVersion Include="FluentAssertions" Version="8.3.0" />
38+
<PackageVersion Include="FluentAssertions" Version="8.4.0" />
3939
<PackageVersion Include="Microsoft.Reactive.Testing" Version="6.0.1" />
4040
<PackageVersion Include="PublicApiGenerator" Version="11.4.6" />
4141
<PackageVersion Include="coverlet.msbuild" Version="6.0.4" />

‎src/ReactiveUI.SourceGenerator.Tests/DERIVEDLIST/BindableDerivedListGeneratorTests.FromReactiveProperties#ReactiveUI.SourceGenerators.BindableDerivedListAttribute.g.verified.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace ReactiveUI.SourceGenerators;
1313
/// ReactiveAttribute.
1414
/// </summary>
1515
/// <seealso cref="Attribute" />
16-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ReactiveGenerator", "2.2.0.0")]
16+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ReactiveGenerator", "2.3.0.0")]
1717
[global::System.AttributeUsage(global::System.AttributeTargets.Field, AllowMultiple = false, Inherited = false)]
1818
internal sealed class BindableDerivedListAttribute : global::System.Attribute;
1919
#nullable restore

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromField#TestNs.TestVM.ObservableAsProperties.g.verified.cs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,14 @@
44
#nullable enable
55
namespace TestNs
66
{
7-
/// <summary>
8-
/// Partial class for the TestVM which contains ReactiveUI Observable As Property initialization.
9-
/// </summary>
7+
108
public partial class TestVM
119
{
1210
/// <inheritdoc cref="_testPropertyHelper"/>
1311
private readonly ReactiveUI.ObservableAsPropertyHelper<double?> _testPropertyHelper;
1412

1513
/// <inheritdoc cref="_testProperty"/>
16-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
14+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
1715
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
1816
[global::System.Runtime.Serialization.DataMemberAttribute()]
1917
[global::System.Text.Json.Serialization.JsonIncludeAttribute()]

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethods#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77

88
namespace TestNs
99
{
10-
/// <summary>
11-
/// Partial class for the TestVM which contains ReactiveUI Observable As Property initialization.
12-
/// </summary>
10+
1311
public partial class TestVM
1412
{
1513
/// <inheritdoc cref="Test2Property"/>
@@ -19,11 +17,11 @@ public partial class TestVM
1917
private ReactiveUI.ObservableAsPropertyHelper<int>? _test2PropertyHelper;
2018

2119
/// <inheritdoc cref="_test2Property"/>
22-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
20+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2321
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2422
public int Test2Property { get => _test2Property = _test2PropertyHelper?.Value ?? _test2Property; }
2523

26-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
24+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2725
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2826
protected void InitializeOAPH()
2927
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethodsWithName#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77

88
namespace TestNs
99
{
10-
/// <summary>
11-
/// Partial class for the TestVM which contains ReactiveUI Observable As Property initialization.
12-
/// </summary>
10+
1311
public partial class TestVM
1412
{
1513
/// <inheritdoc cref="Test3Property"/>
@@ -19,11 +17,11 @@ public partial class TestVM
1917
private ReactiveUI.ObservableAsPropertyHelper<int>? _test3PropertyHelper;
2018

2119
/// <inheritdoc cref="_test3Property"/>
22-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
20+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2321
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2422
public int Test3Property { get => _test3Property = _test3PropertyHelper?.Value ?? _test3Property; }
2523

26-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
24+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2725
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2826
protected void InitializeOAPH()
2927
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableProp#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77

88
namespace TestNs
99
{
10-
/// <summary>
11-
/// Partial class for the TestVM which contains ReactiveUI Observable As Property initialization.
12-
/// </summary>
10+
1311
public partial class TestVM
1412
{
1513
/// <inheritdoc cref="Test1Property"/>
@@ -19,11 +17,11 @@ public partial class TestVM
1917
private ReactiveUI.ObservableAsPropertyHelper<int>? _test1PropertyHelper;
2018

2119
/// <inheritdoc cref="_test1Property"/>
22-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
20+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2321
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2422
public int Test1Property { get => _test1Property = _test1PropertyHelper?.Value ?? _test1Property; }
2523

26-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
24+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2725
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2826
protected void InitializeOAPH()
2927
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropNestedClasses#TestNs.TestVM+TestVMInner1.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ namespace TestNs
99
{
1010
public partial class TestVM
1111
{
12-
/// <summary>
13-
/// Partial class for the TestVMInner1 which contains ReactiveUI Observable As Property initialization.
14-
/// </summary>
12+
1513
public partial class TestVMInner1
1614
{
1715
/// <inheritdoc cref="TestIn1Property"/>
@@ -21,11 +19,11 @@ public partial class TestVMInner1
2119
private ReactiveUI.ObservableAsPropertyHelper<int>? _testIn1PropertyHelper;
2220

2321
/// <inheritdoc cref="_testIn1Property"/>
24-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
22+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2523
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2624
public int TestIn1Property { get => _testIn1Property = _testIn1PropertyHelper?.Value ?? _testIn1Property; }
2725

28-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
26+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2927
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
3028
protected void InitializeOAPH()
3129
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropNestedClasses#TestNs.TestVM+TestVMInner2+TestVMInner3.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ public partial class TestVM
1111
{
1212
public partial class TestVMInner2
1313
{
14-
/// <summary>
15-
/// Partial class for the TestVMInner3 which contains ReactiveUI Observable As Property initialization.
16-
/// </summary>
14+
1715
public partial class TestVMInner3
1816
{
1917
/// <inheritdoc cref="TestIn3Property"/>
@@ -23,11 +21,11 @@ public partial class TestVMInner3
2321
private ReactiveUI.ObservableAsPropertyHelper<int>? _testIn3PropertyHelper;
2422

2523
/// <inheritdoc cref="_testIn3Property"/>
26-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
24+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2725
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2826
public int TestIn3Property { get => _testIn3Property = _testIn3PropertyHelper?.Value ?? _testIn3Property; }
2927

30-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
28+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
3129
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
3230
protected void InitializeOAPH()
3331
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropNestedClasses#TestNs.TestVM+TestVMInner2.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ namespace TestNs
99
{
1010
public partial class TestVM
1111
{
12-
/// <summary>
13-
/// Partial class for the TestVMInner2 which contains ReactiveUI Observable As Property initialization.
14-
/// </summary>
12+
1513
public partial class TestVMInner2
1614
{
1715
/// <inheritdoc cref="TestIn2Property"/>
@@ -21,11 +19,11 @@ public partial class TestVMInner2
2119
private ReactiveUI.ObservableAsPropertyHelper<int>? _testIn2PropertyHelper;
2220

2321
/// <inheritdoc cref="_testIn2Property"/>
24-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
22+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2523
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2624
public int TestIn2Property { get => _testIn2Property = _testIn2PropertyHelper?.Value ?? _testIn2Property; }
2725

28-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
26+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2927
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
3028
protected void InitializeOAPH()
3129
{

‎src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropNestedClasses#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77

88
namespace TestNs
99
{
10-
/// <summary>
11-
/// Partial class for the TestVM which contains ReactiveUI Observable As Property initialization.
12-
/// </summary>
10+
1311
public partial class TestVM
1412
{
1513
/// <inheritdoc cref="Test1Property"/>
@@ -19,11 +17,11 @@ public partial class TestVM
1917
private ReactiveUI.ObservableAsPropertyHelper<int>? _test1PropertyHelper;
2018

2119
/// <inheritdoc cref="_test1Property"/>
22-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
20+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2321
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2422
public int Test1Property { get => _test1Property = _test1PropertyHelper?.Value ?? _test1Property; }
2523

26-
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.2.0.0")]
24+
[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "2.3.0.0")]
2725
[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
2826
protected void InitializeOAPH()
2927
{

0 commit comments

Comments
 (0)