feature: Update Reactive Generator for performance (#94)

* Update TestHelper to use a single Generic Type

Use Code Analysis 4.6.0

* Update Reactive Generator to be more performant

* Refactor to consider ReactiveCommand

Move shared functions into Core

Author: ChrisPulman

src/Directory.Packages.props

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
-    <CodeAnalysisVersion>4.0.1</CodeAnalysisVersion>
+    <CodeAnalysisVersion>4.6.0</CodeAnalysisVersion>
   </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservableMethodsWithName#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -8,22 +8,22 @@ namespace TestNs
     /// <inheritdoc/>
     partial class TestVM
     {
-        /// <inheritdoc cref="MyNamedProperty"/>
+        /// <inheritdoc cref="Test3Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
-        private int _myNamedProperty;
-        /// <inheritdoc cref="_myNamedPropertyHelper"/>
+        private int _test3Property;
+        /// <inheritdoc cref="_test3PropertyHelper"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
-        private ReactiveUI.ObservableAsPropertyHelper<int>? _myNamedPropertyHelper;
-        /// <inheritdoc cref="_myNamedProperty"/>
+        private ReactiveUI.ObservableAsPropertyHelper<int>? _test3PropertyHelper;
+        /// <inheritdoc cref="_test3Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
-        public int MyNamedProperty { get => _myNamedProperty = _myNamedPropertyHelper?.Value ?? _myNamedProperty; }
+        public int Test3Property { get => _test3Property = _test3PropertyHelper?.Value ?? _test3Property; }
 
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         protected void InitializeOAPH()
         {
-            _myNamedPropertyHelper = Test3()!.ToProperty(this, nameof(MyNamedProperty));
+            _test3PropertyHelper = Test3()!.ToProperty(this, nameof(Test3Property));
         }
     }
 }

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.FromObservablePropertiesWithName#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs

@@ -8,22 +8,22 @@ namespace TestNs
     /// <inheritdoc/>
     partial class TestVM
     {
-        /// <inheritdoc cref="MyNamedProperty"/>
+        /// <inheritdoc cref="Test4Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
-        private int _myNamedProperty;
-        /// <inheritdoc cref="_myNamedPropertyHelper"/>
+        private int _test4Property;
+        /// <inheritdoc cref="_test4PropertyHelper"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
-        private ReactiveUI.ObservableAsPropertyHelper<int>? _myNamedPropertyHelper;
-        /// <inheritdoc cref="_myNamedProperty"/>
+        private ReactiveUI.ObservableAsPropertyHelper<int>? _test4PropertyHelper;
+        /// <inheritdoc cref="_test4Property"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
-        public int MyNamedProperty { get => _myNamedProperty = _myNamedPropertyHelper?.Value ?? _myNamedProperty; }
+        public int Test4Property { get => _test4Property = _test4PropertyHelper?.Value ?? _test4Property; }
 
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
         protected void InitializeOAPH()
         {
-            _myNamedPropertyHelper = Test4!.ToProperty(this, nameof(MyNamedProperty));
+            _test4PropertyHelper = Test4!.ToProperty(this, nameof(Test4Property));
         }
     }
 }

src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPGeneratorTests.NonReadOnlyFromField#TestNs.TestVM.ObservableAsProperties.g.verified.cs

@@ -9,7 +9,7 @@ partial class TestVM
     {
         /// <inheritdoc cref="_test2Helper"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
-        private ReactiveUI.ObservableAsPropertyHelper<int>? _test2Helper;
+        private readonly ReactiveUI.ObservableAsPropertyHelper<int> _test2Helper;
         /// <inheritdoc cref="_test2"/>
         [global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator", "1.1.0.0")]
         [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]

src/ReactiveUI.SourceGenerator.Tests/REACTIVE/ReactiveGeneratorTests.FromReactiveProperiesWithAttributes#ReactiveUI.SourceGenerators.AccessModifier.g.verified.cs

@@ -0,0 +1,25 @@
+//HintName: ReactiveUI.SourceGenerators.AccessModifier.g.cs
+// Copyright (c) 2024 .NET Foundation and Contributors. All rights reserved.
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for full license information.
+
+// <auto-generated/>
+#pragma warning disable
+#nullable enable
+namespace ReactiveUI.SourceGenerators;
+
+/// <summary>
+/// AccessModifier.
+/// </summary>
+internal enum AccessModifier
+{
+    Public,
+    Protected,
+    Internal,
+    Private,
+    InternalProtected,
+    PrivateProtected,
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/REACTIVE/ReactiveGeneratorTests.FromReactiveProperiesWithAttributes#ReactiveUI.SourceGenerators.ReactiveAttribute.g.verified.cs

@@ -0,0 +1,31 @@
+//HintName: ReactiveUI.SourceGenerators.ReactiveAttribute.g.cs
+// Copyright (c) 2024 .NET Foundation and Contributors. All rights reserved.
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for full license information.
+
+using System;
+
+// <auto-generated/>
+#pragma warning disable
+#nullable enable
+namespace ReactiveUI.SourceGenerators;
+
+/// <summary>
+/// ReactiveAttribute.
+/// </summary>
+/// <seealso cref="Attribute" />
+[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ReactiveGenerator", "1.1.0.0")]
+[AttributeUsage(AttributeTargets.Field, AllowMultiple = false, Inherited = false)]
+internal sealed class ReactiveAttribute : Attribute
+{
+    /// <summary>
+    /// Gets the AccessModifier of the set property.
+    /// </summary>
+    /// <value>
+    /// The AccessModifier of the set property.
+    /// </value>
+    public AccessModifier SetModifier { get; init; }
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/REACTIVE/ReactiveGeneratorTests.FromReactiveProperiesWithAttributes#TestVM.Properties.g.verified.cs

@@ -0,0 +1,29 @@
+//HintName: TestVM.Properties.g.cs
+// <auto-generated/>
+using ReactiveUI;
+
+#pragma warning disable
+#nullable enable
+
+namespace TestNs
+{
+	/// <summary>
+	/// Partial class for the TestVM which contains ReactiveUI Reactive property initialization.
+	/// </summary>
+	[global::System.CodeDom.Compiler.GeneratedCode("ReactiveUI.SourceGenerators.ReactiveGenerator", "1.1.0.0")]
+	public partial class TestVM
+	{
+		/// <inheritdoc cref="_test3"/>
+		[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]
+		[System.Text.Json.Serialization.JsonInclude]
+		[System.Runtime.Serialization.DataMember]
+		public int Test3
+		{ 
+			get => _test3;
+			[global::System.Diagnostics.CodeAnalysis.MemberNotNull("_test3")]
+			set => this.RaiseAndSetIfChanged(ref _test3, value);
+		}
+	}
+}
+#nullable restore
+#pragma warning restore

src/ReactiveUI.SourceGenerator.Tests/REACTIVE/ReactiveGeneratorTests.FromReactiveProperties#ReactiveUI.SourceGenerators.AccessModifier.g.verified.cs

@@ -20,4 +20,6 @@ internal enum AccessModifier
     Private,
     InternalProtected,
     PrivateProtected,
-}
+}
+#nullable restore
+#pragma warning restore