Skip to content

Commit 68ed61c

Browse files
Copilotglennawatson
andcommitted
fix: add System.Reactive.Disposables.Fluent namespace and fix RS2005 analyzer warning
- Add using System.Reactive.Disposables.Fluent to TestViewModel.cs (DisposeWith moved there in System.Reactive 6.1.0) - Fix duplicate RXUISG0018 entries in AnalyzerReleases.Shipped.md (merge into single entry) Build completes with 0 errors, 0 warnings. All 33 tests pass on net8.0, net9.0, and net10.0. Co-authored-by: glennawatson <[email protected]>
1 parent 7027b75 commit 68ed61c

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
using System.Reactive;
99
using System.Reactive.Concurrency;
1010
using System.Reactive.Disposables;
11+
using System.Reactive.Disposables.Fluent;
1112
using System.Reactive.Linq;
1213
using System.Reactive.Subjects;
1314
using System.Runtime.Serialization;

src/ReactiveUI.SourceGenerators.Roslyn/AnalyzerReleases.Shipped.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ RXUISG0013 | ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator | Error |
2020
RXUISG0014 | ReactiveUI.SourceGenerators.ObservableAsPropertyGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
2121
RXUISG0015 | ReactiveUI.SourceGenerators.ReactiveGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
2222
RXUISG0017 | ReactiveUI.SourceGenerators.ObservableAsPropertyFromObservableGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
23-
RXUISG0018 | ReactiveUI.SourceGenerators.ObservableAsPropertyFromObservableGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
24-
RXUISG0018 | ReactiveUI.SourceGenerators.ReactiveGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
23+
RXUISG0018 | ReactiveUI.SourceGenerators.ObservableAsPropertyFromObservableGenerator/ReactiveGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
2524
RXUISG0019 | ReactiveUI.SourceGenerators.BindableDerivedListGenerator | Error | See https://www.reactiveui.net/docs/handbook/view-models/boilerplate-code.html
2625

2726
## Rules
@@ -78,11 +77,8 @@ This rule checks if there are any Properties to change to Reactive Field, change
7877
- RXUISG0017 - ObservableAsPropertyFromObservableGenerator
7978
This rule checks if the `ObservableAsProperty` has Invalid generated property declaration.
8079

81-
- RXUISG0018 - ObservableAsPropertyFromObservableGenerator
82-
This rule checks if the `ObservableAsProperty` has Invalid class inheritance, must inherit from `ReactiveObject`.
83-
84-
- RXUISG0018 - ReactiveGenerator
85-
This rule checks if the `Reactive` has Invalid class inheritance, must inherit from `ReactiveObject`.
80+
- RXUISG0018 - ObservableAsPropertyFromObservableGenerator/ReactiveGenerator
81+
This rule checks if the `ObservableAsProperty` or `Reactive` has Invalid class inheritance, must inherit from `ReactiveObject`.
8682

8783
- RXUISG0019 - BindableDerivedListGenerator
8884
- This rule checks if the `BindableDerivedList` has Invalid property inheritance type.

0 commit comments

Comments
 (0)